GitLab

Change-Id: I7716faf9e5d480fe52ce9939d1f7093494d6d37a
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Half of the widget height is a particularly bad estimate for the
default height of a console item. Focusing editable items should be
done by explicitly transferring focus. Also, this only "worked" if
an editable or formerly editable row was the very first line in the
view, which rarely happens.

By default, if no settings are present, all log categories are enabled
now. Otherwise we might miss the error messages resulting from failed
evaluations.

Repeatedly setting the filter regexp to the same thing doesn't signal
a filter change, which is what we actually want when changing the
filter.

Change-Id: Ibe33b0438d92e777bdceaf9af032fc5117ba4041
Reviewed-by: hjk <hjk@theqtcompany.com>

Using Utils:TreeView automatically gives us the capability for loading
item as they are expanded. This way we can show recursive structure in
the console as well as load data from the debug server on demand.

Also, properly print error messages received from unsuccessful
command evaluations.

Task-number: QTCREATORBUG-14931
Change-Id: I66d440eedd9723b04670169b27db1ee18f3f2891
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I60993e2a140445468b6fe98604cb19329dc35b1c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Change-Id: I82ea54a1e23625690192a967b5f33451cdc199af
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Change-Id: I1e2671d15b0db3c670b86dd0d4bed5ee09e866f1
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

This signal was emitted from two places. In one of them, the argument
was the pure string from the line edit, and in the other one the "raw
path", that is, the aforementioned string processed by cleanPath() and
fromNativeSeparators().
We now use the latter in both contexts. A look at the slots does not
suggest anyone is interested in the other value rather than this one.

Change-Id: Iacb6e0815004b2ef0107bfef03b97b46015da989
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Ia6ac2afd84342a72e50eaaf833960a618c88bda6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

The "password" type as used until now should also be okay, but does not
work with dropbear.

Task-number: QTCREATORBUG-14913
Change-Id: I2fac255acf326e509f68c9de97c3cc9f00b2a373
Reviewed-by: hjk <hjk@theqtcompany.com>

An QAbstractSocket can disconnect itself on flush(), which we call
after sending any packets. This leads to the packet protocol getting
deleted and in the next iteration of the loop
QmlDebugConnectionPrivate::readyRead() we'd use a null pointer.
Prevent that by checking for null.

Change-Id: Idfdb68a10c3e4deee7b305ff3b028247809090a6
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I5f458f297c8bb1b4cd33655ffe30129c04f6b562
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

src/libs/3rdparty/cplusplus/Lexer.cpp(88): warning #68: integer conversion resulted in a change of sign

Change-Id: I7de033f80b0e4431b7f1ffff13fa771758c95611
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Found by ICC
qmljsreformatter.cpp(410): warning #177: function "<unnamed>::Rewriter::firstOnLine" was declared but never referenced

Change-Id: I7de033f80b0e4431b7f1ffff13fa77233116f0cb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The services need to be loaded before the first QML engine is created.
The first QML engine may be created before a client connects. When the
JavaScript debug service is loaded the engine is put into interpreter
mode as we don't support debugging in JIT mode. Profiling, however
should be done in JIT mode, whenever possible.

Thus, in order to avoid the loading of unnecessary plugins and to get
better results from the QML profiler we tell the debug server which
services we expect, even before the client connects. Qt 5.6 will support
additional command line arguments to specify the services and this
change uses them.

Change-Id: I6dcee016c39995e9adada6eaf0e39d8299c9b7e7
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>

They are already sorted in an intended order.

Task-number: QTCREATORBUG-14872
Change-Id: If28d41eb220cb875fa5ef25f0fab075329900bff
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>

Change-Id: I8381f1d1b0acd3344a05d0845d9fe04d2bf27251
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>

Change-Id: I3b4966aca5026d090a5a7653be6dd09bd0ea66fd
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

In fact, hostArchitecture is only called on MSVC auto-detection, which
is only done on startup.

On the other hand, all the other functions in HostOsInfo are independent
on external calls, so adapt this one in case it is used in the future.

Change-Id: I4646d87cb3b976e358276482cad1b14bfc430964
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: Ic1237351f6d67cdd8a5d19500d833dce96b08f36
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

The QReadLocker died before locking anything.

Change-Id: I8d50082bfcdd70c2e29cf637a6cfb327f106f2c3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Now address sanitizer will not show false positives.

Change-Id: Ieeb4dc31697920ed1ca542f5647f4cb0b23a29ab
Task-number: QTCREATORBUG-14713
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

From 5.6 on this will make Qt stream events instead of sending them all
in the end, reducing the time it takes to load data.

Change-Id: I23b1fced4a527b58ee3312fc5c48b23d3dc6260e
Task-number: QTCREATORBUG-11823
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Task-number: QTCREATORBUG-14849
Change-Id: I26f69b5c6c421b5eb965c96d75df15d16e960237
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: Ife1d3f963ef6781f96031f41ae3858b2c278145e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

If no template is found, findSpecialization will crash

Task-number: QTCREATORBUG-14748
Change-Id: I94b970e6eb994f0a8d85a4b996e52fcff0affef3
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Occurs in boost/phoenix.hpp

Task-number: QTCREATORBUG-14748
Change-Id: If89b0db48346aac72e0d8aaa8d165b2bf43bd784
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

ASTPath uses TranslationUnit::getPosition(), which returns reasonable
results for:

    1. non-expanded tokens
    2. expanded but not generated tokens

The expanded *and* generated tokens case is not handled since there is
no reasonable mapping from generated tokens to a continuous line/column
information. Consider:

    #define DECLARE_FOO int foo; // Multiple generated tokens
    DECLARE_FOO // ...can be mapped to this line, but to which columns?

Since the result where not valid for the expanded and generated case,
ASTPath took the wrong branches. Avoid this by skipping generated
tokens.

Change-Id: I33a2e0f62917f87d691b19feaeef67b09ea8d563
Task-number: QTCREATORBUG-13386
Task-number: QTCREATORBUG-13390
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I936e75ddc26b812c4570859e6a61c2a09590ed98
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

...by enabling the logging rule:

    qtc.clangbackend.timers=true

Change-Id: I085c6bbebc0343b74bcb90119d1ebb80ad49518d
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

We can rely on Qt to send a completion message nowadays and keeping
the recording button active enables us to stream events without UI
glitches.

Change-Id: If897413e5224b359042235e4653fc2a35b0b92e7
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: Id5b5ed289a3fd86bd8b84e6429c18f417ca793a7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

The number specified in the algorithm name is a maximum.

Change-Id: I70177a135be29adbf9b58d0dd3b9de339f0d3b7e
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

using CodeCompletions = QVector<CodeCompletion>;
using CodeCompletionChunks = QVector<CodeCompletionChunk>;

Change-Id: Id729a43566c23dc000e44d79ccf4a49e4f235f51
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER is entirely private and may
change at any time.

More importantly, this macro is not necessary at all. QByteArrayLiteral
solves the problem neatly.

Change-Id: Ib306f8f647014b399b87ffff13f2c0f38c459ab1
Reviewed-by: Adam Majer <adamm@zombino.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

In the default format of ssh-keygen.

Change-Id: Ibea5f4bde5cc6ea343f75c73f786437178e4350e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Namely, 384 and 521 bits.

Change-Id: I245f8521b86d615163e5c071014e455a584c1305
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

All host keys can be used with all HMACs.

Change-Id: I71055d3085d13683e53491ac9a9d98734dd6e7e5
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

By using some of the infrastructure in Utils::Environment. Due to
wanting to find all cmake executables in PATH and not just the
first one, we need some custom code.

(cherry picked from commit ca8b43f6

)
Change-Id: If3161d712b9f6e659450a3d0647f83344e68ba5d
Task-number: QTCREATORBUG-14740
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

...by writing unsaved file content and project part arguments to
temporary dirs.

Change-Id: Ic411700cb3da756788bbb315851ff38b0100fe71
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

The iterator needs to be tested against the end() of
the same container.

Change-Id: Ia4d208650d922d529ea074d4cd0eac9f4ac76b87
Reviewed-by: BogDan Vatra <bogdan@kde.org>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>