GitLab

The logic to not hide the popup if it got active was lost in
e133ee89

Change-Id: Ic3af147194f7ad18d510e827db1d5804e48e1f97
Reviewed-by: David Schulz <david.schulz@qt.io>

The item delegate's sizeHint will only be correct after there are actual
items to show. So behave similar to uniformRowHeights by waiting for the
first data to arrive and then setting the size of the completion list
and the popup.

Task-number: QTCREATORBUG-18457
Change-Id: I7aa18988e07e21c2ec6587e83fb0de2dce6552ef
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: Idaea2197d8666a251cef46fa9032494e91cc29a1
Reviewed-by: David Schulz <david.schulz@qt.io>

The change to using the search result item delegate made the items
squeeze pretty much together. Explicitly add some spacing again.

Task-number: QTCREATORBUG-18457
Change-Id: If056b94e5a1629be574a0d864361dc72e356544a
Reviewed-by: David Schulz <david.schulz@qt.io>

And open a popup if other windows are active.
That way we avoid switching to the main window.

Change-Id: Ia6d8d3fb4361ac31e406356d40056a2c0b79d114
Reviewed-by: David Schulz <david.schulz@qt.io>

The input field may not care whether the result list is actually in a
popup or not.

Change-Id: Ia15f9a32441243de458e4e55d2daef6204b9dd59
Reviewed-by: David Schulz <david.schulz@qt.io>

By not getting the currently selected row at arbitrary times.
This introduces a slight behavior change for an improbable edge case,
which could be viewed as an improvement:
If there are multiple filters active, and the first, higher priority one
could finished much faster than the second, lower priority one, the
following sequence

Wait for results from first filter
Press return
Move up or down
Second filter finishes/cancels

without this patch did not select the item where you pressed return, but
the item that was selected when the second filter finished.

Change-Id: Iba2c72e2494824de961782ba3fe0bb1041072614
Reviewed-by: David Schulz <david.schulz@qt.io>

Use optional to get rid of an explicit bool to keep track of whether
file icons have been resolved or not.
Relying on QIcon::isNull() would not be good, because the result from
QFileIconProvider can be a null icon.

Change-Id: I56720d56687f5e35d0c50b485d50e324d9940f30
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Change-Id: I9f99ef14c318e54ddb84a462e767d2f1c1e2f3ec
Reviewed-by: hjk <hjk@qt.io>

Change-Id: I380e28444b33caa2c3c2724ad2933a13fdcb312a
Reviewed-by: David Schulz <david.schulz@qt.io>

Add possibility for filters to set a new search text when accepting
an entry.
Move placeholder text update from locator manager to widget.
Propagate filter update through signal-slot connection instead of directly.
LocatorManager::show is the only place left that directly references the locator widget.

Change-Id: Id61354d9f166c2af8c9d5528ad8998c7c6b8e1ab
Reviewed-by: David Schulz <david.schulz@qt.io>

Change-Id: I3949cca285d49fddf9c8c476ad19ed7ce9a06f1c
Reviewed-by: David Schulz <david.schulz@qt.io>

Task-number: QTCREATORBUG-17899
Change-Id: If0b12d6c3b412437149a6ba0a9be34f7c0a983ba
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>

Change-Id: Ia166e9667076e46770a754b626ceb28080139e79
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Useful for the file system filter with long file names, and for the
execute filter with long commands.

Change-Id: I2884f3d3832586ce2576d8537046b2853ca31f09
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

For macOS with keys Home and End, for the others with
Ctrl+Home and Ctrl+End.

Change-Id: I73cde89b57bc3cce89c6638d2692bcafbd4710af
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

Make it 1/2 of the total width.

Task-number: QTCREATORBUG-16768
Change-Id: I6c87b6c9aa4dd39d598c4890a30cda7d6f386d99
Reviewed-by: Cristian Adam <cristian.adam@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

Take up to 2/3 of the main window size.

Task-number: QTCREATORBUG-11843
Change-Id: I9bcb8c839190cceab0e6213cb943c5f021bcb1e7
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

* Use inline member initialization
* Remove unneeded "using"
* Replace if/else with switch-case

Change-Id: I32589e850f259c6e2d098e623077bec0a6f9eb4b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

This way we can use them from libraries, not only from plugins.

Change-Id: Ic35cfd5f04d638d87606bf272b2c00ded1267c1b
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

They are needed in the timeline view.
The change in qtcreator-project.qdocconf makes sure
that qdoc still finds the referenced icons.

Change-Id: I812fba8e57d06d93efc00c295467c83c08cd1784
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

On OS X, Ctrl+n and Ctrl+p, the Emacs bindings for next and previous,
are global throughout the system. In Qt Creator they work for menus,
code completion widget and other places like Vimium plugin, but not
the Locator widget. This change adds that functionality to Locator
too and makes navigating Locator items easier.

Change-Id: Iebce53d55841ba97d35ad2d433b0d9840d5e4137
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Lead to the tiny bug that one could not trigger a shortcut "Alt+Escape"
while in the locator input field

Change-Id: I4eb3182588357f8ce0817459b3d20e4bbd87287a
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: I89de84e2de0dcce759170d124a214a8d4c004130
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

This patch removes the locator.png icon and replaces it with a
menu-friendly variation of the zoom icon.

The current ZOOM icon becomes ZOOM_TOOLBAR.

Change-Id: I8817c5c420801351db659caa4c4190a9074be720
Reviewed-by: hjk <hjk@theqtcompany.com>

..by setting Qt::WA_Hover

Change-Id: If4b6e8d443a70e18796dd78b261495f2400db0f4
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

It is now deduced from either the type of the
QFutureInterface<ResultType> function argument, or the return type.

Change-Id: Iddab3cc329206c649a6e55a44b2de2d406701dee
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

The heavy lifting was done by clazy.

Change-Id: I2dde14919d917816d02117338205f8f861d8af0a
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

* Update files in src/plugins

Change-Id: Ia5d77fad7d19d4bb3498e78661982f68729adb22
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I258259da7767087a8319d6a4489aa4d6c3b32c6f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

QtConcurrent limits resource usage to a global number of simultaneous
threads. That means that if some QtConcurrent based algorithm currently
grabs all threads, any other use of QtConcurrent blocks, which is not
what we want.
Use the new threading methods of C++11 instead, but still use
QFuture(Interface) manually for status reporting.

Task-number: QTCREATORBUG-14640
Change-Id: I8fecb43b5235da92c0d239e7dd5f2c108ab32ebf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I06556a6ea2151074796d462096e1c9e70e348397
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

For example: "f ", "m ".

Broken by b6e4e966.

Change-Id: Ic1e389c52579c86479e2c066eadfb4aaf4b66700
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

It is not very intuitive, and can easily happen when copy&pasting into
locator.

Change-Id: I51d226b8e834c43eedc042035a9b90aa7ee4844f
Task-number: QTCREATORBUG-15399
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Instead of describing icons via file name or in the themed icons case
via
a string that is a list of mask/color pairs, we have now a class for it.

Icons are now listed in per-plugin *icons.h headers.

RunControl::m_icon was The only place left where an icon property was in
fact a string. This patch changes that member to be a Utils::Icon.

Change-Id: Ibcfa8bb25e6d2e330c567ee7ccc0b97ead603177
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

We cleared focus on the locator input when it lost focus because the
active window changed, so the popup is not reopened when the Qt Creator
window is activated again. Instead keep the focus in the locator input,
but do not open the popup if the focus comes back to it because of an
active window change.
Then we need to make sure that the popup is always opened when
explicitly requested through show(...).

Change-Id: Icd78673bece542ae78340b2ab6aa7834d700a3b7
Task-number: QTCREATORBUG-13548
Task-number: QTCREATORBUG-9953
Reviewed-by: André Hartmann <aha_1980@gmx.de>

http://blog.qt.io/blog/author/didesous/ announced new designs/themes
for Qt Creator. This patch replaces many of the existing toolbar icons
with recolorizable masks for better theming support.

Change-Id: I557aa485205fe2624f33724226f698c303342b40
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Change-Id: I1606a0c51c959f8c90ea74f7800d708bf95329b5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

... and default to C_GLOBAL. A rather common case.
Similar for ActionContainer::addSeparator().

Change-Id: I7f9ba573af201c0a472132d5a494ad17cc4175b7
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

PageIds are supposed to be unique, so the CategoryId can be determined
from the PageId. Look for PageIds in the already expanded categories
first before searching through expensive categories.

Change-Id: I006beb0df6183453163ac1810fe59a306a0f52b1
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>