GitLab

We use forward slashes in all internal paths, even on Windows.

Change-Id: Ie0b418c770dad96829dd357fe425616b6d3a5b82
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

... when both the shared and the user file are older than 3.2.

Change-Id: I9e16d67c2b566c43060cb9e05f02ea3a5343065f
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I2e8709a84882dde5a6bc96b4bd213581175c6c8c
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

The QML part was broken due to recent changes relating to gdbserver
"multi" mode.

Task-number: QTCREATORBUG-12928
Change-Id: Ia806f0cbfedd6961138f7cd89a0387bd851ff83e
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

The logic checking the other check box if the only checked one is being
unchecked was faulty, only updating the UI but not the actual state. As
a result, both C++ and QML were switched off, resulting in interesting
behavior when starting a debugging session.

Change-Id: Ifd61f7080ad70f816fa80b416f8594f057c299d4
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

The object has already been deleted when the stepRemoved() signal comes
in, so we call disconnect() on a dangling pointer.

Change-Id: Ife5192f9edbde3d42c96dbcae60d7eb03b051745
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I634d31d3dd6421b5afdd32350513c61bf7ad683b
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I980ad15147f419b2d42d86b2a62ebf2875a3c2d8
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

...since the AST will be released at some point from another thread.

Change-Id: I71d20228ebec71e98dca3474452677ec63ffe4c6
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

When the environment variable QTC_NO_FUNCTION_DECL_DEF_LINK_TRACKING is
set, no method declaration/definition tracking is performed. This is to
see if QTCREATORBUG-11262 is triggered due to the tracking.

Task-number: QTCREATORBUG-11262
Change-Id: Id4cb1fabf9304f8bf42393cb65c402adf8818e2a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

The CppRefactoringChanges::fileNoEditor takes a Document from the
snapshot it has. Although this snapshot is a safe copy, it might have
been gotten right after it was updated by indexing. Such a document will
still have its AST. If this AST is used by any refactoring action
without retaining it, the pointers will be dangling after a short while
(specifically: after the locator has extracted all the information).

The fileNoEditor method is called by the declDefLinkFinder to search
the target document. The snapshot is obtained before, and contains the
document for the semantic info. However, the target document will not
come from the semantic info, but from the indexer.

Change-Id: I212ff41dde6910e94e80552b2c3e5911fe9496ae
Task-number: QTCREATORBUG-11262
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

This will hopefully help a bit in resolving the crashes that happen in
QCoreApplication::notifyInternal.

Change-Id: Ib3aa8c1a1f50778bd89938d7c529d8399ccf91ea
Task-number: QTCREATORBUG-11262
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Qt draws lines on half-pixel boundaries. Because of
rounding, this is not visible with non-scaled aliased
painting. However, on a high-DPI screen with scaling
enabled, the line under the menu bar is drawn at a one
pixel offset, which causes it to overlap the menubar items.

This change draws the line at the mathematically correct position.

Task-number: QTBUG-38858
Change-Id: I0a2260507d346b52a36258d479cde87064d991ef
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

Task-number: QTCREATORBUG-12782
Change-Id: I44808f10504991fb9fc621acedd43035698c6afb
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

For some reason ApplicationWindow seems to be twice in the type hierarchy.
This means all properties specific to ApplicationWindow were
duplicated. This patch avoids adding a property twice.

Task-number: QTCREATORBUG-12910
Change-Id: I8a06fa15778335be8c6977369ece94385b25487c
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Task-number: QTCREATORBUG-12912
Change-Id: Ie0794d46d75caadcb3155a25d2950e1e464f7079
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>

Change-Id: Id71a21b273d2d156cb55033ad6a9ae2bcf5565ca
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

It conflicts with Rename Symbol

Change-Id: I168fe7975712ce4ff8c04099d8b2aff8e82d1325
Reviewed-by: hjk <hjk121@nokiamail.com>

extraSelections is a local variable as well as a member
function of BaseTextEditorWidget, but if the full
qualified name is used the compiler thinks that this
is a static function call, which happens with the
MSVC 2010. Use the this pointer to use the correct
function.

Change-Id: I44ce96b2c17e7259274f2103ce70ae9b2ae3a56b
Reviewed-by: hjk <hjk121@nokiamail.com>

it needs a / at the end ...

Change-Id: I546d70bf8e1d70ca3e08e3d563e427a96ad73209
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Since the plugins moved in 6aad96d8

,
the rpath of the clang code model plugin was broken for deployed clang library.

Change-Id: I5d59390540918c73a2cd217bb5ebf8f947122f01
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: I36c8393ace088d7702d1771e806e1e420eb8bd95
Reviewed-by: Mitch Curtis <mitch.curtis@digia.com>

Change-Id: Ia92929d69d8d25b926be3061dbe3ee5dc95ff44a
(cherry picked from commit f6fea87a

)
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Prevent failures in situations where Qbs project files are still write
protected, like e.g. in Perforce VCS.

Change-Id: I2828546adcc314b7c6b0b6720e1cf96733d62fa5
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: I224da43ad46acfce33fb62926df62c211164ed40
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: Id43d168859012ce9dcebb62e996cfdef7079aaaa
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

SOFT ASSERT: "!m_id.isValid()" in file .../debuggeritem.cpp, line 92

Introduced in 5b5a7d1d



Change-Id: I82416302402770d885f8eb96b6966294a5368cbe
Reviewed-by: hjk <hjk121@nokiamail.com>

Task-number: QTCREATORBUG-11728
Change-Id: I7f3ad47a2fe4a247efefe57a0de5149c64ac2456
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

it is entirely plausible that the precise evaluation would succeed,
while the cumulative would fail due to some serious inaccuracies
introduced by it. such problems would be particularly hard to debug, as
we suppress error messages from the cumulative parsing, so the user
would get a "Giving up" message without any context.

Change-Id: I826b3b1d838808464b551e8ee0d7375d239442a3
Reviewed-by: Gatis Paeglis <gatis.paeglis@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I6fc1f0eceeff4286936999986263cb034c1a7663
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Change-Id: I3821a8817bbb7e76f95f53d058c2f1599320bff7
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Task-number: QTCREATORBUG-12888
Change-Id: I732f1bfe44dc47d0c96570649f3bf8c0e3f40dda
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

The general idea is to find an item that matches closely what
is stored in the kit information, but also accept item based
on toolchain matching as fallback with a lower priority.

Change-Id: I41a00562fa4308eb834d853865c41873ef362bd8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk121@nokiamail.com>

Updating the completion list is done in a separate thread, and for the
all and current project filters that requires a slot to be synchronously
executed on the main thread.
Triggering the update first canceled a running update and waited for
it to finish, before starting the next update. If the first update
hadn't run its code on the main thread yet, it was never be able to,
and never finished.

The patch just removes the waitForFinished after the cancel. There is no
reason to wait, since we retrieve all results only when we get the
finished signal of a non-canceled update anyhow.

Broke with 05c26767

 when fixing
QTCREATORBUG-12592

Task-number: QTCREATORBUG-12875
Change-Id: Iba9d46d469e6b2c7e894963d964c2eaca4bc4d93
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

They are no longer app bundles

Change-Id: Ia2b9c62d478ae4ccacb20dc20eda44695d0fe960
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Change-Id: I3d9a9ba76d0da4def215541ccff02afc26e5e5f1
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

To HEAD of the 1.3 branch.

Change-Id: Idf631edd93cf7dd0ac005634d2fcd2999f148099
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

If a qbs project gets closed (e.g. due to a session switch) while the
project is being loaded, the corresponding QFuture does not get deleted
and the progress bar will be around forever. This patch fixes that.
Note: The project resolving by qbs was already correctly canceled; this
is about the visual effect only.

Change-Id: If00aed949505088cfdb87d08e26f3b62ccea5fd1
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Task-number: QTCREATORBUG-12867
Change-Id: I4fcc1bdf74f1391f33fe99be16f8acbb9e049165
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

If items are dragged into the navigator we should not set the position
to 0,0 expliticly, because this breaks layouts.

Change-Id: I6e7cd130390ab68d13904d379a35dc4fa4337231
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>