- 10 Jul, 2017 12 commits
-
-
Orgad Shaneh authored
Change-Id: Iee9cc2232c002ea960f05848df02ac0658017911 Reviewed-by:
hjk <hjk@qt.io> Reviewed-by:
David Schulz <david.schulz@qt.io>
-
David Schulz authored
Do not check whether a refactoring marker is visible, but always provide enough space to display one. Change-Id: I3f9dbb973b9067bd8177773d6fc878b47427232e Reviewed-by:
Christian Stenger <christian.stenger@qt.io>
-
Jaroslaw Kobus authored
Change-Id: Idb7a506e81001fda79eff72c0c23b9945103cad0 Reviewed-by:
Eike Ziller <eike.ziller@qt.io> Reviewed-by:
Tobias Hunger <tobias.hunger@qt.io>
-
Alessandro Portale authored
The algorithm that creates the overlay selection path adds many redundant curve elements. That is quite ineffecient when painting and it also creates visual gaps. This patch simplifies the path and therefore substantially reduces the elements and removes the gaps. Task-number: QTCREATORBUG-18518 Change-Id: If3558e226825426ca6b143eeba4239e6f0061df0 Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Eike Ziller authored
Conflicts: qtcreator.qbs Change-Id: Ic5e268326d93172208de291d31a716e437b9cedf
-
Orgad Shaneh authored
Change-Id: I897ac7ed45ff50a7dfd7c1c7c5abd8ad417f84af Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
-
Orgad Shaneh authored
* Use initializer list and Utils::transform * Remove unneeded override Change-Id: I36ff9b9900fa6169ed1529bbbbdba13075353332 Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
-
Eike Ziller authored
The tree view uses a connection to rowsInserted internally for updating the view, so we may only remove our specific connection to updateSize. Otherwise the view stops showing items after the first rowsInserted. Task-number: QTCREATORBUG-18522 Change-Id: Ib80fa39ee5556221a447db3556495a3608e3f62b Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
Orgad Shaneh authored
Change-Id: I223dc3c00aa7d4b2cda743a9292272387177ed93 Reviewed-by:
hjk <hjk@qt.io>
-
Orgad Shaneh authored
Change-Id: Ia5444b935c964fd450bed67306dc10ed9d54e7c7 Reviewed-by:
hjk <hjk@qt.io>
-
Orgad Shaneh authored
Change-Id: I1ef2db7ce7546118d68925708dc2c1573653417c Reviewed-by:
hjk <hjk@qt.io>
-
Eike Ziller authored
Since e.g. whitespace can have a different foreground color than "normal" text, we have to explicitly set the color for the underline when hovering. Use foreground color if there is no specific text color set for "normal" text. Change-Id: I9825d24af0d598b039a0db9ed86966605e22ac04 Reviewed-by:
Jarek Kobus <jaroslaw.kobus@qt.io>
-
- 07 Jul, 2017 17 commits
-
-
Jake Petroules authored
Instead of hardcoding the value of LSMinimumSystemVersion in Info.plist where we will always forget to update it (and since Qt Creator can be built with multiple versions of Qt, it will almost certainly be wrong for one of those versions), automatically determine the value from QMAKE_MACOSX_DEPLOYMENT_TARGET, which is authoritative. This should prevent mishaps where users try to run Qt Creator on older OS versions and receive a crash dialog instead of the friendly "This app requires a newer version of macOS" message that a properly set LSMinimumSystemVersion value will induce. The Qbs build is not affected by this problem, as Qbs automatically handles the minimum deployment target even when a custom Info.plist is specified. The solution chosen in this patch was used instead of QMAKE_SUBSTITUTES because the Qbs build also uses the Info.plist input file and it would break the Qbs build if the quotes were to be escaped, since it would become invalid XML. Change-Id: I20625a2fae546c6597a567f28864b12917e8ac39 Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@qt.io>
-
Jake Petroules authored
This patch also sets the minimumQbsVersion to 1.7 because that's the version that is actually documented as being required in the README. Change-Id: I862daaf5fa34ab2cc5db47581689e08aa34f0910 Reviewed-by:
Christian Kandeler <christian.kandeler@qt.io> Reviewed-by:
Eike Ziller <eike.ziller@qt.io> Reviewed-by:
Jake Petroules <jake.petroules@qt.io>
-
hjk authored
The mapping was there, but not connected to the core actions. Change-Id: I9faa1c47afe409caaa0462740a6865d99d959b44 Reviewed-by:
Lukas Holecek <hluk@email.cz> Reviewed-by:
hjk <hjk@qt.io>
-
hjk authored
Not in start(), when it would add extra connections on each re-run. Change-Id: I5fe9e047a188276f3bde54227dc0509ab77366c4 Reviewed-by:
Christian Kandeler <christian.kandeler@qt.io>
-
hjk authored
As promised in 112e3222. The temporary workaround can go now. Change-Id: Ia98abfb21577ff073b069eaaf0edb5fb1227114d Reviewed-by:
Christian Kandeler <christian.kandeler@qt.io>
-
hjk authored
Makes remote output appear again in the Application Output pane, and is arguably the right thing to do anyway. Change-Id: I05c365eec43f60a85482b8ae7d5856b3a31ee6f8 Reviewed-by:
Christian Kandeler <christian.kandeler@qt.io>
-
Riitta-Leena Miettinen authored
Change-Id: I9fe1f0982829aa4e5998f03f098bef7679b44443 Done-by: Lukas Holecek Reviewed-by:
Lukas Holecek <hluk@email.cz> Reviewed-by:
hjk <hjk@qt.io>
-
Eike Ziller authored
Task-number: QTCREATORBUG-9445 Change-Id: I1c60181b7e15c66b88cc1d5ec7584951d3aa46a0 Reviewed-by:
Jarek Kobus <jaroslaw.kobus@qt.io>
-
Orgad Shaneh authored
Change-Id: Ib21a62152008a0b428f93a58d32685e2c0b0dc3b Reviewed-by:
Eike Ziller <eike.ziller@qt.io> Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
Orgad Shaneh authored
Change-Id: I8c37728ca5de20e2b68e6d0ac7fc120baa696040 Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
-
Kai Koehne authored
Change-Id: Icdfe9a58a0b0c0d5773c2c5a0d433ea903e66138 Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
-
hjk authored
It looks like the case where workers need talk to each other by only knowing the type of the 'partner' does not exist in practice anymore. With the now-common setup of a 'primary' worker that one can introduce the 'lesser' workers to each other directly. That's also conceptually more robust that picking a partner by type only only from some 'pool' (all the workers in a runcontrol), scales better (it e.g. is imaginable that a RunControl needs more than one PortGatherer in complex setups where more than one device is involved) saves a few cycles, and even removes the need for workers to be qobject_cast-able. Change-Id: Ib3d8c942c893d6c198d9813cce7df28ba3260ce8 Reviewed-by:
Christian Kandeler <christian.kandeler@qt.io> Reviewed-by:
hjk <hjk@qt.io>
-
Christian Stenger authored
This also fixes accessing 'this' when located inside a different thread. Task-number: QTCREATORBUG-18466 Change-Id: Ib90cc23c65c033a234d3f7cf9b1ba76abff719e2 Reviewed-by:
hjk <hjk@qt.io>
-
Christian Kandeler authored
To HEAD of 1.9 branch. Change-Id: I9318013728c25e18f2dbf60aa408e0fe75b095d2 Reviewed-by:
Joerg Bornemann <joerg.bornemann@qt.io>
-
Orgad Shaneh authored
Looks like this was done for debugging, but the user is not supposed to be aware of internal implementation. Change-Id: If24a2b0f85a04c2e88c5ef5fd66d34a606d46712 Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
hjk authored
It turns out that one "Connection" per RunControl doesn't map well to the uses we have. Instead, RunWorkers need to know individually how to connect to the place where they can work, but they are already specific enough to be able to use a standard class (like QUrl) as their way to specify the needed entry point. In theory one could see a RunControl's connection as an aggregation of its workers connection bits, but that does not really seem to be needed in code. As consequence, replace UrlConnection by a plain QUrl, and also the HostName connection by a QUrl with hostName set. Change-Id: I40c97e37779314ac0a77041e864a18eadb78f987 Reviewed-by:
Vikas Pachdha <vikas.pachdha@qt.io>
-
Orgad Shaneh authored
* Aborting a core dump debugging is a valid state * Do not try to abort more than once (happens on shutdown) Change-Id: I075409b3fa1231420fcd72706b18eaa0383fd4f2 Reviewed-by:
hjk <hjk@qt.io>
-
- 06 Jul, 2017 11 commits
-
-
Eike Ziller authored
The logic to not hide the popup if it got active was lost in e133ee89 Change-Id: Ic3af147194f7ad18d510e827db1d5804e48e1f97 Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Eike Ziller authored
The item delegate's sizeHint will only be correct after there are actual items to show. So behave similar to uniformRowHeights by waiting for the first data to arrive and then setting the size of the completion list and the popup. Task-number: QTCREATORBUG-18457 Change-Id: I7aa18988e07e21c2ec6587e83fb0de2dce6552ef Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Christian Stenger authored
Slipped in with cc8bff67. Change-Id: I02968395cf3ac5671326d874e5c58fef944225a9 Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Marco Bubke authored
We do only support version 3.9 currently. Change-Id: I3ecb2dbb56a2990e401ce6cf485f8e3a910fede6 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@qt.io>
-
Nikolai Kosjar authored
...due to indirect recursion: ... CPlusPlus::ClassOrNamespace::lookupType LookupContext.cpp 833 0x7fffd6c954cc CPlusPlus::ClassOrNamespace::nestedType LookupContext.cpp 1364 0x7fffd6c94bc6 CPlusPlus::ClassOrNamespace::lookupType_helper LookupContext.cpp 955 0x7fffd6c9517f CPlusPlus::ClassOrNamespace::lookupType_helper LookupContext.cpp 983 0x7fffd6c952ad CPlusPlus::ClassOrNamespace::lookupType LookupContext.cpp 833 0x7fffd6c954cc CPlusPlus::ClassOrNamespace::nestedType LookupContext.cpp 1364 0x7fffd6c94bc6 CPlusPlus::ClassOrNamespace::lookupType_helper LookupContext.cpp 955 0x7fffd6c9517f CPlusPlus::ClassOrNamespace::lookupType_helper LookupContext.cpp 983 0x7fffd6c952ad CPlusPlus::ClassOrNamespace::lookupType LookupContext.cpp 833 0x7fffd6c954cc ... ClassOrNamespace::lookupType(const Name *) already guards with a list of entries already processed, but some calls deeper the list is not passed on and lookupType() starts again with an empty list. Handle that case, too. Task-number: QTCREATORBUG-18499 Change-Id: Iab8978f6ac1d0aea16f49b3547415f43de887b07 Reviewed-by:
Marco Bubke <marco.bubke@qt.io>
-
Thomas Hartmann authored
Change-Id: I784584806819eb667cb596e1d46ffe9b393087fd Reviewed-by:
Alessandro Portale <alessandro.portale@qt.io>
-
Eike Ziller authored
Change-Id: Idaea2197d8666a251cef46fa9032494e91cc29a1 Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Eike Ziller authored
The change to using the search result item delegate made the items squeeze pretty much together. Explicitly add some spacing again. Task-number: QTCREATORBUG-18457 Change-Id: If056b94e5a1629be574a0d864361dc72e356544a Reviewed-by:
David Schulz <david.schulz@qt.io>
-
Thomas Hartmann authored
Everyone agreed that the rubberband selection should be inclusive. There is no need to require that all items are sub children of the same item. This seems confusing. Change-Id: I5fffbc72e0ef15a82fc9f0ab589c865581359775 Reviewed-by:
Tim Jenssen <tim.jenssen@qt.io>
-
Thomas Hartmann authored
InvertSelection was not properly implemented. Change-Id: I101105b33f8e2b9ed7b62a06d6330cbbfd87879a Reviewed-by:
Tim Jenssen <tim.jenssen@qt.io>
-
Orgad Shaneh authored
It causes a crash when shutting down while the debugger is running. Change-Id: I2f8e7dd957b5337e5c6891263d8e73bb37fff681 Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
-