Introduced with 25f2f8e1



Change-Id: Ic84fa409bea0aec7db4dce66d468f80c845a3673
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Similar to 184695be



Change-Id: Ifd78300fc5c8eb1d53601b50a4a4fa43d5b8afa4
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: I71527dc9da9e9d0e06e7e180734ef577dbdbb195
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

It saves 2 copies. Similar to 184695be



Change-Id: I2a70e4a570af54fd0be5bb6bc198cff4f5e91317
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

And remove code for handling @strings/app_name. The default template
hasn't used that for a while and it's pretty hard to properly support
that with both a activity and app setting.

Change-Id: I394b78e0a5380232efbc52e1c71d49d9696a9b00
Task-number: QTCREATORBUG-13958
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

saves 7 copies. Similar to 184695be



Change-Id: Iebe5e14f07d77bc98fd5b5bff7e315ccd8c1fab4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I35ba4cc7f7052699c3006545514c866be3cb5fdd

For recently introduced code.

Change-Id: Ie6e5333990526bd912e773493241975cded009d2
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

The height of a model is 0 if the model is empty. Thus, when clearing
we have to emit heightChanged().

Change-Id: I6f05c2a32cff648d6aa8e623e17aebe9ae4fcb5c
Task-number: QTCREATORBUG-14507
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: I381c43fb85b552fef3a07910954482a45cbff5c0
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Do not use the object pool to hold potential wizards. Register
FactoryCreator functions with IWizardFactory instead and use
those to create the wizards when necessary.

This saves us a couple of cycles during startup since we can now
delay construction of all wizards and it makes us more flexible
wrt. managing the lifecycle of the wizard factories.

Change-Id: I95d6a6dfcdf0fd995e1934a9fefcd96c6a676753
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

We do not want to encourage the use of custom wizards, so
remove the examples. The Json wizard has already enough
real-world examples IMHO.

Change-Id: Ic755e01ce0430b90ad4d5ea3496c11ce162249bf
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

and deinline dtor. It saves 2 copies

cd /io/qt/qt-creator-build/lib/qtcreator/plugins &&
nm -C ./*.so | grep vtable | grep -v " U " | cut -c 18- | sort | uniq -c
| grep -v " 1 "

      3 d vtable for ProjectExplorer::NodesVisitor
      5 d vtable for QFutureInterface<bool>
      2 d vtable for QFutureInterface<Core::LocatorFilterEntry>
      2 d vtable for QFutureInterface<TextEditor::HighlightingResult>
     18 d vtable for QFutureInterface<void>
      2 d vtable for QFutureWatcher<TextEditor::HighlightingResult>
      5 d vtable for QFutureWatcher<void>
      2 d vtable for QmlDesigner::(anonymous namespace)::TreeViewStyle
     14 d vtable for QRunnable
      3 d vtable for QtConcurrent::RunFunctionTaskBase<void>
      3 d vtable for QtConcurrent::RunFunctionTask<void>
      2 d vtable for RemoteLinux::Internal::(anonymous
namespace)::ConfigWidget
      2 d vtable for Utils::View<QListView>
     11 d vtable for Utils::View<QTreeView>
      2 V vtable for Core::BaseFileFilter::Iterator
      3 V vtable for CPlusPlus::SymbolVisitor
      3 V vtable for CppTools::CppRefactoringChanges
      5 V vtable for ProjectExplorer::BuildInfo
      3 V vtable for ProjectExplorer::JsonWizardPageFactory
      2 V vtable for QmlJS::SimpleAbstractStreamReader
      2 V vtable for QmlJSTools::QmlJSRefactoringChanges
      8 V vtable for VcsBase::VcsBaseOptionsPage

similar to QTBUG-45582

Change-Id: I75f7f5cf5522d1d093b52f4f0ee8cccdbca45cae
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

These images are displayed above the description in the new file/project dialog.

Change-Id: Ib218e62a40891ebc2c675c49b32b3789c42d740d
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Change-Id: I4ea5883e64bcae405ae00200616a1f915bdeffff
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>

Change-Id: I82b136d37e6b3b9c9e74aafc105fb0291c605b55
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Map existing class wizards to file wizards. The separation has never
been clean anyway. Now "file" wizards create one or more files,
"project" wizards create a complete project (something that can be
opened as a project in Qt Creator).

Change-Id: I0562f26019b54a59d46814a13a0b2fa8995c3e0f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The timeout was "only" 4s, but apparently pretty much every
android tool randomly takes longer than 4s.

Increasing this timeout won't affect anyone for whom the
android tool returns in 1s, but makes it work for anyone
where the checking takes longer.

This waiting though is done in the main thread, which is pretty
bad. Moving it to a background thread isn't easy though.

Change-Id: I135b1d1ee9634005d5eb6038a46d66b6a8e97fca
Task-number: QTCREATORBUG-13175
Reviewed-by: BogDan Vatra <bogdan@kde.org>

On arm64 devices /system/bin/app_process is a symlink to /system/bin/
app_process64, the problem is that we are pulling it also for 32bit
apps, which will make the debugging impossible because arm-linux-
androideabi-gdb 32bit can't mix the architectures.

Change-Id: I37e071456fb89051b0433ee2e7635085257616ea
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Introduced with 66f60362



Change-Id: Ifd114e7360bd5ee729d29a0f03116458d56c2afa
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I707f348965cb66085e9e9b7b47613c65974a5f55
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>

It's not defined anyway. Use ProjectExplorer_TaskWarn_TextMarkColor as
default text mark color.

Change-Id: I1c7f76f0a6dc83338798cdd7450e1468e8ce39a7
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Replace existing wizards with new ones of the same id.

Change-Id: Ia17e6a4df5e7c8b647eccbe3bfb13e1c5b2d09e0
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

The space character after the line number was removed from
the compiler messages.

Change-Id: Ia249a6d4416744c67aada2eb2c5c26cf87bd7ef7
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: I6e8b3cbedb78df08066f87d4aa9922145cfa151c
Task-number: QTCREATORBUG-14496
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Reviewed-by: Marco Benelli <marco.benelli@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Change-Id: Iba2995ff3522455450ef52a72209da0dfc648d6e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

The format of the compiler warnings changed:
c:\foo.cpp(395) : warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning)
c:\foo.cpp(395): warning C4800: 'BOOL' : forcing value to bool 'true' or 'false' (performance warning)

Change-Id: Iaa04d8fedbb0a3da2802be1c860d54fefb7bfe5d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I2df85493d156a214b2e7650acc77efe099d03277
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

There's no reason to keep the Template after it is instantiated.

Change-Id: I91210ae11b3420bb038168fe951b52d28ccc132e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

The enclosingScope of a cloned nested class is not the
original class but the cloned parent.

Use-case:
template <typename T>
struct Temp
{
    struct Nested
    {
        static T f();
        typedef decltype(f()) type;
    };
};

struct Foo { int bar; };

void fun()
{
    Temp<Foo>::Nested::type s;
    s.bar; // bar not highlighted
}

Task-number: QTCREATORBUG-14483
Change-Id: I3e15399a78a7492f740db8d0c7d5c84adf77d1d0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Avoid double map lookup

Change-Id: I5fe6b4a13829275f5a68f794cb820b488f4a5c8c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Remove one unused function declaration and adjust one comment
to reality.

Change-Id: I0ba88dfa89d1fe312cef97a659715c664f4650bc
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

It triggered another warning for comparing signed and unsigned.

Cast to int instead.

This reverts commit 5fd3fa91

.

Change-Id: I2d239c42da7ba5e1d1e3bc9e2e737eac6e438d9c
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: I79a718f45835a709daa37dd785ed718c3743d77e
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Change-Id: I61b2f7a11bb516b4d14226cfdbbc581243659e4f
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Incomplete rename done

Change-Id: Ia792d15c3e0242f3e17479ff7bfbd9e7efa3a5ae
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Change-Id: I94c8bd554e9e5ee157fd2bc80d3889558d08a8f0
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Task-number: QTCREATORBUG-14461
Change-Id: I6e63643754197e300dbc90c9208458e5d69beaf6
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

If the style doesn't offer any icons that have at least 32 pixels

Change-Id: I840d73a0b4bdee695bb68df1c3973ee419db012e
Task-number: QTCREATORBUG-12832
Reviewed-by: Robert Loehning <robert.loehning@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I9e1e9ce9a61d7d06a9869f309ed3089d843137a2
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>