GitLab

Change-Id: I06bac5443af41a27c2641199948705c45e8a4586
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

With EngineControl multiple QQuickViews can be profiled in one
profiler if they're all running in the same thread. As the QML
engines are never run in parallel then this results in useful
data.

Change-Id: I83a34fb81fd466c5cac838b096c1b1f322ded882
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Add make std::string usable as "compact" key.

Change-Id: Idbfcf9d299e2dde392025166a20c3d0ab60239a6
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Looks like they are zombies scince
b419403b



Change-Id: I5fe0c728dcce1931e543e15f04ae24e0c65db61a
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I4b216e9e228668c7e01bc31c30334397cb07b15e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Remove the '.' as the VariableManager will append text starting with ':'
to that textFix strings.

Change-Id: I490319fac964ea8fd8078dff90ec81c9bdef8d09
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Iaf7a3d69d920f8096763e2d8033df2d6371683a7
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I6f8685319f0afe2a326a66e36a1e6b671e317614
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I0a66d7a2a77ed0b2c7c87005887a7847bb9ee5f5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ia1e43cb44639e332ee4f9100c7ce3029e9485198
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Reported as a dead store by the clang static analyzer.

Change-Id: Id5eb72ea4698a17486b8a05d88ee66f3fd89bcfc
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Pointed out by the clang static analyzer.

Change-Id: I2d73d4c9ef2511c5697a4e4da89b61efb1149a3f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Pointed out by the clang static analyzer.

Change-Id: I69ab89e651cbcb13606d5d93a05f629172cbd9e0
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

Use "%{}" to put a literal "%" into the output of the macro expander.
E.g. "%{}{Macro}" will be turned into "%{Macro}"

Change-Id: I592789e5cd8f2d52df424db679baf7ba04723202
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

Change-Id: Ia531698eacab0f0c4f20f1bc1c54d59e7c2df010
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The dead store is not harmfull, but add noise when checking for dead
stores that are due to logic errors.

Change-Id: I244c57e3227d075cb625252e8246c22768bc275c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

When the QTC_CHECK would fail, a nullptr deref would happen directly
after the check.

The dead stores are not harmfull, but add noise when checking for dead
stores that are due to logic errors.

Change-Id: I83db386e3f0de583469e1576e28955c25930b3b1
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ibc138bcfdef4b6a5dd154e819d568398ecace982
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>

This fixes blocking of these notifications.

Change-Id: I49a1efd4506fe66b1f78e9489360cfb68edd8fab
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Change-Id: I286f6bfbb647111b6ae9ad90c5171499382b2e71
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I17d08fa3cf018f036f88f6be027e4c3740e90f74
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Such build system files must be filtered out, as they do not appear on
the right-hand side of "files" properties and have completely different
remove semantics.

Change-Id: I3963aa853003f4d674392434529dab19749af25b
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

createConfigWidget() calls KitManagerConfigWidget() calls discard(),
which results in a signal unmanagedKitUpdated. In response to that
signal, the KitModel iterates over all kit nodes. The node we are
currently creating doesn't have a widget yet, and thus leads to a crash.

Prevent that by adding the node only after the widget has been fully set
up.

Change-Id: I5b14be1c7363e480e3dd938853ff06c595993fc2
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

The dead store is not harmfull, but add noise when checking for dead
stores that are due to logic errors.

Change-Id: I18084c357696311b6556c7bc60832a72b3318e92
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I6b405b8eb9cc461b6081e3711be54c8d580e02b6
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I701d01a935bdbb65808de65cf2a994a5d68cf1d4
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: I111b4620effc45f26f40880875a70d606c924f69
Reviewed-by: hjk <hjk121@nokiamail.com>

The dead stores are not harmfull, but add noise when checking for dead
stores that are due to logic errors.

Change-Id: I8bf61c51207f0339911bc07fcfbc06f8066521e5
Reviewed-by: hjk <hjk121@nokiamail.com>

The divide by zero is intentional, so suppress the not-quite-so-false
positive from appearing.

Change-Id: Iba96682e5b584a7e4a8e5895af0ccfc68b73cc71
Reviewed-by: hjk <hjk121@nokiamail.com>

This reverts commit c228b36c

.

There are multiple issues with the reverted patch:
  * Infinite loop due to indirect recursion e.g. when opening projectmodels.cpp
  * Crash when executing CppTools tests on Windows (no infinite loop)

Change-Id: I38f02132ca57d3d32085db6146d0df7d620d7618
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

The ast parameter cannot be null, because the only use checks for it not
to be null. However, if it would ever be re-used somewhere else, the
logic is plain wrong. Clarification by an assert makes it clear what the
intent is.

Pointed out by the clang static analyzer.

Change-Id: I2c8cba5e5847fc1f92c10021109c55ff8ccd58c4
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Change-Id: I46d351e517d575bff158a4c9e785645462023ae9
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Change-Id: I32f2ee037b372c54ae41ea1b3626365e4f201118
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

“Move Component to Separate File” and “Wrap Component in Loader” did
work only for UiObjectDefinitions, extended them to UiObjectBindings.

Task-number: QTCREATORBUG-12904
Change-Id: I5216110c1edfc6e4536f83eba39e74919c918d50
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>

Especially when this gets more complicated with additional fancy windows
mime types and custom mime type for opening a file at a specific
location (dropping from Outline, Type Hierarchy et al), we should not
create that complex mime data everywhere by hand.

Change-Id: I37f6ceb287b0cd055501fdd033ac29816434a020
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I0ca381dca2f7a50e3638f10c77db9b6621fb32c4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

When the check would fail, it would result in a nullptr deref 3 lines
down. As this is a constructor, doing a QTC_ASSERT(..., return) would
leave the object partially initialized, with some fields containing
random garbage.

Change-Id: I823d52d43d90eaf06cb7d7cd64fbee17e5fc889e
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Iaa9182579afa19c9c8f184f964eeace3bc7b7906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Was broken in 5969c01f

.

Change-Id: I5e6e20ae8570e7c49cb87f429f6d65993fe4618e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Setting QTC_HELPVIEWER_BACKEND to "native" when the native backend is
not compiled in, would result in a nullptr deref.

Change-Id: I5618650e0c4ae1c986a54a46232e8f782e43f350
Reviewed-by: Eike Ziller <eike.ziller@digia.com>