1. 24 Apr, 2015 1 commit
    • Nikolai Kosjar's avatar
      CppTools: Remove separate indexing revision · d4bb5033
      Nikolai Kosjar authored
      
      
      For indexing we used a custom revision that was updated on each
      modelManager BuiltinIndexingSupport::refreshSourceFiles() call. This
      could lead to rejection of updated documents triggered by refactoring
      actions, like for the following case:
      
       1. Open a project containing a.h and a.cpp
       2. Open a.cpp, insert some new lines, save and close the document
       3. Open a.h and rename a function that is defined in a.cpp
          --> The refactoring action modifies a.h and a.cpp, so re-indexing
              of those is triggered. Since a.cpp has already a higher revision
              (step 2) than the updated document, the updated document is
              discarded. As a consequence find usages and follow symbol fails
              for the renamed function.
      
      Now the document call back provided to CppSourceProcessor is responsible
      for updating the document revision based on the latest revision in the
      global snapshot.
      
      Change-Id: I4dfa0a4d34991655acfa749109f00c47b0fbfdbe
      Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@theqtcompany.com>
      Reviewed-by: default avatarEike Ziller <eike.ziller@theqtcompany.com>
      d4bb5033
  2. 13 Apr, 2015 1 commit
  3. 16 Jan, 2015 1 commit
  4. 15 Dec, 2014 1 commit
  5. 03 Dec, 2014 1 commit
    • Nikolai Kosjar's avatar
      CppTools: Update document on activation · cb0d1369
      Nikolai Kosjar authored
      ...if the project was updated in the meanwhile.
      
      If a project is updated mark invisible editor documents dirty and update
      them if they get focus.
      
      This also fixes document highlighting when restoring a session for
      documents that the user "switched away" before the project info is
      pushed to CppModelManager.
      
      This completes
      
          CppTools: Update visible documents on project update
          commit c2eb91e0
      
      
      
      which only takes care of visible documents.
      
      Task-number: QTCREATORBUG-13270
      Change-Id: Id445e7f509deac5d03194aecc54ce4629b7926ce
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@theqtcompany.com>
      cb0d1369
  6. 09 Oct, 2014 1 commit
  7. 02 Oct, 2014 1 commit
  8. 19 Sep, 2014 1 commit
  9. 24 Jul, 2014 1 commit
    • Nikolai Kosjar's avatar
      CppTools: Auto-include pre-compiled headers · 6a9ae7e2
      Nikolai Kosjar authored
      
      
      So far the pre-compiled headers were processed (thus defines from those
      headers were visible), but the actual includes for the documents were
      not added, which is necessary for lookup/completion.
      
      Note that this will be only done if pre-compiled headers are not ignored
      (Options > C++ > Code Model > [] Ignore pre-compiled headers).
      
      Change-Id: I54a8e6b00597af164d958e3e9f2a1075ea187788
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      6a9ae7e2
  10. 15 Jul, 2014 1 commit
  11. 04 Jul, 2014 1 commit
  12. 10 Jun, 2014 2 commits
    • Nikolai Kosjar's avatar
      CppTools: Unexport some internal classes. · 11845cd3
      Nikolai Kosjar authored
      
      
      Unexports CppModelManager, CppSourceProcessor and CppToolsPlugin.
      
      Now only some constructor signatures mention "Internal::" in the
      exported symbols:
      
      % nm --extern-only --demangle ./lib/qtcreator/plugins/libCppTools.so | grep "Internal::"
      CppTools::CppClassesFilter::CppClassesFilter(CppTools::Internal::CppLocatorData*)
      CppTools::CppClassesFilter::CppClassesFilter(CppTools::Internal::CppLocatorData*)
      CppTools::CppEditorSupport::CppEditorSupport(CppTools::Internal::CppModelManager*, TextEditor::BaseTextEditor*)
      CppTools::CppEditorSupport::CppEditorSupport(CppTools::Internal::CppModelManager*, TextEditor::BaseTextEditor*)
      
      Change-Id: I167c21a6dc03cf02230c95fde66cf404e40df36f
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      11845cd3
    • Nikolai Kosjar's avatar
      Cpp{Editor,Tools}: Move tests for IncludeGroups to CppTools · 9921960a
      Nikolai Kosjar authored
      
      
      They belong there. This will also kill the CppSourceProcessor dependency
      from CppEditor.
      
      Change-Id: Ic2ae6b0c6f0913d913636be61df194846985d1ce
      Reviewed-by: default avatarErik Verbruggen <erik.verbruggen@digia.com>
      9921960a
  13. 04 Jun, 2014 1 commit
  14. 03 Jun, 2014 1 commit
  15. 28 May, 2014 1 commit
  16. 10 Mar, 2014 1 commit
  17. 24 Feb, 2014 1 commit
  18. 20 Feb, 2014 1 commit
  19. 21 Jan, 2014 3 commits
  20. 08 Jan, 2014 1 commit
  21. 23 Dec, 2013 1 commit
    • Orgad Shaneh's avatar
      CppTools: Make completion tests data-driven · 0909c029
      Orgad Shaneh authored
      
      
      Mostly done using the following Ruby script:
      
      Fname = 'src/plugins/cpptools/cppcompletion_test.cpp'
      s = File.read(Fname)
      mod = s.gsub(/(?<declaration>void CppToolsPlugin::test_(?<test_name>[^(]+)\(\)\n\{)(?<body>.*?\n)\}/m) { |func|
        match = $~
        declaration = match['declaration']
        body = match['body']
        test_name = match['test_name'].sub('_data', '')
        final = body.gsub(/(?:completions.clear\(\);\s+)?(?: +)[^\n]* =\n(?<code>.*?);\s*(?<completions>(?:completions.append\(QLatin1String\("[^"]*"\)\);\s*)*)QTest::newRow\("case: (?<name>.+?)"\)\s*<< code << _\("(?<prefix>[^"]+)"\) << completions;/m) {
          m = $~
          res = "    QTest::newRow(\"#{test_name}: #{m['name']}\") << _(\n#{m['code'].rstrip}\n        ) << _(\"#{m['prefix']}\") << (QStringList()"
          m['completions'].scan(/completions.append\((.+)\);/) { |comp|
            res << "\n            << #{comp[0]}"
          }
          res + ');'
        }.gsub(/(?: +)[^\n]* =\n(?<code>.*?);\n\s*CompletionTestCase test\(.+?, "(?<prefix>.+?)"\);\s*QStringList expected;\s*(?<completions>(?:expected.append\(QLatin1String\("[^"]*"\)\);\s*)*)const QStringList completions = test.getCompletions\(\);\s*QCOMPARE\(completions, expected\);/m) {
          m = $~
          res = "    QTest::newRow(\"#{test_name}\") << _(\n#{m['code'].rstrip}\n        ) << _(\"#{m['prefix']}\") << (QStringList()"
          m['completions'].scan(/expected.append\((.+)\);/) { |comp|
            res << "\n            << #{comp[0]}"
          }
          res + ');'
        }.gsub(/(?: +)[^\n]* =\n(?<code>.*?);\n\s*CompletionTestCase test\(.+?(?:, (?<prefix>".+?"))?\);\s*(?:const )?QStringList completions = test.getCompletions\(\);\s*QCOMPARE\(completions.size\(\), \d+\);(?<completions>(?:\s*QVERIFY\(completions.contains\([^\n]+\);)*)\n/m) { |mm|
          m = $~
          res = "    QTest::newRow(\"#{test_name}\") << _(\n#{m['code'].rstrip}\n        ) << _(#{m['prefix']}) << (QStringList()"
          m['completions'].scan(/QVERIFY\(completions.contains\((.+?)\)\);/) { |comp|
            res << "\n            << #{comp[0]}"
          }
          res + ");\n"
        }.gsub(/(?: +)[^\n]* =\n(?<code>.*?);\n\s*CompletionTestCase test\(.+?(?:, (?<prefix>".+?"))?\);\s*bool replaceAccessOperator = false;\s*const QStringList completions = test.getCompletions\(\&replaceAccessOperator\);\s*QCOMPARE\(completions.size\(\), \d+\);(?<completions>(?:\s*QVERIFY\(completions.contains\([^\n]+\);)*)\s*QVERIFY\((?<replace>!?)[^)]*\);\n/m) { |mm|
          m = $~
          res = "    QTest::newRow(\"#{test_name}\") << _(\n#{m['code'].rstrip}\n        ) << _(#{m['prefix']}) << (QStringList()"
          m['completions'].scan(/QVERIFY\(completions.contains\((.+?)\)\);/) { |comp|
            res << "\n            << #{comp[0]}"
          }
          res + ")\n        << #{m['replace'].empty?};\n"
        }
        if final == body or final['QTest::addColumn']
          declaration + final + "}"
        else
          final
        end
      }.gsub(/QTest::newRow\("([^"]+)"/) { |m|
        name = $1
        if name.size > 73
          space = name[0..73].rindex(/[ _]/)
          "QTest::newRow(\"#{name[0..space]}\"\n                  \"#{name[space+1..-1]}\""
        else
          m
        end
      }.gsub(/\s+QTest::newRow/, "\n\n    QTest::newRow")
      if mod != s
          File.open(Fname, 'wt').write(mod)
      end
      
      Change-Id: Id6bfb03cdf31ac27b36028fcdc861c340a5398f4
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      0909c029
  22. 11 Dec, 2013 1 commit
  23. 22 Nov, 2013 1 commit
  24. 12 Nov, 2013 1 commit
  25. 18 Oct, 2013 1 commit
  26. 17 Oct, 2013 1 commit
    • Przemyslaw Gorszkowski's avatar
      C++: fix endless loop during template instantiation · 5be56c07
      Przemyslaw Gorszkowski authored
      
      
      This is the first phase of fixing bug QTCREATORBUG-10320.
      This change resolves typedefs of template parameters(and resolves
      problem with endless loop).
      
      The next step will be matching appropriate template specialization
      (this is needed to solve problem with missing code completion).
      
      Missing matching: template specialization with the same parameters,
      e.g.:
      template <class T1, class T2, class T3>
      class T
      {
      };
      
      template <class T1, class T2>
      class T<T1, T2, T2>
      {
      };
      
      Task-number: QTCREATORBUG-10320
      Change-Id: Icb6b539c021b2a67a66db9011a2e627f7d96526b
      Reviewed-by: default avatarPrzemyslaw Gorszkowski <pgorszkowski@gmail.com>
      Reviewed-by: default avatarNikolai Kosjar <nikolai.kosjar@digia.com>
      5be56c07
  27. 01 Oct, 2013 3 commits
  28. 13 Sep, 2013 1 commit
  29. 03 Sep, 2013 2 commits
  30. 22 Aug, 2013 1 commit
  31. 20 Aug, 2013 1 commit
  32. 19 Aug, 2013 1 commit
  33. 13 Aug, 2013 1 commit
    • Nikolai Kosjar's avatar
      CppTools: Rework handling of ProjectInfo changes · 8ea14767
      Nikolai Kosjar authored
      
      
      (a) The code model manager figures out by itself which files were added
          or removed from the project.
      
          If this was done successfully, check also the timestamp of the
          common files and reindex if necessary.
      
      (b) A full reindexing is only triggered if the project configuration
          changes (defines, includes, framework paths).
      
      (c) If project files were removed, the garbage collector is called.
      
      Task-number: QTCREATORBUG-9730
      Change-Id: Ib855614b070880576233a3525813617c967a72f3
      Reviewed-by: default avatarFawzi Mohamed <fawzi.mohamed@digia.com>
      8ea14767
  34. 08 Aug, 2013 1 commit