Change-Id: I21f26bd40b78d760e72a6cc135a06a368c31eaf2
Reviewed-by: hjk <hjk@theqtcompany.com>

The code sharing in the base was along a somewhat unfortunate
boundary. Moving it into the only user also removes some of
the wrong local/remote separation.

Change-Id: I0be9636ea448d123f9f5105a52d56f47ff7871c3
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>

Missed in 2fc604e6

Change-Id: I520cff39f806213b92f5f49bd8d22153ecdfe62b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Change-Id: Ie97904b6a896dd8b8e327fe3d00611d91a974dd2
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Init all class member pointers to NULL.
This fixes possible crash on exit when dependent
plugin was not loaded (e.g. TextEditor was missing).
In this case plugin's constructor gets called,
initialize() method is _not_ called
and destructor gets called -> crash.

Properly delete dependent plugins on
a plugin which failed to initialize properly.

Fix labels of deleted plugins inside an error dialog
after pressing "Error Details" from "Installed Plugins"
dialog.

Change-Id: Iddc029a0f07dcba2501d734d142fb0e69e9383d3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Ia33e7265e103aed04d18b23ae8d02d4e403aae8b
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

Change-Id: I0c002895a6585fac79c8aa1d773b68c4a1540916
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I4231d0b98fef2f2f3f1ebdf74c7dfc48ec879e83
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Remove/simplify constructors accordingly.

Change-Id: I27ac0281a89dfadefb1f7837d99ce185745b7aae
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Iade2bcb1aa18053954df9063ca08d18d032fdfd1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

Task-number: QTCREATORBUG-14216
Change-Id: I7e9e760f7ba9ef6022e76f1600e473a5f54c9893
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Task-number: QTCREATORBUG-14487
Change-Id: Ic858b131abb2802cb7bfedf58f64c644ea2085e5
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Do not use the required/preferred features from the wizard in the
kits page. The wizard's features are used to decide which wizards
will be shown (together with the enabled key). The kits page has
a separate set of features that are used to decide on the Kits
shown.

Keep these settings separate, as they are different things.

If nothing is set at the Kits page, then the wizard's values
will be copied. This is to stay compatible with existing
JSON wizards.

Change-Id: I2f8e3ccc46ce92f5be89aecaf52e5a81e4b29e83
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

We will add some more settings.

Change-Id: Ib0282a9e7a9aa4ec316db7aded804e5483e48e48
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

This is more fine-grained than the "Qt4" or "Qt5" we used to support
and will allow for wizards to specify things like "Make sure we get
a Qt version > 5.x" for the kit selection page.

That page is provided by the ProjectExplorer, so we can not access
the Qt version there, so Features seem the only possible way to go.

Change-Id: I0f4b3a0b5be91fb331924a560414e8f73bccca41
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: Id13cbdf2f7047366e543c91fbe7c21a9c4759e56

This is what it is on the top level. The change makes it obvious
that in the valgrind(-derived) plugins the value is later wrongly
used to make a decision on whether to run the valgrind process
locally or remotely. But that's isolated in valgrind now and
can be fixed there.

Change-Id: I6fa5e669dec1f9e2cdebe42a1591d15144082a21
Reviewed-by: Anton Kreuzkamp <anton.kreuzkamp@kdab.com>
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>

Change-Id: I101fe0abb98ed2d08970b5cf0f9de803a3137e8c
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Change-Id: I4915976a5a5e1843fd35934d167875255401fdb7
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

This can apparently get triggered with qbs projects.

Task-number: QTCREATORBUG-14493
Change-Id: Id645fbad1a0b9fdff1d1840f8ba5821b3be56b7d
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

We don't support traces yet.

Change-Id: I4ea4db1e52111a2f7b908b925e94f63af9ce3a88
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

This was it also gets triggered when expanding tooltips.

Change-Id: I90ad39e9e82abdcd40e663b4ba4998205563009b
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

There are now several possible orders of events between sending a 'kill'
and receiving something that indicated a properly shut down inferior.
Coordinating the InferiorExited state during engine ramp down is not
worthwhile as that state had only a forced transition to InferiorShutdownOk
anyway. For the user (and user code), only the fact that ramp down is
finished is interesting.

Change-Id: Ic22131d5a1066dc62bd069f532c28b773f231088
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I5e7a1c3be4fe7fab848c98abdf52d3b9af318047
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I69f1b6d0d27e9330ff23de0b9d5a09ef02f353ac
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I324e88c0d295114390c1fac2745c0d2d47637ece
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Change-Id: I13e8a458634110456375956d4d4da7239c86957f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

Directly destruct the plugin after failed initialization, instead of
letting the plugin loader clean up automatically just before application
destruction (which would be after all other plugins are already
destructed).

Change-Id: Ic459a652fdb99c3e3ee1a7561334ba7075c9c666
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Change-Id: I943e13b92bdaa2ee1e6ead81788da45b40926f60
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>

Looks like it's a kind of rule in QtCreator code.

Change-Id: I92fb60055273d66d6e459245836df5b90d7a3cc6
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>

Added latest version of QtQuick and Controls.

Task-number: QTCREATORBUG-14563
Change-Id: I0cc412c28cd7ceb507f5ce222d8dcc3a05c23e26
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

Introduced with 2b19081c

Change-Id: I817ec48b9098f46ca703a6075d4657f0b7eb9948
Reviewed-by: hjk <hjk@theqtcompany.com>

Special handling of the case in which the current token is
Token::RightBrace. This works in every case *except* for nested braces
without separator between them.

Change-Id: Ief625086c4d33ba77b36b1181e78cad124feb7a9
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>

Change-Id: I63fc40b12e29204d9ecd4ed3fd33e7ad3171918d
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I19859300c8c070d6088010199d0271f2feac20cc
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I716e4bd6325f0d00b1fa73ea4a76f185660c89a0
Reviewed-by: hjk <hjk@theqtcompany.com>

Change-Id: I7902f9d73c5bee200403cc3a1764d265304b8166
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

The menu items should end in "..." if and only
if they open a new window, not a submenu.

Change-Id: Ibf1bbbe8cc4d1ef6384bd76535644a61458530fd
Reviewed-by: hjk <hjk@theqtcompany.com>

...since these might lead to out of memory situations and thus to
crashes. The warning and the file size limited is configurable in
Environment > General.

Task-number: QTCREATORBUG-14390
Change-Id: I868ceca0bee5551ed55f0df990ed334a8b539a7d
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: I999ddeeedbd6bdd7abebf75405d7e9281a1893df
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>