Change-Id: Ia32f968bc672c587925ebc600de06b4387966aee
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Use aggregation instead of inheritance for customization of validation.
Gets rid of a few additional classes.

Change-Id: Iaf8f12026c40a55bfde98b3786100f8ac431d750
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Clicking on error messages is supposed to jump to the editor.
And "Show Output" on the task is supposed to select the error
in the output.

The old code just registered the task for the last line of
output. This broke for every parser that allowed for
error messages that spanned multiple lines. And was obviously
also incorrect for tasks that weren't generated due to
compile output.

Fix both of those issues by giving the IOutputParsers more
control on which lines are linked to a task.

Task-number: QTCREATORBUG-14136
Change-Id: I095922c9875620dabfb7d406f6b152c8a9b25b62
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

And do the necessary API adaptations.

Change-Id: Ic0d48ea12e08c5f2709c2371264ddb7d15c5a539
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>

- All except the one for "qbs build" were incomplete, which is fixed
  now.
- The new implementation is centralized, so maintenance will be simpler.
- The command lines are also completely self-contained now, so they can
  be pasted as-is into a shell with no assumptions about the working
  directory etc.

Change-Id: I2c684141bcdc5c6da0e1af60ce60278fc4dcd088
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>

Change-Id: I711d5fb475ef814a1dc9d2822740e827f3f67125
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

Namely:
    - Expose the new build options in the UI and document them.
    - Remove the default deployment step.

Change-Id: Ic2c9fd93276ab925effe327fac38642d2153f6cc
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>

Detected by valgrind

Change-Id: I32008cb91b5b814f67896ad1efb08f1366a38c76
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Change-Id: I1407b188e72ccb7ca7b47d48f9bb3041df009b8a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

- Setting the QFuture result is not enough, we also need to emit the
  finished() signal.
- Never fail silently; use soft asserts for things that shouldn't happen
  and compile pane output for things that can.

Task-number: QBS-705
Change-Id: I4dad18c2ad573a92f2a0c5aa92b596851c56541e
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

To HEAD of master branch.
Also do the necessary adaptations.

Change-Id: I51830dee41341c9be294caf69fdb0459ed8c8bfe
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: I3c22ef2685d7aa589f5d0ab74d693653a4c32082
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

The functionality it offers is not essential, and it has side-effects
that can lead to bugs if users turn it on for no particular reason.

Change-Id: Iaed660c649de46e7f81d3a1c3311693ed0820d50
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

One line was overlooked in a recent patch that intended to do this.

Change-Id: I1c344c4e25d47b2c4cc89071c2a4e059b451c9fd
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Change-Id: I2f90c8ae7b5e968b9de882833f8661ab540a9232
Reviewed-by: hjk <hjk121@nokiamail.com>

This is a workaround for user mistakes and should not be generally done.
It can result in e.g. redundant relinking.

Change-Id: Ia14854c9d260f5d7a8175d105b9bce896fcdeebf
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Needed by android plugin.

Change-Id: I46543d4889e0e740697439e18e9c1ea0d3fef222
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

This differentiation complicates the code and duplicates checks
already done in qbs.
Just let the library reparse the project; if it turns out that nothing
has to be done, then the operation will be fast.

Change-Id: Ib6406f254e51541c69c948f275fff7877b65b4bd
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Otherwise, if "save before build" is enabled and the user presses Ctrl+B
with unsaved changes to a project file, these would get ignored due to
the delay (and also if the delay were not there, because the file system
watchers trigger later than the "Build" action).
If there are no actual changes to any build file, the overhead caused by
this operation consists of loading (and possibly storing) the build
graph file.

Task-number: QBS-596
Change-Id: I1f837cc0fcdc77a249b423834f4b6711f5c0bc87
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

While it is true that additional information about target
artifacts can appear during a build, this data is already
present in the qbs::Project object and can simply be retrieved.
No reparsing is necessary.
The exception is when reparsing was requested while the build
was going on. In that case, we really need to do it after
the build has finished.

Change-Id: Ief3797782ad0ca5651974d4b5d3d64e1199ca9a5
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.

Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>

On compile errors, file names with e.g. spaces are currently displayed
unquoted, which makes it very inconvenient to copy-paste the compiler
command line displayed in Creator to a shell for closer examination,
editing etc.

Change-Id: I935d8f0b5fa14c7a6f641dcfae659173882194b1
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

The approach used in qbs was broken conceptually after the recent
rewrite of the build logic. Use the new facility.

Change-Id: I219f0ae3ec4ea86304896fc1671dbdc97028a7e4
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

Give the settingspath where the Qt Creator profiles are stored
in the Qbs build- and install steps.

Change-Id: I048525083fc39ca824d866e885d44325306e1030
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

This is necessary since the build may change the the properties of
the build targets (executable name, etc.), so we can not proceed
to run anything without that update.

Change-Id: I9790c529db5e4da61f59e638a05339ada714353c
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

And make sure we re-fetch project data after building, as now qbs can
find new target artifacts while building.

Change-Id: I880689c33893b599686919a90f04281e36c3935e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ib5423fdd064e4546f848c0b640b0ed0514c26d3a
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Change-Id: Ieeaac68cde486458eef067fc1129ba11053759e8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Remove infrastructure to debug/inspect QML applications with Qt 4.7.

Change-Id: I277e9884e009475a29017f502bbe1d069317460f
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The command line equivalent of the respective options often gets too
long for the summary, which means that the end of the string is cut off.
Not only does that look ugly, it also hides information that is not
trivially available otherwise, such as the full path to the install root.
This patch therefore adds a text edit field that is guaranteed to be
able to display the complete command line. This is also consistent
with what the qmake step does.

Change-Id: Ic8d20e484e9cfe4980ea9eff05843fef1012f067
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

For example, C++ source files will be compiled but the build
stops before linking.

Task-number: QBS-283

Change-Id: If0573ea58b9a047980aab0fd8e4828f3d0c315b8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I69a4550b347d24825d19ce9d37cd68de01604c72
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I59fd151a1a485990ca0da7dac4fdc028f915ec6b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I3ce493274b949bf9065909337a8dd57760f1e12f
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

This should fix quite a few issues with e.g. changing and cloning kits.

Change-Id: Ia3278ff1a5eb1ab4c019dca5806ce7fc691e4d8e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

This enables support for e.g. setting CFLAGS, custom defines, etc.

Task-number: QTCREATORBUG-9380
Change-Id: I9d4a560ac5ba8a40c51c15fdf8009c0dba5eeef1
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Id6fcdbdb0c776458eb16c7fc6765046969c2658e
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

They can not work there anyway.

Change-Id: Ic643ae7e35ad599ffb3928530eafb6ec537f3f04
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: Ie707a24d5a081c058f838410c1223201ca4021b3
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Change-Id: Ifbfc128b3785941d0c6ec1789f1c85d2c602738a
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>