GitLab

The current code erroneously reports success in that case.

Change-Id: Ica9768ad029c76cc1103b21c963354806917b149
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Idc471dd4a9734f71e615532a4d70225435452d27
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This reverts commit 894ade6f1e2767a8866642a4ea278659730c26d8

Storing the search text was not thought well through. It causes bad user experience.

Also, the real solution for showing filtered Example sets in the chooser is coming here: https://codereview.qt-project.org/#change,82906



Change-Id: Ibb51bf5c0fa08fdeb8530a19d823ba97a3c167d1
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I1974a6ad63a914d860fa99e55cf0162774ab7b07
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I0bdeadbad547b8351f3e1521c269e882a46edcb9
Reviewed-by: hjk <hjk121@nokiamail.com>

The Android app tutorial is now a more generic mobile app tutorial, so
it was moved to qtquick folder and renamed as creator-mobile-app-tutorial.qdoc.
The page name (HTML) was also changed accordingly.

Change-Id: I749f45a611b32204e5551884238f79d3d3b639fa
Reviewed-by: Sergio Ahumada <sahumada@blackberry.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
(cherry picked from commit 3e0ffdcb

)
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11992

Change-Id: Icb884847633bd421e3dc7bc034d598ef84d33422
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>

Exceptions are likely to be triggered from QML code.
Calling QMessageBox::warning() results in a call to exec() and
exec() returns back into the Qt event loop.

This is dangerous, because QML might have scheduled a deleteLater
which is then executed by exec(). This can crash the application, because
the object is supposed to be "deleted later" and not directly
as a side effect of the signal that was emmited by QML.

Task-number: QTCREATORBUG-11946

Change-Id: Icb884847633bd421d3dc7bc034d598ef84d39429
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

The JavaScript events are integrated into the Timeline and Events
views for apps that use the V4 engine and are built with Qt 5.3.
Updated the Events view screenshot and removed the JavaScript
view screenshot.

Change-Id: Id7e74d91343ff049df580d487e729fdb20c57b0e
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>

Cut-and-past-o in a currently unused code path.

Change-Id: I2c690e5010ade7f3ebbb4a94163d7b44da13c10d
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Task-number: QTCREATORBUG-11983

Change-Id: Id70bd18b1b5494db19adb9928277356c4d4a4688
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This was recently introduced in qtbase/9ce697f2d54be6d94381c72af28dda79cbc027d4

Change-Id: Ied71c5d6a3571342153737ccb62de1424931fd51
Reviewed-by: Mehdi Fekari <mfekari@blackberry.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The #define COMMA trick doesn't work anymore after the
latest Q_DECLARE_METATYPE changes.

Change-Id: I15cfc7387d8e5329b588d6d841cd9c2322270363
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Temporarily set the ErrorMode so that no Windows error message box will
show up in case qmake fails to run (e.g. because of missing .dll's).
The error mode will automatically be inherited by child processes.

This fixes an issue that actually became virulent by another bug fix
( cbb05306

 ).

Task-number: QTCREATORBUG-11962
Change-Id: I5baccf52baee46f3d45b69ea0a13d77e4e113fbd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I663fd2ae419e6bad990223dd5c2c38dd62e2f35c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Convert Q_PID to int using utility function.

Change-Id: Iab18b1b4044e323e14e63f9159a82ad5040117ce
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>

Change-Id: I1c690e5010ade7f3ebbb4a94163d7b44da13c10d
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I7eae2ffbee284720b23c33c353a2a0aaae0a11f5
Reviewed-by: hjk <hjk121@nokiamail.com>

Do check for toolchains not defined in the toolchains.xml file again,
but also allow for toolchain IDs to be ABIs.

This partially reverts a commit from Kai made earlier.

Change-Id: Idad004f0bff655bc136bc43de5837d61a045e311
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11952
Change-Id: I1ef4b5ec7dfcf56cb7c07882b8e091fd84b26121
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Change-Id: I0c690e5010ade7f3ebbb4a94163d7b44da13c10d

Previously Enter Find String (Ctrl+E) required opening Find toolbar at least
once, which is minor but noticeable annoyance.

With this change it always opens Find without focus, so it lines up with Find
Next Selected behavior and also with default Mac behavior. It does also show
yellow highlight for all occurrences without moving cursor.

Task-number: QTCREATORBUG-8993
Change-Id: I1eb8f151d5482895cc49fa5281e7d4e66cf31545
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

QTCREATORBUG-11548 has a quick fix now.

Change-Id: Ia9f38f58bf5d11d5ece4779fd7527fbf8ae65fb1
Reviewed-by: Robert Loehning <robert.loehning@digia.com>

The parent of instantiation of nested class of template class
should be the instantiation of enclosing template class.

Task-number: QTCREATORBUG-11752
Change-Id: I8875c738848b85731f5ea88a60da190b4b0ad18f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11859
Task-number: QTCREATORBUG-11860
Change-Id: I7484b3b88daefbb3c76bb86a9b573e8291072872
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
(cherry picked from commit 5416557a

)
Reviewed-by: Przemyslaw Gorszkowski <pgorszkowski@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: Ib4b51080d878daf96709b77293604eada6555b69
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Task-number: QTCREATORBUG-11952
Change-Id: Ie55b616a1fc54e0cccac5560ec66fb7cc496c8e2
Reviewed-by: Robert Loehning <robert.loehning@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

This avoids the address == -1 problem for generated
values with LLDB.

Change-Id: I13cfc7387d8e5329b588d6d841cd9c2322270363
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Rely on using namespace ProjectExplorer that got introduced in
a previous commit.

Change-Id: I83cfc7387d8e5329b588d6d841cd9c2322270363
Reviewed-by: hjk <hjk121@nokiamail.com>

Change-Id: I6d4df7f00719e5f7c4ee2f41c890348ab9aeaa8a
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

At least for GDB on Windows that's a rather typical situation due to
GDB's "Internal error: pc in read in psymtab, but not in symtab"

Task-number: QTCREATORBUG-11164

Change-Id: If79d586b59e2c1ee37558e8a811091fefc69ac2d
Reviewed-by: Christian Stenger <christian.stenger@digia.com>

Task-number: QTCREATORBUG-11821
Change-Id: Icbf8d6dd84da6ddba7d9c9e540916a804fb962f1
Reviewed-by: Alessandro Portale <alessandro.portale@digia.com>

Change-Id: Id0cc5e4f23a8bd67b9ff1052d7fcabed92c192bd
Reviewed-by: David Schulz <david.schulz@digia.com>

The format has changed in 3.1, but keep the old settings around for a
while, in case that people switch back to 3.0 (or earlier).

Task-number: QTCREATORBUG-11947
Change-Id: I3ad6075c93f614364aae53e8291e937050277140
Reviewed-by: Shawn Rutledge <shawn.rutledge@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11417

Change-Id: If9de1dd40b6f43f020d6d5fef59519b0946b3888
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I6c45d9ebcfa7705ba0913cd1c3ff30798758c473
Reviewed-by: hjk <hjk121@nokiamail.com>

While it is not possible to create a qmake kit without qt, the qt
version might become invalid and be removed.

Change-Id: I99484c86d731ab5a47bff9bb1958158504617004
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I748cb2d6e3b810728e4138f2b0983931233105a5
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>

Using the extra window the ZoomControl keeps makes it impossible to
increase contentWidth to a point where it overflows. The drawback is that
the position on the scrollbar doesn't reflect the real position of the
visible part of the trace anymore if you zoom in to such a depth.

Task-number: QTCREATORBUG-11879
Change-Id: I6649f3c139f76c242a91d60364a28a4a00c9acee
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

This window is dynamically sized so that no integer overflows can occur
when using it in the timeline view instead of the whole trace time.

Task-number: QTCREATORBUG-11879
Change-Id: Id86faaf614b5f833e47ce26bb859b63eb09e7547
Reviewed-by: Kai Koehne <kai.koehne@digia.com>