ProjectExplorer: Do not prepend compiler path to PATH everywhere!
Do not unconditionally prepend the (c++) compiler path to PATH for
all projects using GCC-derived toolchains.
Prepend the compiler path in the Qmake- and GenericBuildConfigurations
instead.
Also change the order: Apply buildconfiguration's addToEnvironment first,
only then apply the kit's addToEnvironment.
This does change a few things:
* CMake and Qbs will now get the normal PATH
* MSVC compilers will have their compiler path prepended to PATH
by the effected BuildConfigurations. This should be harmless,
since that happens before the environment setup script is appended.
Task-number: QTCREATORBUG-18714
Change-Id: I548182bc447d80d24f4de4ce7cf12ee1a753ed26
Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
Showing
- src/plugins/genericprojectmanager/genericbuildconfiguration.cpp 5 additions, 0 deletions...ugins/genericprojectmanager/genericbuildconfiguration.cpp
- src/plugins/genericprojectmanager/genericbuildconfiguration.h 2 additions, 0 deletions...plugins/genericprojectmanager/genericbuildconfiguration.h
- src/plugins/projectexplorer/buildconfiguration.cpp 23 additions, 1 deletionsrc/plugins/projectexplorer/buildconfiguration.cpp
- src/plugins/projectexplorer/buildconfiguration.h 2 additions, 0 deletionssrc/plugins/projectexplorer/buildconfiguration.h
- src/plugins/projectexplorer/gcctoolchain.cpp 1 addition, 1 deletionsrc/plugins/projectexplorer/gcctoolchain.cpp
- src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp 5 additions, 0 deletionssrc/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp
- src/plugins/qmakeprojectmanager/qmakebuildconfiguration.h 2 additions, 0 deletionssrc/plugins/qmakeprojectmanager/qmakebuildconfiguration.h
Loading
Please register or sign in to comment