Commit a78fd025 authored by Orgad Shaneh's avatar Orgad Shaneh Committed by Orgad Shaneh

Debugger: Do no warn when debugging with MinGW

Change-Id: Iee9cc2232c002ea960f05848df02ac0658017911
Reviewed-by: default avatarhjk <hjk@qt.io>
Reviewed-by: David Schulz's avatarDavid Schulz <david.schulz@qt.io>
parent 671e3eba
......@@ -1798,14 +1798,23 @@ void DebuggerEngine::validateExecutable()
QString detailedWarning;
switch (sp->toolChainAbi.binaryFormat()) {
case Abi::PEFormat: {
if (sp->cppEngineType != CdbEngineType) {
QString preferredDebugger;
if (sp->toolChainAbi.osFlavor() == Abi::WindowsMSysFlavor) {
if (sp->cppEngineType == CdbEngineType)
preferredDebugger = "GDB";
} else if (sp->cppEngineType != CdbEngineType) {
// osFlavor() is MSVC, so the recommended debugger is CDB
preferredDebugger = "CDB";
}
if (!preferredDebugger.isEmpty()) {
warnOnInappropriateDebugger = true;
detailedWarning = tr(
"The inferior is in the Portable Executable format.\n"
"Selecting CDB as debugger would improve the debugging "
"experience for this binary format.");
"Selecting %1 as debugger would improve the debugging "
"experience for this binary format.").arg(preferredDebugger);
break;
} else if (warnOnRelease) {
}
if (warnOnRelease && sp->cppEngineType == CdbEngineType) {
if (!symbolFile.endsWith(".exe", Qt::CaseInsensitive))
symbolFile.append(".exe");
QString errorMessage;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment