Commit bf46cf8e authored by Nikita Baryshnikov's avatar Nikita Baryshnikov

ScxmlEditor: silent fallthrough warnings

Change-Id: I7bd7140f05e8342a2e10713eb1646e0bd3f028ff
Reviewed-by: Ulf Hermann's avatarUlf Hermann <ulf.hermann@qt.io>
parent 66423bcb
......@@ -30,6 +30,7 @@
#include "scxmluifactory.h"
#include <coreplugin/minisplitter.h>
#include <utils/qtcfallthrough.h>
#include <QHeaderView>
#include <QLabel>
......@@ -84,6 +85,7 @@ void StateProperties::tagChange(ScxmlDocument::TagChange change, ScxmlTag *tag,
case ScxmlDocument::TagContentChanged:
if (tag != m_tag)
return;
Q_FALLTHROUGH();
case ScxmlDocument::TagCurrentChanged:
setTag(tag);
break;
......
......@@ -33,6 +33,8 @@
#include "serializer.h"
#include "stateitem.h"
#include <utils/qtcfallthrough.h>
#include <QDebug>
#include <QPainter>
#include <QPen>
......@@ -491,7 +493,7 @@ QVariant ConnectableItem::itemChange(GraphicsItemChange change, const QVariant &
case ItemParentHasChanged:
updateTransitions(true);
updateTransitionAttributes(true);
// FIXME: intended fallthrough?
Q_FALLTHROUGH();
case ItemPositionHasChanged:
if (!m_releasedFromParent && !blockUpdates())
checkParentBoundingRect();
......
......@@ -541,7 +541,7 @@ void GraphicsScene::endTagChange(ScxmlDocument::TagChange change, ScxmlTag *tag,
item->finalizeCreation();
}
}
// FIXME: intended fallthrough?
break;
case ScxmlDocument::TagAddChild: {
ScxmlTag *childTag = tag->child(value.toInt());
if (childTag) {
......
......@@ -26,6 +26,8 @@
#include "scattributeitemmodel.h"
#include "mytypes.h"
#include <utils/qtcfallthrough.h>
#include <QBrush>
using namespace ScxmlEditor::PluginInterface;
......@@ -91,6 +93,7 @@ QVariant SCAttributeItemModel::data(const QModelIndex &index, int role) const
case Qt::DisplayRole:
if (bExtraRow)
return index.column() == 0 ? tr("- name -") : tr(" - value -");
Q_FALLTHROUGH();
case Qt::EditRole: {
if (index.column() == 0) {
if (bEditable) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment