Final 6.7 translation api review action points

api_review_qt_6_7_part3.md

@@ -43,6 +43,14 @@ First `target` option that is now deprecated IS documented.
 **Notes:**
 
 **Action points:**
+AP: Add synopsis for old qt <6.7 version as well, this means restoring the `NO_TARGET_DEPENDENCY` option and documentation
+AP: Add since qt version for relevant options
+AP: Old snippet uses the deprecated API, update to use new API
+AP: Add `LRELEASE_TARGET` option to example snippet
+AP: Check what happens if `NO_TARGET_DEPENDENCY` is used with the new API
+
+
+
 
 
 
@@ -75,6 +83,15 @@ First `target` option that is now deprecated IS documented.
 **Notes:**
 
 **Action points:**
+AP: Add synopsis for old qt <6.7 version as well and documentation for old synopsis
+AP: Add since qt version for relevant options
+AP: Old snippet uses the deprecated API, update to use new API
+AP: Make sure to mention `LUPDATE_TARGET` in example snippet
+AP: Rename `TARGETS` to `SOURCE_TARGETS`
+
+
+
+
 
 
 
@@ -99,6 +116,13 @@ Has example snippet.
 **Notes:**
 
 **Action points:**
+AP: Rename to `qt_collect_translation_source_targets`, make sure doc snippet is updated to use `qt_add_lupdate(SOURCE_TARGETS)`
+AP: Adjust example snippet wording that the 'tests' won't be collected for translation
+AP: Link to upstream cmake doc for `BUILDSYSTEM_TARGETS`
+AP: Provide example snippet how to use with `cmake_language(DEFER CALL)`
+
+
+
 
 
 
@@ -122,6 +146,9 @@ No example snippets.
 **Notes:**
 
 **Action points:**
+AP: Add doc snippets to the properties on how to set them
+
+
 
 
 
@@ -152,6 +179,11 @@ Has example snippet.
 **Notes:**
 
 **Action points:**
+AP: Link to both `qt_add_lupdate` and `qt_collect_i18n_targets`
+AP: Add doc whether one wildcard matches subdirectories as well
+AP: Clarify what `are excluded from translation.` means, it refers to `SOURCE_TARGETS` option of `qt_add_lupdate`
+
+
 
 
 
@@ -206,6 +238,16 @@ AP: Mention idbased option on qt_add_translations doc page, and link to page abo
 just mention `LRELEASE_OPTIONS -idbased`
 AP: Kai: Talk to qt design team why they use idbased translations
 
+
+
+Extra APs:
+AP: Add example snippet that uses `SOURCE_TARGETS`
+AP: Add synopsis for old signature as well
+AP: Consider removing doc section 'qt_add_translations before Qt 6.7' because we will document old synopsis
+
+
+
+
 ### `qt_add_translations` - New API options and behavior change
 
 Automatically determine `.ts` file names in `qt_add_translations`
@@ -242,6 +284,9 @@ No "since qt version" blurb for new options.
 **Notes:**
 
 **Action points:**
+AP: Document that variable `QT_I18N_LANGUAGES`, newly renamed to something that i don't remember, is set when
+`qt_standard_project_setup(I18N_LANGUAGES de fr)` is called in `Automatic Determination of .ts File Paths` section.
+AP: Add doc snippet with `TS_FILE_BASE` and example output.
 
 
 
@@ -264,6 +309,8 @@ No "since qt version" blurb for new options.
 **Notes:**
 
 **Action points:**
+AP: All good
+
 
 
 ### `qt_add_lupdate` - New API options and behavior change
@@ -296,7 +343,9 @@ No "since qt version" blurb for new options.
 **Notes:**
 
 **Action points:**
-
+AP: Add synopsis for old signature.
+AP: `NATIVE_TS_FILE` already renamed to plurals, double check that no more native is mentioend.
+AP: Make `QT_I18N_NATIVE_LANGUAGE` link to actual doc page in `Native Language` doc section.
 
 
 ### Overall translations documentation page
@@ -320,3 +369,8 @@ don't mention very much about build systems.
 **Notes:**
 
 **Action points:**
+AP:  In adding translations section on getting started with cmake, remove `TS_FILES`, because already implicit.
+Add sentence and link to bigger example on doc page of `qt_add_translations`.
+See if anything else makes sense to change.
+AP: File task to revise the above two generic links if makes sense to modify anything.
+