Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Q
Qt6 CMake API Review
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Alexandru Croitor
Qt6 CMake API Review
Commits
d9c488a8
Commit
d9c488a8
authored
1 year ago
by
Alexandru Croitor
Browse files
Options
Downloads
Patches
Plain Diff
Add initial notes and AP for Qt 6.7 review
parent
8278cfbd
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
api_review_qt_6_7.md
+58
-4
58 additions, 4 deletions
api_review_qt_6_7.md
with
58 additions
and
4 deletions
api_review_qt_6_7.md
+
58
−
4
View file @
d9c488a8
...
...
@@ -51,6 +51,11 @@ Has "since qt version" blurb on new variable, but not old one.
**Notes:**
**Action points:**
AP: QT_ANDROID_DEPLOYMENT_TYPE link from first doc page is broken, leads to other page
AP: Remove the old android-deploy-release variable, warn if used
AP: Un-TP it for Qt 6.7
AP: Alexey: Check if target specific option exists
AP: Add example snippet, whether it's project scoped or directory scoped
### `qt_generate_deploy_app_script` / `qt_deploy_runtime_dependencies` - New API option
...
...
@@ -70,6 +75,12 @@ No "since qt version" blurb.
**Action points:**
AP: Add since qt version
AP: Add example snippet
AP: Clarify in docs that it only works for windeployqt / macdeployqt
AP: Clarify in docs how to use tool-specific with an if/else dance, probably in example snippet as well
AP: Add warning when a value is passed when targeting Linux, because it's a no-op
### `QT_DEPLOY_LIBEXEC_DIR` - New deploy time variable
...
...
@@ -86,6 +97,12 @@ Wrong "since qt version" blurb.
**Notes:**
**Action points:**
AP: Fix since qt version blurb
AP: Modify example snippet usage, add inline comment that
`CMAKE_INSTALL_LIBEXECDIR`
sets
`QT_DEPLOY_LIBEXEC_DIR`
AP: Add a mention of QtWebEngineProcess to docs as an example why one would want to use this
AP: Convert the single bullet point in docs into regular paragraph
AP: Add a note to all deploy variables that they are low-level options that you probably don't care about
AP: Create a task to split configure vars reference from deploy vars reference
### `qt_deploy_runtime_dependencies` `LIBEXEC_DIR` - New API option
...
...
@@ -103,6 +120,12 @@ No "since qt version" blurb.
**Notes:**
**Action points:**
AP: Add since qt version into text or synopsis
AP: Add a link to https://doc-snapshots.qt.io/qt6-dev/cmake-variable-reference.html#qt6-core
after the paragraph that lists LIBEXEC_DIR, with wording like
"See the deploy variables that are overridden by the options mentioned above"
Or Add table with 2 columnes, option and associated variable
AP: Don't add example snippet, just link from the table
### `qt6_add_library` - behavior change
...
...
@@ -120,9 +143,14 @@ Documented.
No specific example snippet.
No "since qt version" blurb.
**Notes:**
**Action points:**
AP: Add since qt version
AP: Add an example snippet
AP: Add policy to control it, rather than making a breaking change, with related docs
You might need to check qtgrpc if something breaks if policy is OLD by default
### `QT_WASM_MAXIMUM_MEMORY` - New variable
...
...
@@ -143,8 +171,14 @@ Has "since qt version" blurb.
**Notes:**
**Action points:**
AP: Fix applicataion typo
AP: Link to better emscripten compiler page, rather than to top of github
AP: Have a meeting with wasm guys, what do we want to achieve, can we provide a better API,
rather than one variable per compile option, something like a dictionary with defaults that
can be modified per key, also figure out if we want to document in qmake and whether it will
be the same kind of dictionary style assignments
AP: Keep TP because of the above AP
AP: Don't document qmake for 6.7 at the moment
...
...
@@ -171,6 +205,10 @@ Has "since qt version" blurb.
**Notes:**
**Action points:**
AP: Ask Laszlo if it makes sense to add an example snippet
AP: Should it be TP or not? If it's not TP, should it be in new features doc for Qt 6.7?
QShaderBaker header says RHI C++ API has limited compat promise, does that apply to qsb CLI syntax
and also to CMake API?
...
...
@@ -208,7 +246,20 @@ From Sami:
*
No separate qt_add_qml_module option: could be needed, what is the use case for a qt_add_qml_module_option?
*
since qt version blurb: that is indeed missing, the variable was introduced in 6.7
From Alex:
*
is meant for IDEs, probably neither QtCreator nor other Qt IDEs set it
*
We don't neeed a module specific option, it only makes sense project-wide
*
discussion whether it should be opt out, but so far consensus is to keep it opt-in,
possibly change it way later in Qt 6.9+ with a policy
**Action points:**
AP: Double check doc grammar
AP: Link from qt_add_qml_module docs, already linked from https://doc-snapshots.qt.io/qt6-dev/qtqml-tooling-qmlls.html
AP: Double check if it generates and works with multiple modules in the same project, is it one per module, or one per project
AP: Add introduced in Qt 6.7 blurb
AP: Add example snippet that shows how to pass the arg, e.g. with
`-DQT_QML_GENERATE_QMLLS_INI=ON`
AP: Modify doc note to more explicitly mention it's generated in the source dir
AP: Alex: Assign the above to Sami
### `qt_generate_deploy_qml_app_script` - new API option
...
...
@@ -226,7 +277,7 @@ No "since qt version" blurb.
**Notes:**
**Action points:**
AP: Do the same APs as for the qtbase equivalent
...
...
@@ -279,10 +330,13 @@ Could be considered TP because no docs for so long.
No example snippet.
No "since qt version" blurb.
https://bugreports.qt.io/browse/QTBUG-114147
**Notes:**
**Action points:**
AP: Ask David again if he can document them. If he doesn't reply, ask Graphics team
AP: Docs, snippet, since qt, whether it is TP
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment