Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found

Target

Select target project
  • torarne/qt6-cmake-api-review
  • Sami.Shalayel/qt6-cmake-api-review
  • aledelev/qt6-cmake-api-review
  • crscott/qt6-cmake-api-review
  • alcroito/qt6-cmake-api-review
5 results
Show changes
Commits on Source (2)
# Changes
## more submodules
Still to be processed:
-
-
-
## qtbase
### `qt_wrap_cpp` - Behavior change
`qt_wrap_cpp` will accept .cpp files from now
on. When .cpp a file is passed to `qt_wrap_cpp`, `TARGET` parameter
becomes required. Generated .moc files are added to target's sources
inside `qt_wrap_cpp`. That's why the output parameter will not contain
generated .moc files.
https://codereview.qt-project.org/c/qt/qtbase/+/492315
https://doc-snapshots.qt.io/qt6-dev/qt-wrap-cpp.html
Signature
```cmake
qt_wrap_cpp(<VAR> src_file1 [src_file2 ...]
[TARGET target]
[OPTIONS ...]
[DEPENDS ...])
```
Documented.
Has example snippet.
Has "since qt version" blurb.
**Notes:**
**Action points:**
## qtprotobuf
### `qt_add_protobuf` - New API out of TP
https://doc-snapshots.qt.io/qt6-dev/qt-add-protobuf.html
https://doc-snapshots.qt.io/qt6-dev/qtprotobufgen-qt-tool.html
Signature
```cmake
qt_add_protobuf(<target>
PROTO_FILES <file> ...
[COPY_COMMENTS]
[GENERATE_PACKAGE_SUBFOLDERS]
[EXTRA_NAMESPACE <namespace>]
[EXPORT_MACRO <infix>]
[QML [QML_URI <uri>]]
[PROTO_INCLUDES <path> ...]
[OUTPUT_DIRECTORY <dir>]
[OUTPUT_HEADERS <var>]
[OUTPUT_TARGETS <var>]
)
```
Documented?
Example snippets?
Has "since qt version" blurb?
Still in TP?
Should it link to grpc docs as well?
**Notes:**
**Action points:**
## qtgrpc
### `qt_add_grpc` - New API out of TP
https://doc-snapshots.qt.io/qt6-dev/qt-add-grpc.html
https://doc-snapshots.qt.io/qt6-dev/qtgrpcgen-qt-tool.html
Signature
```cmake
qt_add_grpc(<target> <TARGET_TYPE>
PROTO_FILES <file> ...
[COPY_COMMENTS]
[GENERATE_PACKAGE_SUBFOLDERS]
[EXTRA_NAMESPACE <namespace>]
[EXPORT_MACRO <infix>]
[PROTO_INCLUDES <path> ...]
[OUTPUT_DIRECTORY <dir>]
[OUTPUT_HEADERS <var>]
[OUTPUT_TARGETS <var>]
)
```
Documented?
Example snippets?
Has "since qt version" blurb?
Still in TP?
Should it link to protobuf docs as well?
**Notes:**
**Action points:**
# Changes
## qbase
### `qt_standard_project_setup` - API Change and new variables
......@@ -592,3 +594,27 @@ No "since qt version" blurb for new options.
**Notes:**
**Action points:**
### Overall translations documentation page
We are missing a more general adding translations page after all the new API was added.
The most prominent CMake one is
https://doc-snapshots.qt.io/qt6-dev/cmake-get-started.html#adding-translations
which is quite short.
And the generic ones at
https://doc-snapshots.qt.io/qt6-dev/internationalization.html
https://doc-snapshots.qt.io/qt6-dev/localization.html
don't mention very much about build systems.
**Notes:**
**Action points:**