Andy Nichols authored 4 years ago and Christian Strømme committed 4 years ago

Add missing overrides

Change-Id: Ieddabdd31c92248a870cfd786c146f05fa1c5536
Reviewed-by: Christian Strømme <christian.stromme@qt.io>

Change-Id: Ie42a8fee26e7fa49f1b4802e957207180ff441df
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>

Andy Nichols authored 4 years ago and Paul Tvete committed 4 years ago

Change-Id: I8cd04a2ea5566831e6c9f8015841dfe99d41e353
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: I3eda4e5a42b843b6c9b7153a398563b585cb66fe
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: I97b3b713e19c2d064fd0adca2c35993a41c9face
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>

Change-Id: Ia6b15117771748dcc88c9f2f2139e5e35bad95c1
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: I92463b2bdf0aa3ba189a00746a779e66fa091e44
Reviewed-by: Christian Strømme <christian.stromme@qt.io>

Most of this documentation is quite detailed and good, but
the description was a bit vague (though called "Environment" this
class doesn't actually define an environment, just a bunch of
unrelated properties that didn't fit elsewhere).

Change-Id: I2442bdeecff3e9aacc5cbda55cd6f1fcca43781c
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Flesh out the camera documentation, adding links and screenshots and
more details about the camera types. This also tries to clarify some
statements that were confusing to me.

Change-Id: I2019627e5fb726b2d0a70513beed6aaed8c3a3b9
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Id9129a1635f80eed7a381935ee65a8b577f035ee
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: I9804ae8b400a2fdb1c04bb718deca722afdc6f2d
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>

Change-Id: I0c2ad4e918e1570a7e09c1dbda0429d3ad8af969
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Explicitly dividing the types into Resource types and Spatial types,
and using it as the first word in the list element, makes it easier to
pick-up what each list element is talking about.

Change-Id: I953e4ec2f29dcb51e88cb3ce7d5686e40e49fe3c
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: I8dcfe8452b56f693eddfc06d0968c31fbb55cfd4
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

If loading an atlased SGTexture, the commitTextureOperations() call
needs to be done on the removed-from-atlas texture.

Add a lancelot case that compares
a) Quick's rendering of compressed texture files
b) Quick3D's rendering of the same
c) Quick3Ds rendering of the Quick texture items above

Task-number: QTBUG-80465
Change-Id: I22e30f9dee3c75383ae6ed8cbddacaefaf8800e1
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: I1361cf98ba57e6abff05ad03fa082bb2e9208f6d
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

And make some corrections

Change-Id: I9cd08f9e0010b283c45547769e3a1f13d3572761
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: If4af1cd489af4f672aa402fdf429ea78282ae311
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: I7b498fbcf6e0ee615b88b55d8b35736e6e55d3b7
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>

Change-Id: I6051388c70f4aeff5fc75e4ed7a832c968b2e5f3
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

assimp header file describes it as a half value
but when I tested it with blender's export,
it seems not half in FBX, Collada, and glTF formats

Change-Id: Iece58ab1aaf71a10f0eaf16383a7fc3c15ca4fb6
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Task-number: QTBUG-87661
Change-Id: I3620a53779744f781db08314a8a5178ddd810259
Reviewed-by: Daniel Smith <Daniel.Smith@qt.io>

Principled materials have been fixed so they look correct now.

Change-Id: I5a15c27ded2e4788a3b7cbdfb9d414e8efcb8b3b
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Ic3a4cce2629eea282b2a1aba6ef361d579495b27
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Iaf33320b219dfcae6cf50bbf2446b1b2c14798da
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>

Calculating the view vector in the vertex shader leads to incorrectly
interpolated values.

Fixes: QTBUG-86681
Change-Id: I73d3bae03dd211f435421c29051a22a485844f5d
Reviewed-by: Tony Leinonen <tony.leinonen@qt.io>
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Fixes: QTBUG-78135
Change-Id: I83686a01aa38dfff41aaffaef51dc338b357aa45
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Id5c7e1c40c7498f74042deb6f68b0c8d1f4cf535
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

With the huge sidebar and larger font than what a local qdoc run shows,
none of the tables fit properly, leading to having to do confusing
horizontal scrolling. Avoid this by getting rid of the tables and
scaling the images down.

Change-Id: I3d871323e5dd436a6a320e798be738d4caa2dbe9
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Remove the GLES 3.1 and GL 4.3 points as compute shaders are not used
anymore in any form.

Fix the GLES link.

Update to the preferred GraphicsApi enum naming. (::Vulkan, not
::VulkanRhi)

Change-Id: Ia5e44a2c48a104db48fa1a716d5c6f369ac54a5c
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Ie3c6526a9b62158e6242b7a2ae7519126830b6f7
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Change-Id: Icf6861f0a90fd78607eb67c78de8fbdfd1e80a8f
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>

Some more information is added to the example, with links to related
topics. This will act as an introduction to the basic Quick 3D concepts,
linked from the topic page.

Fixes: QTBUG-86444
Change-Id: I0a2e7667480e715e499c776ade25302254388b69
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Name change from qt6_quick3d_build_shaders to qt6_quick3d_generate_materials
as discussed in CMake API review.

Change-Id: I919e92a9cfe5686684757240ef9a86a238e48fb5
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

Since the connection to QQuickWindow::afterFrameEnd is to a lambda,
it's not automatically disconnected at QQuick3DSceneRenderer
destruction, which in some cases resulted in cleanupResources() getting
called after QQuick3DSceneRenderer no longer exists.

Change-Id: I6e6cedf570d57e74cfdab5c0db3f9ce0d2ff35a5
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>

A lot lighter in fact. Looking at the generated assembly proves
that we successfully avoid copying sizeof(QRhiShaderResourceBinding::Data)
bytes on generating every element in the bindings list. (with MSVC at least)

The code becomes nicer in fact since we now employ a proper
QSSGRhiShaderResourceBindingList container that offers straightforward
addXx() functions which are now used everywhere instead of filling up
QVLAs manually all over the place. By precalculating a hash value we can
also optimize somewhat the binding list comparisons.

The gains in practice are small, but visible, depending on the scene. It's
somewhere around 1-1.5 FPS in 1000x10k tests on this system.

We are intentionally not using the QRhi static factory helpers anymore
because (1) their non-inline nature is problematic, depending on the compiler,
(2) we want to get a valid QRhiShaderResourceBinding in place, not via a
factory returning a whole new instance. To be seen if the findings here
can be brought back to the QRhi API too at some point, but for now the
goal is to get the hot code path right.

Change-Id: Ie01d60191c458731fe71f85b8fbcc888c06eea0e
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

The sections for effects, custom geometry and custom texture data
will follow separately.

Task-number: QTBUG-86445
Change-Id: I9dcfb58f080d42ef2fd6ebbfd079f8f895f5a8c0
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Task-number: QTBUG-86525
Change-Id: I68d714208fca9ef9e206a0b390acd778c6a67c8e
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Change-Id: Id4624b29457db05fe7d0208d952f2e2d78e599d8
Reviewed-by: Andy Nichols <andy.nichols@qt.io>

Specifying the version is no longer required as long
as you don't need a specific older version.

And QtQuick.Window is now part of the main QtQuick
import.

Change-Id: I40920a13989e8d86aafe4e903bbda073335a822e
Reviewed-by: Andy Nichols <andy.nichols@qt.io>