Skip to content
Snippets Groups Projects
Commit 0b67a513 authored by Hugues Delorme's avatar Hugues Delorme
Browse files

Utils: let SubmitEditorWidget handle empty description


SubmitEditorWidget::canSubmit() now return false if the description
field is empty. This avoids dummy code duplication in VCS plugins.

Change-Id: I11e4928e8eed432ccee6fa1f3516f0179a54625c
Reviewed-by: default avatarTobias Hunger <tobias.hunger@nokia.com>
Reviewed-by: default avatarBill King <bill.king@nokia.com>
parent 19425b5e
No related branches found
No related tags found
No related merge requests found
......@@ -578,6 +578,8 @@ void SubmitEditorWidget::insertTopWidget(QWidget *w)
bool SubmitEditorWidget::canSubmit() const
{
if (cleanupDescription(descriptionText()).trimmed().isEmpty())
return false;
const unsigned checkedCount = checkedFilesCount();
return d->m_emptyFileListEnabled || checkedCount > 0;
}
......
......@@ -154,11 +154,8 @@ void GitSubmitEditorWidget::setPanelData(const GitSubmitEditorPanelData &data)
bool GitSubmitEditorWidget::canSubmit() const
{
QString message = cleanupDescription(descriptionText()).trimmed();
if (m_gitSubmitPanelUi.invalidAuthorLabel->isVisible()
|| m_gitSubmitPanelUi.invalidEmailLabel->isVisible()
|| message.isEmpty())
|| m_gitSubmitPanelUi.invalidEmailLabel->isVisible())
return false;
return SubmitEditorWidget::canSubmit();
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment