Skip to content
Snippets Groups Projects
Commit 0b7f80de authored by Christiaan Janssen's avatar Christiaan Janssen Committed by Kai Koehne
Browse files

QmlProfiler: avoid false positives in binding loops


It happens when anonymous bindings are involved.

Change-Id: Id0107040565351bf857bff7357a76bc82f0fd093
Reviewed-by: default avatarKai Koehne <kai.koehne@digia.com>
parent 8bf3647b
No related branches found
No related tags found
No related merge requests found
......@@ -174,7 +174,6 @@ public:
void prepareForDisplay();
void linkStartsToEnds();
void linkEndsToStarts();
bool checkBindingLoop(QmlRangeEventData *from, QmlRangeEventData *current, QList<QmlRangeEventData *>visited);
// stats
......@@ -1246,7 +1245,8 @@ void QmlProfilerDataModel::QmlProfilerDataModelPrivate::findBindingLoops(qint64
stack << inTimeEvent;
stackRefs << currentEvent;
if (loopDetected) {
// skip loops if bindings are anonymous
if (loopDetected && !currentEvent->location.filename.isEmpty()) {
if (i >= fromIndex && i <= toIndex) {
// for the statistics
currentEvent->isBindingLoop = true;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment