Wizards: avoiding code duplication
I moved setPath(wizardDialogParameters.defaultPath()) into
the constructor of BaseProjectWizardDialog.
I created addExtensionPages() instead of having of having the
foreach everywhere. Moving the call into the constructor of
BaseProjectWizardDialog is not trivial since a lot of derived classes
rely on execution order and the order is often different.
Entangling this is not trivial and easily might break functionality.
Change-Id: I48dddaf72caea84da783dc9e2f42f2c7eff1c0ce
Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
Showing
- src/plugins/projectexplorer/baseprojectwizarddialog.cpp 8 additions, 0 deletionssrc/plugins/projectexplorer/baseprojectwizarddialog.cpp
- src/plugins/projectexplorer/baseprojectwizarddialog.h 1 addition, 0 deletionssrc/plugins/projectexplorer/baseprojectwizarddialog.h
- src/plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp 1 addition, 3 deletions...plugins/qmlprojectmanager/qmlprojectapplicationwizard.cpp
- src/plugins/qt4projectmanager/customwidgetwizard/customwidgetwizard.cpp 0 additions, 1 deletion...4projectmanager/customwidgetwizard/customwidgetwizard.cpp
- src/plugins/qt4projectmanager/customwidgetwizard/customwidgetwizarddialog.cpp 1 addition, 2 deletions...ctmanager/customwidgetwizard/customwidgetwizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/abstractmobileappwizard.cpp 2 additions, 3 deletions...ins/qt4projectmanager/wizards/abstractmobileappwizard.cpp
- src/plugins/qt4projectmanager/wizards/consoleappwizard.cpp 0 additions, 1 deletionsrc/plugins/qt4projectmanager/wizards/consoleappwizard.cpp
- src/plugins/qt4projectmanager/wizards/consoleappwizarddialog.cpp 1 addition, 2 deletions...gins/qt4projectmanager/wizards/consoleappwizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/emptyprojectwizard.cpp 0 additions, 1 deletionsrc/plugins/qt4projectmanager/wizards/emptyprojectwizard.cpp
- src/plugins/qt4projectmanager/wizards/emptyprojectwizarddialog.cpp 1 addition, 2 deletions...ns/qt4projectmanager/wizards/emptyprojectwizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/guiappwizard.cpp 0 additions, 1 deletionsrc/plugins/qt4projectmanager/wizards/guiappwizard.cpp
- src/plugins/qt4projectmanager/wizards/guiappwizarddialog.cpp 1 addition, 2 deletionssrc/plugins/qt4projectmanager/wizards/guiappwizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/librarywizard.cpp 0 additions, 1 deletionsrc/plugins/qt4projectmanager/wizards/librarywizard.cpp
- src/plugins/qt4projectmanager/wizards/librarywizarddialog.cpp 1 addition, 2 deletions...plugins/qt4projectmanager/wizards/librarywizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/qtwizard.cpp 6 additions, 0 deletionssrc/plugins/qt4projectmanager/wizards/qtwizard.cpp
- src/plugins/qt4projectmanager/wizards/qtwizard.h 2 additions, 0 deletionssrc/plugins/qt4projectmanager/wizards/qtwizard.h
- src/plugins/qt4projectmanager/wizards/subdirsprojectwizard.cpp 1 addition, 1 deletion...lugins/qt4projectmanager/wizards/subdirsprojectwizard.cpp
- src/plugins/qt4projectmanager/wizards/subdirsprojectwizarddialog.cpp 1 addition, 2 deletions.../qt4projectmanager/wizards/subdirsprojectwizarddialog.cpp
- src/plugins/qt4projectmanager/wizards/testwizard.cpp 0 additions, 1 deletionsrc/plugins/qt4projectmanager/wizards/testwizard.cpp
- src/plugins/qt4projectmanager/wizards/testwizarddialog.cpp 1 addition, 2 deletionssrc/plugins/qt4projectmanager/wizards/testwizarddialog.cpp
Loading
Please register or sign in to comment