vcsbase: add mechanism to ease management of VCS settings
Management of VCS settings was rather laborious (see BazaarSettings, GitSettings, ...). To overcome this, the base class VCSBaseClientSettings is now equipped with a mechanism factorizing redundant code for VCS settings, like operator=(), operator==(), writeSettings(), ... Heir classes of VCSBaseClientSettings only need to declare the settings (key + default value). Bazaar and Mercurial plugins are impacted. Change-Id: I7e4093a6d9476f3c8954f4d104f1b26ac185beb9 Merge-request: 2204 Reviewed-by:Tobias Hunger <tobias.hunger@nokia.com> Reviewed-on: http://codereview.qt-project.org/4889 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com>
Showing
- src/plugins/bazaar/bazaarclient.cpp 9 additions, 7 deletionssrc/plugins/bazaar/bazaarclient.cpp
- src/plugins/bazaar/bazaarcontrol.cpp 1 addition, 1 deletionsrc/plugins/bazaar/bazaarcontrol.cpp
- src/plugins/bazaar/bazaarplugin.cpp 5 additions, 5 deletionssrc/plugins/bazaar/bazaarplugin.cpp
- src/plugins/bazaar/bazaarsettings.cpp 17 additions, 68 deletionssrc/plugins/bazaar/bazaarsettings.cpp
- src/plugins/bazaar/bazaarsettings.h 7 additions, 13 deletionssrc/plugins/bazaar/bazaarsettings.h
- src/plugins/bazaar/clonewizard.cpp 2 additions, 2 deletionssrc/plugins/bazaar/clonewizard.cpp
- src/plugins/bazaar/optionspage.cpp 14 additions, 14 deletionssrc/plugins/bazaar/optionspage.cpp
- src/plugins/mercurial/clonewizard.cpp 2 additions, 2 deletionssrc/plugins/mercurial/clonewizard.cpp
- src/plugins/mercurial/mercurialclient.cpp 2 additions, 2 deletionssrc/plugins/mercurial/mercurialclient.cpp
- src/plugins/mercurial/mercurialcontrol.cpp 1 addition, 1 deletionsrc/plugins/mercurial/mercurialcontrol.cpp
- src/plugins/mercurial/mercurialplugin.cpp 5 additions, 9 deletionssrc/plugins/mercurial/mercurialplugin.cpp
- src/plugins/mercurial/mercurialplugin.h 0 additions, 2 deletionssrc/plugins/mercurial/mercurialplugin.h
- src/plugins/mercurial/mercurialsettings.cpp 7 additions, 44 deletionssrc/plugins/mercurial/mercurialsettings.cpp
- src/plugins/mercurial/mercurialsettings.h 3 additions, 8 deletionssrc/plugins/mercurial/mercurialsettings.h
- src/plugins/mercurial/optionspage.cpp 14 additions, 14 deletionssrc/plugins/mercurial/optionspage.cpp
- src/plugins/vcsbase/vcsbaseclient.cpp 23 additions, 19 deletionssrc/plugins/vcsbase/vcsbaseclient.cpp
- src/plugins/vcsbase/vcsbaseclientsettings.cpp 253 additions, 70 deletionssrc/plugins/vcsbase/vcsbaseclientsettings.cpp
- src/plugins/vcsbase/vcsbaseclientsettings.h 33 additions, 32 deletionssrc/plugins/vcsbase/vcsbaseclientsettings.h
- src/plugins/vcsbase/vcsjobrunner.cpp 30 additions, 14 deletionssrc/plugins/vcsbase/vcsjobrunner.cpp
- src/plugins/vcsbase/vcsjobrunner.h 5 additions, 1 deletionsrc/plugins/vcsbase/vcsjobrunner.h
Loading
Please register or sign in to comment