TextEditors: Avoid changing document after construction.
Also when duplicating editors, we don't want to change the document
after construction. Actually at some places (e.g. CppEditorSupport
creation) we don't handle document changes correctly, and we are only
lucky that things still (more or less?) work. Get rid of
BaseTextEditorWidget::duplicateFrom and use copy-constructor style instead.
Change-Id: I7f688b7fcc51d1bb5e222bb333f0d28479b597a6
Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
Showing
- src/plugins/cmakeprojectmanager/cmakeeditor.cpp 13 additions, 4 deletionssrc/plugins/cmakeprojectmanager/cmakeeditor.cpp
- src/plugins/cmakeprojectmanager/cmakeeditor.h 3 additions, 0 deletionssrc/plugins/cmakeprojectmanager/cmakeeditor.h
- src/plugins/cppeditor/cppeditor.cpp 24 additions, 19 deletionssrc/plugins/cppeditor/cppeditor.cpp
- src/plugins/cppeditor/cppeditor.h 3 additions, 2 deletionssrc/plugins/cppeditor/cppeditor.h
- src/plugins/genericprojectmanager/genericprojectfileseditor.cpp 7 additions, 3 deletions...ugins/genericprojectmanager/genericprojectfileseditor.cpp
- src/plugins/genericprojectmanager/genericprojectfileseditor.h 4 additions, 0 deletions...plugins/genericprojectmanager/genericprojectfileseditor.h
- src/plugins/glsleditor/glsleditor.cpp 16 additions, 5 deletionssrc/plugins/glsleditor/glsleditor.cpp
- src/plugins/glsleditor/glsleditor.h 3 additions, 0 deletionssrc/plugins/glsleditor/glsleditor.h
- src/plugins/pythoneditor/pythoneditor.cpp 1 addition, 3 deletionssrc/plugins/pythoneditor/pythoneditor.cpp
- src/plugins/pythoneditor/pythoneditorwidget.cpp 12 additions, 1 deletionsrc/plugins/pythoneditor/pythoneditorwidget.cpp
- src/plugins/pythoneditor/pythoneditorwidget.h 3 additions, 0 deletionssrc/plugins/pythoneditor/pythoneditorwidget.h
- src/plugins/qmakeprojectmanager/profileeditor.cpp 13 additions, 2 deletionssrc/plugins/qmakeprojectmanager/profileeditor.cpp
- src/plugins/qmakeprojectmanager/profileeditor.h 3 additions, 0 deletionssrc/plugins/qmakeprojectmanager/profileeditor.h
- src/plugins/qmljseditor/qmljseditor.cpp 21 additions, 10 deletionssrc/plugins/qmljseditor/qmljseditor.cpp
- src/plugins/qmljseditor/qmljseditor.h 3 additions, 0 deletionssrc/plugins/qmljseditor/qmljseditor.h
- src/plugins/texteditor/basetexteditor.cpp 11 additions, 23 deletionssrc/plugins/texteditor/basetexteditor.cpp
- src/plugins/texteditor/basetexteditor.h 1 addition, 3 deletionssrc/plugins/texteditor/basetexteditor.h
- src/plugins/texteditor/basetexteditor_p.h 1 addition, 1 deletionsrc/plugins/texteditor/basetexteditor_p.h
- src/plugins/texteditor/plaintexteditor.cpp 8 additions, 2 deletionssrc/plugins/texteditor/plaintexteditor.cpp
- src/plugins/texteditor/plaintexteditor.h 2 additions, 0 deletionssrc/plugins/texteditor/plaintexteditor.h
Loading
Please register or sign in to comment