Commit 46c09e77 authored by Oswald Buddenhagen's avatar Oswald Buddenhagen
Browse files

change createEditor() error handling

take it out of the editor->open() error path. it's unrelated.
parent 40c6653f
......@@ -1211,18 +1211,20 @@ IEditor *EditorManager::openEditor(Core::Internal::EditorView *view, const QStri
return activateEditor(view, editor, flags);
IEditor *editor = createEditor(editorId, fn);
// If we could not open the file in the requested editor, fall
// back to the default editor:
if (!editor)
editor = createEditor(QString(), fn);
if (!editor) // Internal error
return 0;
QString errorString;
if (!editor || !editor->open(&errorString, fn)) {
if (!editor->open(&errorString, fn)) {
QMessageBox::critical(m_d->m_core->mainWindow(), tr("File Error"), errorString);
delete editor;
editor = 0;
return 0;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment