Analyzer: create a run control factory for all tools.
Having one factory per tool (or plugin) created some bugs:
* analyzer project settings being created twice
* per-project analyzer settings widget duplicated
Also, most of the code from the run control factory were copied.
Now, the Analyzer only creates one run control factory shared among all tools, and the IAnalyzerTool
has two new virtual method: canRun and createStartParameters. It simplify the code a bit, and
creating a new analyzer tool is easier (only two classes to subclass: IAnalyzerTool and IAnalyzerEngine).
Change-Id: I4e180846a26b74b2b77cb99bc97534d680a80a4d
Reviewed-by:
hjk <qthjk@ovi.com>
Showing
- src/plugins/analyzerbase/analyzerbase.pro 4 additions, 2 deletionssrc/plugins/analyzerbase/analyzerbase.pro
- src/plugins/analyzerbase/analyzermanager.cpp 0 additions, 1 deletionsrc/plugins/analyzerbase/analyzermanager.cpp
- src/plugins/analyzerbase/analyzerplugin.cpp 3 additions, 0 deletionssrc/plugins/analyzerbase/analyzerplugin.cpp
- src/plugins/analyzerbase/analyzerrunconfigwidget.cpp 35 additions, 27 deletionssrc/plugins/analyzerbase/analyzerrunconfigwidget.cpp
- src/plugins/analyzerbase/analyzerrunconfigwidget.h 18 additions, 3 deletionssrc/plugins/analyzerbase/analyzerrunconfigwidget.h
- src/plugins/analyzerbase/analyzerruncontrolfactory.cpp 104 additions, 0 deletionssrc/plugins/analyzerbase/analyzerruncontrolfactory.cpp
- src/plugins/analyzerbase/analyzerruncontrolfactory.h 10 additions, 13 deletionssrc/plugins/analyzerbase/analyzerruncontrolfactory.h
- src/plugins/analyzerbase/ianalyzertool.h 10 additions, 1 deletionsrc/plugins/analyzerbase/ianalyzertool.h
- src/plugins/qmlprofiler/qmlprofiler.pro 2 additions, 4 deletionssrc/plugins/qmlprofiler/qmlprofiler.pro
- src/plugins/qmlprofiler/qmlprofilerplugin.cpp 2 additions, 2 deletionssrc/plugins/qmlprofiler/qmlprofilerplugin.cpp
- src/plugins/qmlprofiler/qmlprofilerruncontrolfactory.cpp 0 additions, 160 deletionssrc/plugins/qmlprofiler/qmlprofilerruncontrolfactory.cpp
- src/plugins/qmlprofiler/qmlprofilertool.cpp 70 additions, 0 deletionssrc/plugins/qmlprofiler/qmlprofilertool.cpp
- src/plugins/qmlprofiler/qmlprofilertool.h 7 additions, 0 deletionssrc/plugins/qmlprofiler/qmlprofilertool.h
- src/plugins/valgrind/callgrindtool.cpp 1 addition, 1 deletionsrc/plugins/valgrind/callgrindtool.cpp
- src/plugins/valgrind/callgrindtool.h 2 additions, 2 deletionssrc/plugins/valgrind/callgrindtool.h
- src/plugins/valgrind/memchecktool.cpp 1 addition, 1 deletionsrc/plugins/valgrind/memchecktool.cpp
- src/plugins/valgrind/memchecktool.h 2 additions, 2 deletionssrc/plugins/valgrind/memchecktool.h
- src/plugins/valgrind/valgrind.pro 4 additions, 2 deletionssrc/plugins/valgrind/valgrind.pro
- src/plugins/valgrind/valgrindplugin.cpp 0 additions, 105 deletionssrc/plugins/valgrind/valgrindplugin.cpp
- src/plugins/valgrind/valgrindtool.cpp 91 additions, 0 deletionssrc/plugins/valgrind/valgrindtool.cpp
Loading
Please register or sign in to comment