Debugger: Consolidate GDB and LLDB "updateLocals" code paths
This splits the bool setToolTipExpression() operation into a bool canHandleToolTip(), and the actual processing of the request, which is mostly identical to the handling of a watcher. Handling a watcher is now mostly the same as a full Locals update, except for the 'partial' flag. Pushing the handling of that down to the bridges gives identical code paths in the gdb and lldbengine. Move that to the DebuggerEngine base class. Change-Id: I3861b43e8630c7e7bd57fcd549b2a2387e3d4869 Reviewed-by:hjk <hjk@theqtcompany.com> Reviewed-by:
Christian Stenger <christian.stenger@theqtcompany.com>
Showing
- share/qtcreator/debugger/lldbbridge.py 5 additions, 3 deletionsshare/qtcreator/debugger/lldbbridge.py
- src/plugins/debugger/cdb/cdbengine.cpp 1 addition, 1 deletionsrc/plugins/debugger/cdb/cdbengine.cpp
- src/plugins/debugger/cdb/cdbengine.h 1 addition, 1 deletionsrc/plugins/debugger/cdb/cdbengine.h
- src/plugins/debugger/debuggerengine.cpp 36 additions, 13 deletionssrc/plugins/debugger/debuggerengine.cpp
- src/plugins/debugger/debuggerengine.h 16 additions, 5 deletionssrc/plugins/debugger/debuggerengine.h
- src/plugins/debugger/debuggertooltipmanager.cpp 3 additions, 2 deletionssrc/plugins/debugger/debuggertooltipmanager.cpp
- src/plugins/debugger/gdb/gdbengine.cpp 2 additions, 34 deletionssrc/plugins/debugger/gdb/gdbengine.cpp
- src/plugins/debugger/gdb/gdbengine.h 2 additions, 5 deletionssrc/plugins/debugger/gdb/gdbengine.h
- src/plugins/debugger/lldb/lldbengine.cpp 3 additions, 25 deletionssrc/plugins/debugger/lldb/lldbengine.cpp
- src/plugins/debugger/lldb/lldbengine.h 2 additions, 4 deletionssrc/plugins/debugger/lldb/lldbengine.h
- src/plugins/debugger/pdb/pdbengine.cpp 4 additions, 11 deletionssrc/plugins/debugger/pdb/pdbengine.cpp
- src/plugins/debugger/pdb/pdbengine.h 2 additions, 2 deletionssrc/plugins/debugger/pdb/pdbengine.h
- src/plugins/debugger/qml/qmlcppengine.cpp 10 additions, 11 deletionssrc/plugins/debugger/qml/qmlcppengine.cpp
- src/plugins/debugger/qml/qmlcppengine.h 3 additions, 3 deletionssrc/plugins/debugger/qml/qmlcppengine.h
- src/plugins/debugger/qml/qmlengine.cpp 5 additions, 5 deletionssrc/plugins/debugger/qml/qmlengine.cpp
- src/plugins/debugger/qml/qmlengine.h 3 additions, 6 deletionssrc/plugins/debugger/qml/qmlengine.h
- src/plugins/debugger/watchhandler.cpp 4 additions, 4 deletionssrc/plugins/debugger/watchhandler.cpp
- src/plugins/debugger/watchhandler.h 0 additions, 9 deletionssrc/plugins/debugger/watchhandler.h
- src/plugins/debugger/watchwindow.cpp 1 addition, 1 deletionsrc/plugins/debugger/watchwindow.cpp
Loading
Please register or sign in to comment