Wizards: Do not crash when adding files to existing project
Do not crash when adding a file to an existing project that finishes
parsing while the wizard is still open.
Make sure the Node that is passed into the wizard is still valid after
parsing. Provide more information to the wizard so that this can be
checked -- and to find the similar node in the new project tree.
Also avoid a crash when adding existing files.
Do not crash when project parsing finishes while the wizard
summary page is open.
Do not crash when the project gets closed while the summary page
is open.
Do not have the ProjectTree send signals about subTreeChanges if
the node that changed is not part of the ProjectTree. This avoids
an infinite loop when updating the combobox on the summary page.
Add a treeChanged signal to ProjectTree.
Task-number: QTCREATORBUG-18651
Change-Id: Iaed3d0d1f079c09e54389821a11bda596139f35c
Reviewed-by:
Eike Ziller <eike.ziller@qt.io>
Showing
- src/plugins/projectexplorer/jsonwizard/jsonsummarypage.cpp 32 additions, 4 deletionssrc/plugins/projectexplorer/jsonwizard/jsonsummarypage.cpp
- src/plugins/projectexplorer/jsonwizard/jsonsummarypage.h 2 additions, 0 deletionssrc/plugins/projectexplorer/jsonwizard/jsonsummarypage.h
- src/plugins/projectexplorer/projectexplorer.cpp 11 additions, 5 deletionssrc/plugins/projectexplorer/projectexplorer.cpp
- src/plugins/projectexplorer/projectexplorerconstants.h 2 additions, 0 deletionssrc/plugins/projectexplorer/projectexplorerconstants.h
- src/plugins/projectexplorer/projectfilewizardextension.cpp 30 additions, 3 deletionssrc/plugins/projectexplorer/projectfilewizardextension.cpp
- src/plugins/projectexplorer/projectfilewizardextension.h 3 additions, 0 deletionssrc/plugins/projectexplorer/projectfilewizardextension.h
- src/plugins/projectexplorer/projecttree.cpp 14 additions, 1 deletionsrc/plugins/projectexplorer/projecttree.cpp
- src/plugins/projectexplorer/projecttree.h 5 additions, 0 deletionssrc/plugins/projectexplorer/projecttree.h
Loading
Please register or sign in to comment