Commit 9417bea9 authored by Orgad Shaneh's avatar Orgad Shaneh Committed by Tobias Hunger
Browse files

VCS: Remove superfluous virtual



Change-Id: I105057202091f4b90f7f50eefb3506ee56d4bc1b
Reviewed-by: default avatarTobias Hunger <tobias.hunger@digia.com>
parent df5cd3d6
......@@ -42,7 +42,7 @@ public:
QTextDocument *document = 0);
private:
virtual QString changeNumber(const QString &block) const;
QString changeNumber(const QString &block) const;
mutable QRegExp m_changeset;
};
......
......@@ -61,7 +61,7 @@ class BazaarSubmitHighlighter : QSyntaxHighlighter
{
public:
explicit BazaarSubmitHighlighter(QTextEdit *parent);
virtual void highlightBlock(const QString &text);
void highlightBlock(const QString &text);
private:
enum State { Header, Comment, Other };
......
......@@ -66,7 +66,7 @@ public:
QStringList vcsSnapshots(const QString &topLevel);
bool vcsRestoreSnapshot(const QString &topLevel, const QString &name);
bool vcsRemoveSnapshot(const QString &topLevel, const QString &name);
virtual bool vcsAnnotate(const QString &file, int line);
bool vcsAnnotate(const QString &file, int line);
public slots:
// To be connected to the VCSTask's success signal to emit the repository/
......
......@@ -44,11 +44,11 @@ public:
explicit BazaarEditor(const VcsBase::VcsBaseEditorParameters *type, QWidget *parent);
private:
virtual QSet<QString> annotationChanges() const;
virtual QString changeUnderCursor(const QTextCursor &cursor) const;
virtual VcsBase::DiffHighlighter *createDiffHighlighter() const;
virtual VcsBase::BaseAnnotationHighlighter *createAnnotationHighlighter(const QSet<QString> &changes, const QColor &bg) const;
virtual QString fileNameFromDiffSpecification(const QTextBlock &diffFileSpec) const;
QSet<QString> annotationChanges() const;
QString changeUnderCursor(const QTextCursor &cursor) const;
VcsBase::DiffHighlighter *createDiffHighlighter() const;
VcsBase::BaseAnnotationHighlighter *createAnnotationHighlighter(const QSet<QString> &changes, const QColor &bg) const;
QString fileNameFromDiffSpecification(const QTextBlock &diffFileSpec) const;
mutable QRegExp m_changesetId;
mutable QRegExp m_exactChangesetId;
......
......@@ -80,7 +80,7 @@ class BazaarPlugin : public VcsBase::VcsBasePlugin
public:
BazaarPlugin();
virtual ~BazaarPlugin();
~BazaarPlugin();
bool initialize(const QStringList &arguments, QString *errorMessage);
static BazaarPlugin *instance();
......
......@@ -45,7 +45,7 @@ public:
QTextDocument *document = 0);
private:
virtual QString changeNumber(const QString &block) const;
QString changeNumber(const QString &block) const;
const QChar m_separator;
};
......
......@@ -55,7 +55,7 @@ public:
void setIsUcm(bool isUcm);
protected:
virtual QByteArray fileContents() const;
QByteArray fileContents() const;
};
......
......@@ -77,7 +77,7 @@ public:
CvsPlugin();
~CvsPlugin();
virtual bool initialize(const QStringList &arguments, QString *errorMessage);
bool initialize(const QStringList &arguments, QString *errorMessage);
void cvsDiff(const QString &workingDir, const QStringList &files);
......@@ -125,8 +125,8 @@ private slots:
void cvsDiff(const Cvs::Internal::CvsDiffParameters &p);
protected:
virtual void updateActions(VcsBase::VcsBasePlugin::ActionState);
virtual bool submitEditorAboutToClose(VcsBase::VcsBaseSubmitEditor *submitEditor);
void updateActions(VcsBase::VcsBasePlugin::ActionState);
bool submitEditorAboutToClose(VcsBase::VcsBaseSubmitEditor *submitEditor);
private:
bool isCommitEditorOpen() const;
......
......@@ -44,7 +44,7 @@ public:
QTextDocument *document = 0);
private:
virtual QString changeNumber(const QString &block) const;
QString changeNumber(const QString &block) const;
const QChar m_blank;
};
......
......@@ -42,15 +42,15 @@ public:
explicit CloneWizard(QObject *parent = 0);
// IWizard
virtual QIcon icon() const;
virtual QString description() const;
virtual QString displayName() const;
QIcon icon() const;
QString description() const;
QString displayName() const;
protected:
// BaseCheckoutWizard
virtual QList<QWizardPage*> createParameterPages(const QString &path);
virtual QSharedPointer<VcsBase::AbstractCheckoutJob> createJob(const QList<QWizardPage*> &parameterPages,
QString *checkoutPath);
QList<QWizardPage*> createParameterPages(const QString &path);
QSharedPointer<VcsBase::AbstractCheckoutJob> createJob(const QList<QWizardPage*> &parameterPages,
QString *checkoutPath);
};
} // namespace Internal
......
......@@ -49,13 +49,13 @@ class CloneWizardPage : public VcsBase::BaseCheckoutWizardPage
Q_PROPERTY(bool deleteMasterBranch READ deleteMasterBranch WRITE setDeleteMasterBranch)
public:
explicit CloneWizardPage(QWidget *parent = 0);
virtual ~CloneWizardPage();
~CloneWizardPage();
QSharedPointer<VcsBase::AbstractCheckoutJob> createCheckoutJob(QString *checkoutPath) const;
protected:
virtual QString directoryFromRepository(const QString &r) const;
virtual QStringList branches(const QString &repository, int *current);
QString directoryFromRepository(const QString &r) const;
QStringList branches(const QString &repository, int *current);
bool deleteMasterBranch() const;
void setDeleteMasterBranch(bool v);
......
......@@ -53,7 +53,7 @@ namespace Internal {
class GitoriousCloneWizardPage : public Git::CloneWizardPage {
public:
explicit GitoriousCloneWizardPage(const GitoriousRepositoryWizardPage *rp, QWidget *parent = 0);
virtual void initializePage();
void initializePage();
private:
const GitoriousRepositoryWizardPage *m_repositoryPage;
......
......@@ -44,15 +44,15 @@ public:
explicit GitoriousCloneWizard(QObject *parent = 0);
// IWizard
virtual QIcon icon() const;
virtual QString description() const;
virtual QString displayName() const;
QIcon icon() const;
QString description() const;
QString displayName() const;
protected:
// BaseCheckoutWizard
virtual QList<QWizardPage*> createParameterPages(const QString &path);
virtual QSharedPointer<VcsBase::AbstractCheckoutJob> createJob(const QList<QWizardPage*> &parameterPages,
QString *checkoutPath);
QList<QWizardPage*> createParameterPages(const QString &path);
QSharedPointer<VcsBase::AbstractCheckoutJob> createJob(const QList<QWizardPage*> &parameterPages,
QString *checkoutPath);
};
} // namespace Internal
......
......@@ -43,9 +43,9 @@ class GitoriousHostWizardPage : public QWizardPage {
Q_OBJECT
public:
GitoriousHostWizardPage(QWidget *parent = 0);
virtual ~GitoriousHostWizardPage();
~GitoriousHostWizardPage();
virtual bool isComplete() const;
bool isComplete() const;
int selectedHostIndex() const;
......
......@@ -63,7 +63,7 @@ public:
QWidget *parent = 0);
~GitoriousProjectWidget();
virtual bool isValid() const;
bool isValid() const;
QSharedPointer<GitoriousProject> project() const;
......
......@@ -61,8 +61,8 @@ public:
explicit GitoriousProjectWizardPage(const GitoriousHostWizardPage *hostPage,
QWidget *parent = 0);
virtual void initializePage();
virtual bool isComplete() const;
void initializePage();
bool isComplete() const;
QSharedPointer<GitoriousProject> project() const;
int selectedHostIndex() const;
......
......@@ -58,8 +58,8 @@ public:
QWidget *parent = 0);
~GitoriousRepositoryWizardPage();
virtual void initializePage();
virtual bool isComplete() const;
void initializePage();
bool isComplete() const;
QString repositoryName() const;
QUrl repositoryURL() const;
......
......@@ -91,7 +91,7 @@ public:
static GitPlugin *instance();
virtual bool initialize(const QStringList &arguments, QString *errorMessage);
bool initialize(const QStringList &arguments, QString *errorMessage);
GitVersionControl *gitVersionControl() const;
......@@ -141,8 +141,8 @@ private slots:
void testStatusParsing();
#endif
protected:
virtual void updateActions(VcsBase::VcsBasePlugin::ActionState);
virtual bool submitEditorAboutToClose(VcsBase::VcsBaseSubmitEditor *submitEditor);
void updateActions(VcsBase::VcsBasePlugin::ActionState);
bool submitEditorAboutToClose(VcsBase::VcsBaseSubmitEditor *submitEditor);
private:
inline ParameterActionCommandPair
......
......@@ -51,7 +51,7 @@ public:
GitSubmitFileModel(QObject *parent = 0) : VcsBase::SubmitFileModel(parent)
{ }
virtual void updateSelections(SubmitFileModel *source)
void updateSelections(SubmitFileModel *source)
{
int j = 0;
for (int i = 0; i < rowCount() && j < source->rowCount(); ++i) {
......
......@@ -61,7 +61,7 @@ static QTextCharFormat commentFormat()
class GitSubmitHighlighter : QSyntaxHighlighter {
public:
explicit GitSubmitHighlighter(QTextEdit *parent);
virtual void highlightBlock(const QString &text);
void highlightBlock(const QString &text);
private:
enum State { Header, Comment, Other };
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment