Skip to content
Snippets Groups Projects
Commit cb66d1ec authored by Tobias Nätterlund's avatar Tobias Nätterlund Committed by Tobias Nätterlund
Browse files

BlackBerry: Fixed running when only QML debugging is selected


The -debugNative parameter should only be passed to blackberry-deploy
when C++ debugging is enabled.

Task-number: QTCREATORBUG-11460
Change-Id: I3dba64bb57211f1c6d6b972e8afe5fa77451fb7c
Reviewed-by: default avatarMehdi Fekari <mfekari@blackberry.com>
Reviewed-by: default avatarFanda Vacek <fvacek@blackberry.com>
Reviewed-by: default avatarNicolas Arnaud-Cormos <nicolas@kdab.com>
parent 7954c19d
No related branches found
No related tags found
No related merge requests found
......@@ -57,9 +57,9 @@ using namespace ProjectExplorer;
using namespace Qnx;
using namespace Qnx::Internal;
BlackBerryApplicationRunner::BlackBerryApplicationRunner(bool debugMode, BlackBerryRunConfiguration *runConfiguration, QObject *parent)
BlackBerryApplicationRunner::BlackBerryApplicationRunner(bool cppDebugMode, BlackBerryRunConfiguration *runConfiguration, QObject *parent)
: QObject(parent)
, m_debugMode(debugMode)
, m_cppDebugMode(cppDebugMode)
, m_pid(-1)
, m_appId(QString())
, m_running(false)
......@@ -246,7 +246,7 @@ void BlackBerryApplicationRunner::launchApplication()
QStringList args;
args << QLatin1String("-launchApp");
if (m_debugMode)
if (m_cppDebugMode)
args << QLatin1String("-debugNative");
args << QLatin1String("-device") << m_sshParams.host;
if (!m_sshParams.password.isEmpty())
......
......@@ -56,7 +56,7 @@ class BlackBerryApplicationRunner : public QObject
{
Q_OBJECT
public:
explicit BlackBerryApplicationRunner(bool debugMode, BlackBerryRunConfiguration *runConfiguration, QObject *parent = 0);
explicit BlackBerryApplicationRunner(bool cppDebugMode, BlackBerryRunConfiguration *runConfiguration, QObject *parent = 0);
bool isRunning() const;
qint64 pid() const;
......@@ -96,7 +96,7 @@ private slots:
private:
void reset();
bool m_debugMode;
bool m_cppDebugMode;
qint64 m_pid;
QString m_appId;
......
......@@ -44,7 +44,8 @@ BlackBerryDebugSupport::BlackBerryDebugSupport(BlackBerryRunConfiguration *runCo
: QObject(runControl->engine())
, m_engine(runControl->engine())
{
m_runner = new BlackBerryApplicationRunner(true, runConfig, this);
const bool cppDebugMode = m_engine->startParameters().languages & Debugger::CppLanguage;
m_runner = new BlackBerryApplicationRunner(cppDebugMode, runConfig, this);
connect(m_engine, SIGNAL(requestRemoteSetup()), this, SLOT(launchRemoteApplication()));
connect(m_engine, SIGNAL(stateChanged(Debugger::DebuggerState)),
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment