Use double click on double click platforms.

Change-Id: I4ad6436dd56f370961db6a4bb8fcf788bd0cd579
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

The QMakeEvaluator uses it's own more accurate version of
isAbsolutePath. If we pass in a path that qt thinks is
absolute, e.g. "C:dev", but the qmake evaluator disagrees,
creator crashes. Import these functions from the qmake
evaluator into Utils::FileUtils and use them to prepare
the builddirectory.

Task-number: QTCREATORBUG-12034
Change-Id: Ida28688558f3186db25e3ab73bd39cabc91c1ff0
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I2646a2c30573417ba9da4b57b100d33144cef349
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

We only checked for ApplicationWindow. Instead of ApplicationWindow
we have to check for Window. ApplicationWindow is derived from Window.

Change-Id: I5d287af4284e31dcd77e06b498c5ae61dc348ad6
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

Change-Id: I01c66fbd8db4f810d691152c687d5775e250b1a9
Reviewed-by: Marco Bubke <marco.bubke@digia.com>

Change-Id: I287c0b7acb32d391080a57792740b3316a87c64d
Reviewed-by: BogDan Vatra <bogdan@kde.org>

This is a regression, the editor was not recognized as being
a disassembly view anymore.

Change-Id: I281ecf0a49bb4e365b252793f6a5aa89f7b432ff
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Handle the case where the output doesn't end in ====

Change-Id: Ia37f64259c3cae9a016d854dc1b056d9a4459a62
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Use double click activation on double click platforms and fix keyboard
activation.

Change-Id: I5a36439bb333646f676a78000dfb2570faf3fb1c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Slightly fixes the keyboard handling.

Change-Id: Ifd7f19012457fb6d8e29f511cf63566db6093665
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Open the change in a browser on Return/Enter

Change-Id: I6ed6d832e3bebf625adb3765415929cc0670d4e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I8ad4991b17e2cf60e73278db13c0ac403e35807c
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Change-Id: I3b5ea968732cf3b69d37e6bc4c0bd514be1ceb05
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Since it takes effect immediately.

Task-number: QTCREATORBUG-11994
Change-Id: I48d322195ac62036c4e6fabc61b57a434cbdb495
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: BogDan Vatra <bogdan@kde.org>

Task-number: QTCREATORBUG-12009
Change-Id: Ia8bded2e4c84b3fedca2f0a64a487cd1760e07d5
Reviewed-by: BogDan Vatra <bogdan@kde.org>

QMake's behavior for .pri files otherwise treats those paths as relative
to the .pro file. That's rarely what you want.

Also change the remove code to handle those files.

Change-Id: I5fe95035b470c32c365adbdee161f4a6cae05c2b
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>

The WinRT xmkspecs detection was broken by this patch.

This reverts commit 8095a212.

Change-Id: I6bc1b2dc2e090c6e7bd0cfa1894b678083a1d107
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@digia.com>
Reviewed-by: David Schulz <david.schulz@digia.com>

qt4 qmake does not like spaces between 'for' and the opening paren.

Task-number: QTCREATORBUG-12024
Change-Id: I8697272b4f752495f3bf6ff2c6d01c4ac2ea837f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

After doing this once, the active file tags were not reset, so
building everything was no longer possible.

Change-Id: I98df5f55e129cc4a72921aff51201e1860ba939a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>

The context is stateful and there could be any kind of junk left in it.
In particular, the W3C spec says that it should be set up with a default
clipping path on creation, but it doesn't say what should happen if the
canvas is resized. Thus, we can never be sure that the clipping path is
sane.

Task-number: QTBUG-38297
Change-Id: If04597234e71574573888ce14deac5cf50df4a3f
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>

Addresses the following findings of QTCREATORBUG-12030:
 * qtc.helgrind.plugintests.txt#2
 * qtc.helgrind.usingEditors1.txt#1

Helgrind report (truncated):

Possible data race during write of size 4 at 0x23679618 by thread #1
Locks held: none
   at 0x6819003: ???
   by 0x681D713: ???
   by 0x68200DE: ???
   by 0x684B8F8: QTextCursor::insertText(QString const&, QTextCharFormat const&)
   by 0x684BCB9: QTextCursor::insertText(QString const&)
   by 0x139DA06C: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1866)
   by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)

This conflicts with a previous read of size 4 by thread #18
Locks held: none
   at 0x680BC54: QTextDocument::revision() const
   by 0x159047F3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
   by 0x158E39BF: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
   by 0x158E3D5B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
   by 0x1589FF6F: CppTools::Internal::CppCompletionAssistInterface::getCppSpecifics() const (cppcompletionassist.cpp:1957)
   by 0x158A1158: CppTools::Internal::CppCompletionAssistInterface::snapshot() const (cppcompletionassist.h:200)
   by 0x1589707C: CppTools::Internal::CppCompletionAssistProcessor::startCompletionInternal(QString, unsigned int, unsigned int, QString const&, int) (cppcompletionassist.cpp:1212)
   by 0x15893CC7: CppTools::Internal::CppCompletionAssistProcessor::startCompletionHelper() (cppcompletionassist.cpp:970)

---

Possible data race during write of size 4 at 0x24C8AD18 by thread #1
Locks held: none
   at 0x684AF23: QTextCursor::beginEditBlock()
   by 0x139D7D05: TextEditor::BaseTextEditorWidget::keyPressEvent(QKeyEvent*) (basetexteditor.cpp:1578)
   by 0x184C999F: CppEditor::Internal::CPPEditorWidget::keyPressEvent(QKeyEvent*) (cppeditor.cpp:1416)
   ...
   by 0x40F15A: main (main.cpp:533)

This conflicts with a previous read of size 4 by thread #11
Locks held: none
   at 0x680BC54: QTextDocument::revision() const
   by 0x159048D3: CppTools::CppEditorSupport::editorRevision() const (cpptoolseditorsupport.cpp:198)
   by 0x158E3A9F: CppTools::Internal::CppModelManager::buildWorkingCopyList() (cppmodelmanager.cpp:525)
   by 0x158E3E3B: CppTools::Internal::CppModelManager::workingCopy() const (cppmodelmanager.cpp:544)
   by 0x1590741E: parse(QFutureInterface<void>&, QSharedPointer<CppTools::SnapshotUpdater>) (cpptoolseditorsupport.cpp:299)

Task-number: QTCREATORBUG-12030
Change-Id: Idf0aa47f1f6bfd6814a961fe39d3b19b98f934f5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

The optimization in question could lead to an empty source and thus to
no highlighting. Checking for 'force' and the revisions is at this point
not enough since later the semantic info calculcation can be aborted, so
that a subsequent recalculation would get an empty document.

contents() itself is already optimized (uses caching).

Task-number: QTCREATORBUG-11367
Change-Id: If31a8ab0c848e4babd38104961fb9812f077a2be
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

...when collecting data for the semantic highlighting recalculation.

Task-number: QTCREATORBUG-11037

Change-Id: Ibed73a2916df0a91aedef166de2c8c6bb5df309c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

Change-Id: Icf30cf6683f5cc04f3801465148d95bed2002a4a
Reviewed-by: David Schulz <david.schulz@digia.com>

Change-Id: I0c2096020ad102a836bf06ce8db0428ccf8fb805
Reviewed-by: David Schulz <david.schulz@digia.com>

it takes a variable, not a value.

the spec_pre.prf part is cherry-picked from qtbase/89a558d6b0fac.

Change-Id: Ie7e551cf0b889d7682f032124dd0466ada6972e4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Should not change any behavior.

Change-Id: Ibe3ac32aea4c25f8752c83dd711eceb1ccd19f23
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>

Use double click on double click platforms, fix keyboard activation

Change-Id: I36891fb2f733684a1a5c3787e0682cb9ddccb0d3
Reviewed-by: Ulf Hermann <ulf.hermann@digia.com>

Change-Id: I9b98ddc6f3efdf8d16a373fa6e3d92480c8629d6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

Task-number: QTCREATORBUG-11367
Change-Id: I8b02c30a43a57c547bc07d796f4b29725beca793
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
Reviewed-by: Eike Ziller <eike.ziller@digia.com>

... and fix typo

Change-Id: I4010dd6dbf56121b973320152ff518bf11d26ede
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Change-Id: I58b6e9e9b100ba466f9cc2f20416b208e1636829
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Makes the class even simpler. Those constructors don't do anything.

Change-Id: Ifb255047de966ebd950b874b82ec86caacbbbbc8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

None of the callers need anything beyond ::map.clear()

Change-Id: I8296d04019f58e0c2fceb672a0e717146b91c1a7
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ie92d142ef92a597ed9174ebfd54b645618e1bed6
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Ie73a6c433f52f71edde6f0670956c6b72405e2f1
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Also rename it into Settings.

Change-Id: Id01f664b0cac4de58ffe52eea1aeeaf9cf0891d5
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: Iba22b820ce5b671a924757d5a24900e20f8c46ae
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

Change-Id: I934622c2cf993255d92550731a2cd186943d697b
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>

Use m_editorProject and m_editorNode where possible instead of going through
the current editor, its document and the nodes.

Change-Id: I252cedccf71a3c9884d0202aae394c42a5e96014
Reviewed-by: Daniel Teske <daniel.teske@digia.com>