- 20 Jul, 2015 2 commits
-
-
Nikolai Kosjar authored
It compared pointers, not ids. Change-Id: Ic77c64e452f8abfe9a35b74591f0f3baeebcf7f0 Reviewed-by:
Marco Bubke <marco.bubke@theqtcompany.com>
-
Nikolai Kosjar authored
File paths are not unique since e.g. each qbs group in a file is mapped to a project part. Change-Id: I7df3f224dd23046b869f2588b8a34eb26cfc0b1a Reviewed-by:
Marco Bubke <marco.bubke@theqtcompany.com>
-
- 08 Jul, 2015 1 commit
-
-
Nikolai Kosjar authored
Needed for ClangCodeModel. If the content changes, we want to send it immediately to the codemodelbackend process. Change-Id: Iedf16930b494ccb5e91f1bc435db026067d98613 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com> Reviewed-by:
Daniel Teske <daniel.teske@theqtcompany.com>
-
- 24 Jun, 2015 1 commit
-
-
Nikolai Kosjar authored
Quitting Qt Creator before the project was loaded from the project manager triggers the assert because the updateProjectInfo() call was not yet made by the project manager. Change-Id: I23c660971e48d007d1bae00ecf8ed5c2ad3d4071 Reviewed-by:
Christian Stenger <christian.stenger@theqtcompany.com> Reviewed-by:
Marco Bubke <marco.bubke@theqtcompany.com>
-
- 10 Jun, 2015 1 commit
-
-
Nikolai Kosjar authored
This makes us independent of libclang crashes for completion. Re-parsing for highlighting still happens in the Qt Creator process. Run in verbose mode: qtc.clangcodemodel.ipc=true Run tests: -test "ClangCodeModel" Task-number: QTCREATORBUG-14108 Task-number: QTCREATORBUG-12819 Change-Id: Id3e95bd2afdb6508bbd1d35fddc69534a909b905 Reviewed-by:
Marco Bubke <marco.bubke@theqtcompany.com>
-
- 13 May, 2015 1 commit
-
-
Nikolai Kosjar authored
...with the environment variable QTC_CPP_FILE_SIZE_LIMIT_MB. Task-number: QTCREATORBUG-14390 Change-Id: Iaefaa1a3db023b58f9351b96e1b9e2139797e280 Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
- 24 Apr, 2015 1 commit
-
-
Nikolai Kosjar authored
For indexing we used a custom revision that was updated on each modelManager BuiltinIndexingSupport::refreshSourceFiles() call. This could lead to rejection of updated documents triggered by refactoring actions, like for the following case: 1. Open a project containing a.h and a.cpp 2. Open a.cpp, insert some new lines, save and close the document 3. Open a.h and rename a function that is defined in a.cpp --> The refactoring action modifies a.h and a.cpp, so re-indexing of those is triggered. Since a.cpp has already a higher revision (step 2) than the updated document, the updated document is discarded. As a consequence find usages and follow symbol fails for the renamed function. Now the document call back provided to CppSourceProcessor is responsible for updating the document revision based on the latest revision in the global snapshot. Change-Id: I4dfa0a4d34991655acfa749109f00c47b0fbfdbe Reviewed-by:
Orgad Shaneh <orgads@gmail.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com> Reviewed-by:
Eike Ziller <eike.ziller@theqtcompany.com>
-
- 07 Apr, 2015 1 commit
-
-
Nikolai Kosjar authored
When the configuration (defines and includes dirs) did not change, we only updated the m_projectToProjectsInfo data structure, but not the others (m_projectFileToProjectPart, m_fileToProjectParts). Change-Id: I0ca235ea4bbe4556bd8b6d36897dedd6482f86a0 Reviewed-by:
Christian Stenger <christian.stenger@theqtcompany.com>
-
- 05 Mar, 2015 1 commit
-
-
Friedemann Kleint authored
Change-Id: I0144ac33e88980c431c54a6d69bbde28da4b1967 Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
- 27 Feb, 2015 1 commit
-
-
Nikolai Kosjar authored
These operators led to parse errors, most prominently in Q_OBJECT uses since this macro nowdays uses these operators. Task-number: QTCREATORBUG-13905 Change-Id: I65632820d02ca5c5ef0b98f5d969cdc516d7f5b0 Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
- 26 Feb, 2015 1 commit
-
-
Friedemann Kleint authored
Change-Id: I1e7dd34ba5a51fb0b34d137dc03add4457b32ed1 Reviewed-by:
Orgad Shaneh <orgads@gmail.com>
-
- 20 Feb, 2015 1 commit
-
-
Orgad Shaneh authored
Task-number: QTCREATORBUG-8007 Change-Id: Ic96aaa433442812a99bac9d16bb9124d66762e8c Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
-
- 04 Feb, 2015 1 commit
-
-
Orgad Shaneh authored
Mostly done using the following ruby script: Dir.glob('**/*.cpp').each { |file| next if file =~ %r{src/shared/qbs|/qmljs/} s = File.read(file) s.scan(/^using namespace (.*);$/) { ns = $1 t = s.gsub(/^(.*)\b#{ns}::((?!Const)[A-Z])/) { |m| before = $1 char = $2 if before =~ /"|\/\/|\\|using|SIGNAL|SLOT|Q_/ m else before + char end } if t != s puts file File.open(file, 'w').write(t) end } } Change-Id: I6fbe13ddc1485efe95c3156097bf41d90c0febac Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
-
- 16 Jan, 2015 1 commit
-
-
Eike Ziller authored
Change-Id: I711d5fb475ef814a1dc9d2822740e827f3f67125 Reviewed-by:
Alessandro Portale <alessandro.portale@digia.com>
-
- 14 Jan, 2015 1 commit
-
-
Nikolai Kosjar authored
...and related functions. For clarity in client code. Change-Id: Icad6fc7b1eee2ce46a2eba8435359837a23409c8 Reviewed-by:
Orgad Shaneh <orgads@gmail.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
- 12 Jan, 2015 1 commit
-
-
Orgad Shaneh authored
Change-Id: I85f7398aee59d0d36f0e5c3bf88ff3c96002e394 Reviewed-by:
Eike Ziller <eike.ziller@theqtcompany.com>
-
- 19 Dec, 2014 1 commit
-
-
Nikolai Kosjar authored
...instead of going through CppModelManager::projectInfo(). Now CppModelManager::projectInfo() returns an invalid ProjectInfo in case there is no valid data for the given Project. Change-Id: I11908bf2ddf865b1d3d71ff176eaf4139292b21c Reviewed-by:
Christian Kandeler <christian.kandeler@theqtcompany.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
- 18 Dec, 2014 1 commit
-
-
Erik Verbruggen authored
... by keying on Utils::FileName. Task-number: QTCREATORBUG-12390 Change-Id: Ib99eefcf3440d4383f624a614a3093f427efffbd Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
-
- 17 Dec, 2014 1 commit
-
-
Erik Verbruggen authored
... by keying on Utils::FileName Task-number: QTCREATORBUG-12390 Change-Id: Ia98afb5a9160a7fd9225a2f9e02539ff3c35ae86 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
-
- 15 Dec, 2014 1 commit
-
-
Nikolai Kosjar authored
...since this will confuse the completer. Task-number: QTCREATORBUG-13567 Change-Id: I4172d433f23f3907690d4c00f92fadb68fa354e8 Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com> Reviewed-by:
Eike Ziller <eike.ziller@theqtcompany.com>
-
- 03 Dec, 2014 2 commits
-
-
Nikolai Kosjar authored
This fixes SOFT ASSERT: "!filePath.isEmpty()" in file /home/nik/dev/creator/creator-ut/src/plugins/cpptools/cppmodelmanager.cpp, line 467 which can be triggered by e.g. a "git show" document (onCurrentEditorChanged does not check for an empty file path). Change-Id: If4ed8e552069b290cb4ac93da52427b7ed2b91e8 Reviewed-by:
Eike Ziller <eike.ziller@theqtcompany.com>
-
Nikolai Kosjar authored
...if the project was updated in the meanwhile. If a project is updated mark invisible editor documents dirty and update them if they get focus. This also fixes document highlighting when restoring a session for documents that the user "switched away" before the project info is pushed to CppModelManager. This completes CppTools: Update visible documents on project update commit c2eb91e0 which only takes care of visible documents. Task-number: QTCREATORBUG-13270 Change-Id: Id445e7f509deac5d03194aecc54ce4629b7926ce Reviewed-by:
Erik Verbruggen <erik.verbruggen@theqtcompany.com>
-
- 24 Nov, 2014 1 commit
-
-
Nikolai Kosjar authored
A DiffEditorDocument has an empty file path. Change-Id: If097497514afa82b1ed220a37cae410f4a81aa9a Task-number: QTCREATORBUG-13489 Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
-
- 07 Nov, 2014 1 commit
-
-
Nikolai Kosjar authored
...and make some comparison functions public. Change-Id: If4c9a95031dece32073ce111484a890230190688 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@theqtcompany.com>
-
- 23 Oct, 2014 1 commit
-
-
Francois Ferrand authored
The messages were computed, but not added to the document. Change-Id: Ibeea802cf9f291ad14b2fe2e9d2a285c927a4449 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
-
- 21 Oct, 2014 1 commit
-
-
Nikolai Kosjar authored
Superseded by commit commit 89bd4ee3 C++: Base parsing on editor document instead of widget Change-Id: Iffa6e47bddc0fa3de1eab9b65fe8f711520d2d7f Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 15 Oct, 2014 2 commits
-
-
Nikolai Kosjar authored
projectPartFromDependencies() is also called from another thread. Change-Id: Ic1319569d1b9b934a1be0916caa2e5bd68dce4fb Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
Nikolai Kosjar authored
With asynchron project managers, creating a new project from a wizard or re-opening a session will first open the editor documents and then provide the project information later (it's the other way around with synchronous project managers). This sequence leave the documents with various error diagnostics behind. Fixed by re-triggering the re-parsing. This change does not fix QTCREATORBUG-11606 yet. Though it will trigger a reparse with the right includes, clang still reports 'file not found'. Will be addressed by a follow-up patch. Task-number: QTCREATORBUG-11606 Change-Id: Ib5d251e05accf4268f9b36decc5224b2c75f610c Reviewed-by:
Daniel Teske <daniel.teske@digia.com> Reviewed-by:
Orgad Shaneh <orgads@gmail.com> Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@digia.com>
-
- 09 Oct, 2014 1 commit
-
-
Eike Ziller authored
Change-Id: I3c22ef2685d7aa589f5d0ab74d693653a4c32082 Reviewed-by:
Alessandro Portale <alessandro.portale@digia.com>
-
- 06 Oct, 2014 1 commit
-
-
Nikolai Kosjar authored
For the time being, this function actually sets an additional CppIndexSupport to be executed. Handle the case that a client tries to restore the previous CppIndexingSupport (see SymbolSearcherTestCase). This fixes GenericProjectManager::test_simple in interaction with CppTools::test_builtinsymbolsearcher. Now first running the CppTools tests and then the GenericProjectManager tests work fine. Change-Id: Ibe7248ec8651d4fdc312f10cdcc9c56d6dd086d9 Reviewed-by:
Christian Stenger <christian.stenger@digia.com>
-
- 02 Oct, 2014 1 commit
-
-
David Schulz authored
Change-Id: Ie6aaaa5d99ba3823d9d42331f45b2dcab397e1cd Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 25 Sep, 2014 1 commit
-
-
hjk authored
First step of some more 'Base' removal in TextEditor. s/Core::TextDocument/Core::BaseTextDocument/ s/TextEditor::BaseTextDocument/TextEditor::TextDocument/ Change-Id: I71ba325a2f0ad72ec9dae0d96846cbae72d326f7 Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 22 Sep, 2014 1 commit
-
-
Nikolai Kosjar authored
Change-Id: Ib910d5b4a3db4b4d2809e05b1f37acb97a6105a6 Reviewed-by:
hjk <hjk121@nokiamail.com>
-
- 19 Sep, 2014 3 commits
-
-
hjk authored
Replace the CppModelManagerInterface/derived CppModelManager combo by a more common CppModelManager/CppModelManagerPrivate pimpl pattern. Change-Id: Ia4582845ed94d5ef60b8571bab9b2260c6290287 Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
Orgad Shaneh authored
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62224 .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppEditor::Internal::CppCodeModelInspectorDialog::refresh()': cppcodemodelinspectordialog.cpp:(.text+0x79fc): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppTools::Internal::CppModelManager::definedMacros()': cppcodemodelinspectordialog.cpp:+0x26): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppTools::Internal::CppModelManager::headerPaths()': cppcodemodelinspectordialog.cpp: +0x26): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' Change-Id: Ie0e01f7628668cbbe11b701a93caef98bb8e335f Reviewed-by:
Adam Majer <adamm@zombino.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com> (cherry picked from commit c023a1ca) Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com> Reviewed-by:
Eike Ziller <eike.ziller@digia.com>
-
hjk authored
It logically depends on the Snapshot and has a related lifetime. Keeping it in the Snapshot avoids some code compelxity. Change-Id: I24ee4483b44d9b0d7f2e4d494ae7ea624b949f9c Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 16 Sep, 2014 1 commit
-
-
Erik Verbruggen authored
.. because they now hold only files for a single language+extensions combination. Task-number: QTCREATORBUG-11709 Task-number: QTCREATORBUG-12818 Change-Id: If294f6de07d60126be733d98de12b89b8af3efce Reviewed-by:
Nikolai Kosjar <nikolai.kosjar@digia.com>
-
- 08 Sep, 2014 1 commit
-
-
Orgad Shaneh authored
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62224 .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppEditor::Internal::CppCodeModelInspectorDialog::refresh()': cppcodemodelinspectordialog.cpp:(.text+0x79fc): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppTools::Internal::CppModelManager::definedMacros()': cppcodemodelinspectordialog.cpp:+0x26): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' .obj/release-shared/cppcodemodelinspectordialog.o: In function `CppTools::Internal::CppModelManager::headerPaths()': cppcodemodelinspectordialog.cpp: +0x26): undefined reference to `CppTools::Internal::CppModelManager::ensureUpdated()' Change-Id: Ie0e01f7628668cbbe11b701a93caef98bb8e335f Reviewed-by:
Adam Majer <adamm@zombino.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 05 Sep, 2014 1 commit
-
-
Christian Stenger authored
Change-Id: I3057e3b198d566f57e991103c18ce077babcc4f0 Reviewed-by:
Erik Verbruggen <erik.verbruggen@digia.com>
-
- 04 Sep, 2014 1 commit
-
-
Erik Verbruggen authored
This eliminates a bunch of list->set->list conversions. Especially the ProjectInfo::appendProjectPart takes lots of time converting for every part added. Change-Id: Ib3c8cd4b0ad6c012ccbeed12ebedd46b9b6cca95 Reviewed-by:
Daniel Teske <daniel.teske@digia.com>
-