- Jul 19, 2012
-
-
Eike Ziller authored
Change-Id: I7134d7de30bcf9f9dcfad42520dd45ee083a852d Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
-
- Jun 25, 2012
-
-
Leandro Melo authored
Summary of most relevant items: - Preprocessor output format change. No more gen true/false. Instead a more intuitive and natural expansion (like from a real compiler) is performed directly corresponding to the macro invocation. Notice that information about the generated tokens is not lost, because it's now embedded in the expansion section header (in terms of lines and columns as explained in the code). In addition the location on where the macro expansion happens is also documented for future use. - Fix line control directives and associated token line numbers. This was not detected in tests cases because some of them were actually wrong: Within expansions the line information was being considered as originally computed in the macro definition, while the desired and expected for Creator's reporting mechanism (just like regular compilers) is the line from the expanded version of the tokens. - Do not allow for eager expansion. This was previously being done inside define directives. However, it's not allowed and might lead to incorrect results, since the argument substitution should only happen upon the macro invocation (and following nested ones). At least GCC and clang are consistent with that. See test case tst_Preprocessor:dont_eagerly_expand for a detailed explanation. - Revive the 'expanded' token flag. This is used to mark every token that originates from a macro expansion. Notice, however, that expanded tokens are not necessarily generated tokens (although every generated token is a expanded token). Expanded tokens that are not generated are those which are still considered by our code model features, since they are visible on the editor. The translation unit is smart enough to calculate line/column position for such tokens based on the information from the expansion section header. - How expansions are tracked has also changed. Now, we simply add two surrounding marker tokens to each "top-level" expansion sequence. There is an enumeration that control expansion states. Also, no "previous" token is kept around. - Preprocessor client methods suffered a change in signature so they now receive the line number of the action in question as a paramater. Previously such line could be retrieved by the client implementation by accessing the environment line. However, this is not reliable because we try to avoid synchronization of the output/environment lines in order to avoid unnecessary output, while expanding macros or handling preprocessor directives. - Although macros are not expanded during define directives (as mentioned above) the preprocessor client is now "notified" when it sees a macro. This is to allow usage tracking. - Other small stuff. This is all in one patch because the fixes are a consequence of the change in preprocessing control. Change-Id: I8f4c6e6366f37756ec65d0a93b79f72a3ac4ed50 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Jun 19, 2012
-
-
Eike Ziller authored
Change-Id: Ib938aa4999c7c418a82304c5cca2e8748ef9d228 Reviewed-by:
hjk <qthjk@ovi.com>
-
- Jun 06, 2012
-
-
Andre Hartmann authored
Works the same way as Rename Usages for C++ Symbols. For now, no Search Again as this requieres further work. Task-number: QTCREATORBUG-413 Change-Id: I09e85ea1e8c247f5ce0b6bc566aba8018c1569e4 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- Jun 05, 2012
-
-
Francois Ferrand authored
- Highlight all function/methods (not just virtual methods). - Highlight as a function even if number of arguments does not match. In that case, add a diagnostic message to indicate there are too many/too few arguments. - Fix highlighting of parameters in function declarations. These used to be handled indiferently, and they could be mistaken for type or field references. - Properly highlight template method calls. Change-Id: I6e61c9ee47763db95c62314f9cc1c4d398df38b3 Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- Jun 01, 2012
-
-
Leandro Melo authored
Make sure the environment line is consistent during preprocessor directives and identifier handling so clients can rely on consistent information. Particularly important for macro usages. New tests also added. Change-Id: I962a39a86cd17b8d945d2959c2c95e2d258ea3e6 Reviewed-by:
hjk <qthjk@ovi.com>
-
- Apr 19, 2012
-
-
hjk authored
Easier to follow. Change-Id: I6da1ca862ddb7048a6d16bf5e6ea18d6b2cfc7f8 Reviewed-by:
hjk <qthjk@ovi.com>
-
hjk authored
Change-Id: Idb93d359bd45696a38cb863dcea30c5c377eeabb Reviewed-by:
hjk <qthjk@ovi.com>
-
hjk authored
Change-Id: Ief6ea71f750b6ba19b650050bae376f4ad82d9d2 Reviewed-by:
hjk <qthjk@ovi.com>
-
hjk authored
Change-Id: I339696763b045ef1bda17dd55746738ef4ddbb67 Reviewed-by:
hjk <qthjk@ovi.com>
-
- Mar 30, 2012
-
-
Erik Verbruggen authored
When setting the environment variable QTCREATOR_DUMP_FILENAME_WHILE_PARSING, the indexer will write the file name of the file it is processing to stderr. Change-Id: Iaed582512b87fd0584feb4e459a4094be32d5745 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 29, 2012
-
-
Erik Verbruggen authored
This reverts commit e3e67467cfea5934f16a95385761455b0c495a0d Reason is that it shows errors for calls to function-like macros. For example, any use of Q_DISABLE_COPY results in invalid errors. Change-Id: I1fd1473ac5a30da5b9aebf6a3f0f11055bdbe8ad Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
Francois Ferrand authored
- Highlight all function/methods (not just virtual methods). - Highlight as a function even if number of arguments does not match. In that case, add a diagnostic message to indicate there are too many/too few arguments. - Fix highlighting of parameters in function declarations. These used to be handled indiferently, and they could be mistaken for type or field references. - Properly highlight template method calls. Change-Id: I6ab463996dda47554839f482da47f561f76663a7 Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
Erik Verbruggen authored
This rewrite fixes a couple of issues with the pre-processor. It now supports: - macros in macro bodies - stringification of parameters [cpp.stringize] - the concatenation operator [cpp.concat] - #include MACRO_HERE - defined() inside macro bodies used in pp-conditions. Change-Id: Ifdb78041fb6afadf44f939a4bd66ce2832b8601f Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 28, 2012
-
-
Erik Verbruggen authored
Change-Id: Ia3f248d013a1b4f98ad3e85d13cfcf214d3c97c7 Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Mar 27, 2012
-
-
Erik Verbruggen authored
Change-Id: I2edff4126f3504661957529c198a1fc1ea169a08 Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
- Mar 15, 2012
-
-
Erik Verbruggen authored
If the semantic highlighter does not take care of setting showing the wiggly lines for diagnostics in the editor, the model manager will do. Change-Id: Ie69fb798dd53d60ddca1668b8f586266a0daca4b Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 14, 2012
-
-
Erik Verbruggen authored
Change-Id: Iffaa18f848a22f6961b49dff048672b194570df6 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Mar 06, 2012
-
-
Robert Loehning authored
Change-Id: Id353ab140a46e06ffc3abf667ab3b234e749e17c Reviewed-by:
Oswald Buddenhagen <oswald.buddenhagen@nokia.com> Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Feb 23, 2012
-
-
Erik Verbruggen authored
When the information for a project is updated, the mapping was cleared and only recalculated for the new project info. Thereby wiping out the info for any previously added project. Change-Id: Ic6999b9be07f8cb6b4638723e6c8c7d2d3ca52e7 Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
Erik Verbruggen authored
Change-Id: I89634989a7f360a30f7ed1bde4e67c93551ddfe4 Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Feb 21, 2012
-
-
Erik Verbruggen authored
Change-Id: I480470c299f49a02d2a216d3aece81a843d73ce1 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Feb 20, 2012
-
-
Erik Verbruggen authored
Change-Id: I990fdf5411153041c6b4c62f31b453342d59de53 Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
Eike Ziller authored
And adapt the other API respectively. Change-Id: I1e04e555409be09242db6890f9e013396f83aeed Reviewed-by:
Bill King <bill.king@nokia.com> Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Feb 16, 2012
-
-
Erik Verbruggen authored
A manual squash/merge of the changes below, plus a couple of subsequent code fixes. 59085aa5fbb99e2d786cd2c1a06c24a111ccb49f: Modify CppModel::ProjectInfo Adding per project node information, to pass on the correct defines/includes for each file, instead of aggregating them incorrectly. Also split up SOURCES and OBJECTIVE_SOURCES. Also ask the toolchain to convert the compilerflags to flags the codemodel understands, for now only gcc and only c++11. Also make the toolchain aware of the flags used to compile, so that it can emit the correct defines. Note: No header files are passed on. 74028802314cd4e75b41b46407433e07090a304d: GCC: Evaluate cxxflags when checking for predefined macros ebaaa4957e4c02cc9637a998eddae1d0acd74f83: MSVC: Take cxxflags into account when checking for predefined macros 9bfce7e889bcf7bcc47bf880e3ea25945ca7d0d7: Compile fixes Change-Id: I9de94ad038dfc5dc1987732e84b13fb4419c96f5 Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
- Feb 15, 2012
-
-
Erik Verbruggen authored
Getting the #include directives ready for Qt5. This includes the new-project wizards. Change-Id: Ia9261f1e8faec06b9285b694d2b7e9a095978d2b Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Feb 13, 2012
-
-
Daniel Teske authored
The order of actions and thus the state at which the signals are emitted has changed. The aboutToUnloadSession comes before the actual saving now. Also the aboutToLoadSession is after restoring values but before restoring projects and editors. Change-Id: I3eae66cffae970f00535d8d6e2bb11a6ca645456 Reviewed-by:
hjk <qthjk@ovi.com> Reviewed-by:
Tobias Hunger <tobias.hunger@nokia.com>
-
- Feb 09, 2012
-
-
Friedemann Kleint authored
It causes a conflict with the new QtConcurrent library of Qt 5 and is quite small. Change-Id: Ib97ab6daf8f67a88300cf03f044ba3593a4cd270 Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Feb 08, 2012
-
-
Erik Verbruggen authored
This way the editor does not need to know all the details of instantiating or maintaining classes for highlighting and/or completion, it can just ask the model manager. The change also enables different highlighting- or completion-engines without changes to the cppeditor. Change-Id: I8000d9d9fe446b292defddb2295493cf77d0f14a Reviewed-by:
Leandro Melo <leandro.melo@nokia.com>
-
- Jan 31, 2012
-
-
Daniel Teske authored
That can't happen. Change-Id: I05293e96e7a716fbaf5fd03aa182c723c9858a03 Reviewed-by:
Tobias Hunger <tobias.hunger@nokia.com>
-
- Jan 26, 2012
-
-
hjk authored
Change-Id: I2b72b34c0cfeafc8bdbaf49b83ff723544f2b6e2 Reviewed-by:
Daniel Teske <daniel.teske@nokia.com>
-
- Jan 24, 2012
-
-
hjk authored
Change-Id: I9b690d9b150c8d162b15370f9f8986267c9128f1 Reviewed-by:
Daniel Teske <daniel.teske@nokia.com>
-
- Jan 13, 2012
-
-
Leandro Melo authored
Continuinng a previous commit... This is in order to make the interface clearer. Change-Id: Ic1b05217f878578bc84a064927507b75981c47d6 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com>
-
- Nov 03, 2011
-
-
hjk authored
Change-Id: If18afb5d4665924e7d9250dccbc60a65e6daa75e Reviewed-by:
Eike Ziller <eike.ziller@nokia.com>
-
- Oct 26, 2011
-
-
Erik Verbruggen authored
Task-number: QTCREATORBUG-5734 Change-Id: Ie4aa437616955fd65fcc6adbfc0e9f115caf7e1c Reviewed-by:
Friedemann Kleint <Friedemann.Kleint@nokia.com>
-
- Sep 08, 2011
-
-
Thorbjørn Lindeijer authored
__inline is equivalent to inline. __forceinline is used to override the cost/benefit analysis. Change-Id: Ifc7c94c1798f98c553ffa979a722ede9df11b3f0 Merge-request: 2206 Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com> Reviewed-on: http://codereview.qt-project.org/4416 Reviewed-by:
Leandro T. C. Melo <leandro.melo@nokia.com>
-
- Sep 06, 2011
-
-
Leandro Melo authored
This is not really a direct mapping to the Microsoft specifc ones, but I guess defining such macros is an acceptable solution. Change-Id: I17a9414364ef664f2e8afa7ececc6a87f663049e Reviewed-on: http://codereview.qt.nokia.com/4277 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Erik Verbruggen <erik.verbruggen@nokia.com>
-
Leandro Melo authored
There is logic in the preprocessor that assumes a normalized line ending. Other patches have already fixed the issue in other parts. Change-Id: Iac262da361b6528cc9466a6c87e83da95af9ea04 Reviewed-on: http://codereview.qt.nokia.com/4252 Reviewed-by:
Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by:
Christian Kamm <christian.d.kamm@nokia.com>
-
- Aug 31, 2011
-
-
Christian Kamm authored
Setting extra diagnostics would call updateDocument which would in turn trigger another scan. Change-Id: I3810a380cdf716a12767d94ff82dc30f8ae3954d Reviewed-on: http://codereview.qt.nokia.com/3917 Reviewed-by:
Roberto Raggi <roberto.raggi@nokia.com> Reviewed-by:
Leandro T. C. Melo <leandro.melo@nokia.com>
-
- Aug 30, 2011
-
-
Christian Kamm authored
Change-Id: I1e206e09c4068cc541978ee148f9ed8c4138c249 Reviewed-on: http://codereview.qt.nokia.com/3579 Reviewed-by:
Fawzi Mohamed <fawzi.mohamed@nokia.com>
-