In some transitional states we could end up without a zoomControl or a
model. Make sure we won't access it then.

Change-Id: I20b2363aae5fd860e97b393a65be20da26cec437
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: If073ef1c8f99afd07401243bd922770ca52187ae
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Name and type columns were not properly grayed out.

Change-Id: I4120329e6d8f4e6fa33859056cafd07f69b642bd
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: Ia76dce957465df49a00a831651e096e24107e864
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>

That was a recent regression: All values were red ("changed").

Change-Id: Ib77c1aefa978832aad58b06eb73778a5654998bb
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

The text next to the checkboxes needs to be elided to fit into the
menu. The filter gets reset every time we clear and reload. The
checkboxes reflect this now.

Change-Id: If34188a4abb0c087a8f585653abcf0a787fc3232
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

It does not make sense to add files to anything besides products and
groups.

Task-number: QTCREATORBUG-14286
Change-Id: Iced8cefc4eff3857e9a1a6d3a3a9311dcbb44f11
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

We hardcoded the remote host to the SSH server for some reason, and the
originating port was bogus as well.

Change-Id: I8f6700bc12f4374302dd3bfc035c9c9f060f56ef
Reviewed-by: Caspar Romot <cro@icd.ee>
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>

Helps recognition of default std::maps and makes the StdMapQt
dumper test pass with LLDB on Linux

Change-Id: I2d2a91d65e895c7fc2c99e24cc77d21ca6353b22
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

To HEAD of 1.4 branch.

Change-Id: I870c6c8fb86fd06cb77a7c2a333442f05c9f69b0
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

It's not clear why we need it there, it's generally not advisable to do
qApp->processEvents() and in this case it clearly creates problems.

Change-Id: I2707ef0ec98ee761078283ee3ce3f76f9da95f31
Task-number: QTCREATORBUG-14215
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

appendCommand() is already called by runVcs.

Change-Id: I215ac00d0efc36e5f62865d7d2cf9941533a160d
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

The base class should delete the d-ptr and the derived classes
should delete the members they add. The missing virtual destructor
in TimelineAbstractRendererPrivate constituted undefined behavior
(which wasn't triggered as it was never deleted) and the missing
destruction of render states and d-ptrs was a memory leak.

Change-Id: I4db9e5e2d6f23a3a58541c48ce08aa8fe5951cc9
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Task-number: QTCREATORBUG-14225
Change-Id: I5416b21dc0494825a892e42ae6bd4ff6f4cc0a56
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

We have seen that occasionally the Qt Quick scene can resize to strange
dimensions, including negative width, which will cause equally strange
results if we than get stray mouse events.

Also, we need to take care not to access the model or the zoom control
before they're initialized.

Change-Id: Idf137bf7d16806dcf18e0d3f7be2b42e07e724c3
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Previously it would skip over items with equal start times.

Change-Id: I7a6652ea732e851d382d06f05ff1146ef37b0dae
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Otherwise, if you increase the number of rows again later you get
surprising results.

Change-Id: I3ec809820716368849415f9dcdb1ec9208844353
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

The height of the trace is not sufficient to determine this as by
hiding categories it can be reduced to 0 without the trace being empty.

Change-Id: Ic8100b4da9c93808a6d49cf4ceba12de391ebc0e
Task-number: QTCREATORBUG-14277
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

The model manager's stateChanged() signal gives us accurate information
on when the clearing begins so that we can clear the timeline models as
first thing, not as last.

Clearing them as last thing can indirectly prompt them to access now
invalid data of the base model, such as the types.

Change-Id: I3af4a6716ed8b2efb433e7a264d3fc9a65f61490
Task-number: QTCREATORBUG-14277
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

This was curiously missing from the CompilerFlag enum, so e.g. setting
"QMAKE_CXXFLAGS += -std=c++98" in a .pro file did not have the desired
effect on higher-level code such as the code model.

Change-Id: Ia4323b699a2ccea9d3cbde10b05affe87d955277
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

Change-Id: I46310f9305b94bc0e4ac9a1708daa079b3245788
Task-number: QTCREATORBUG-14064
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

When the dialog is displayed, the welcome mode becomes disabled.

This happens because before the main loop begins, there is no active window, so
the dialog has no parent to return focus to when it is closed.

Change-Id: I2f8830c3c7bc6816d8483e05e81f5abfe5ee335f
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Id46305a7e9fba1d8383622a4d21f22ee8cbc470c
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Always add a space before a *. This fixes some test cases with LLDB
that failed to recognize the default argument in "std::vector<int *,
std::allocator<int*> >" due to the different spacing.

Change-Id: Ib4a57a808551d0b4cd527021f7d19772378e405f
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Change-Id: I49cfb29a3d6ec2245ed05956bb2cd46c6a2338cc
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>

Regression introduced by

        commit 9fb5b0be
        CppTools: Add basic completion support for qt5 style signals/slots

Change-Id: I0a8e5ef31c1394512a51a26ed08b0f445add5acd
Reviewed-by: Erik Verbruggen <erik.verbruggen@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

We have to make sure that the help engine is properly set up before
trying to read the bookmark data.

Change-Id: Id57cce5f538472eeac17b39a3640bf2ed77fa56a
Task-number: QTCREATORBUG-14106
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>

Change-Id: Ia773f4cc69f9554caeb78c1380ddf69095684000
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>

Missed in 808f4492.

Change-Id: I8760ab9fa897d708423b21c34771d5275f87d1d7
Reviewed-by: André Hartmann <aha_1980@gmx.de>

When a commit has several files, opening diff for the first file
works, but trying to open another diff without closing the previous
one doesn't refresh the diff editor.

Change-Id: Ia973cb70f2355a89b70787dd97042ef9f751d9d6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>

...when rebuilding the project tree.

Consider this product:
CppApplication { files: ["form.ui"] }

Now change it to this:
QtGuiApplication { files: ["form.ui"] }

The qbs file tags will now include "ui", so the Qt Creator
file type must change from "UnknownFileType" to "FormType". Therefore,
we need to replace the respective file node in the tree.

Change-Id: I6aa7e66d1af584e8ded2ffbb9b1215e8fc1135b8
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

The aggregator doesn't own the models. They may live in separate
plugins and should be cleared from the code where they are created.

Change-Id: Icbde117561e530bd83fe752acd483e2c42692a1c
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

To HEAD of 1.4 branch.

Change-Id: I989d723fcaf718d3502ee9047e9dd6048013244f
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

Change-Id: Ifaa4d87c73d2597a018d867f3c081113132e76ee
Task-number: QTCREATORBUG-14202
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>

Don't consider targets that end in _unittest or _automoc. Also don't
read CMakeDirectoryInformation.cmake as that doesn't work with
add_subdirectory.

Change-Id: If06af60e1637e94cccd32d09fc26c6b87488671b
Task-number: QTCREATORBUG-12183
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>

... after adding and removing files. We need to do this for qbs because
in contrast to other build system managers, we have optimized away the
re-parse step.

Change-Id: Iec217819621696081d6e8b87ef48be0be681372c
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>

We should use the actual display name of the node there, not some
hardcoded value.

Task-number: QTCREATORBUG-14240
Change-Id: Idf0fc4cdaab52d7f838d3d48d834a89b55ee593f
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

Should have been removed in fbb756cd.

Change-Id: I86e0fd556ac031e6a88e9397a039d67ded5f7bd7
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

At some cases, android.bat on Windows running longer.

Change-Id: I53ae90e4d7fea69b603cf8cca8c1f8ee5aa36a6a
Task-number: QTCREATORBUG-14223
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>

To HEAD of 1.4 branch.

Change-Id: Ib37e757f5b90db01fdc6d77a21556f214e776aa0
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>