src/plugins/cpptools · 291b80cb330f6f7a802ad9039c6e4294caee61b1 · Marco Bubke / flatpak-qt-creator

CppTools: Remove invalid optimization for highlighting

Nikolai Kosjar authored 11 years ago

The optimization in question could lead to an empty source and thus to
no highlighting. Checking for 'force' and the revisions is at this point
not enough since later the semantic info calculcation can be aborted, so
that a subsequent recalculation would get an empty document.

contents() itself is already optimized (uses caching).

Task-number: QTCREATORBUG-11367
Change-Id: If31a8ab0c848e4babd38104961fb9812f077a2be
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>

291b80cb

History

291b80cb 11 years ago

History

Name	Last commit	Last update
..
CppTools.pluginspec.in
abstracteditorsupport.cpp
abstracteditorsupport.h
builtinindexingsupport.cpp
builtinindexingsupport.h
commentssettings.cpp
commentssettings.h
completionsettingspage.cpp
completionsettingspage.h
completionsettingspage.ui
cppchecksymbols.cpp
cppchecksymbols.h
cppclassesfilter.cpp
cppclassesfilter.h
cppcodeformatter.cpp
cppcodeformatter.h
cppcodegen_test.cpp
cppcodemodelinspectordumper.cpp
cppcodemodelinspectordumper.h
cppcodemodelsettings.cpp
cppcodemodelsettings.h
cppcodemodelsettingspage.cpp
cppcodemodelsettingspage.h
cppcodemodelsettingspage.ui
cppcodestylepreferences.cpp
cppcodestylepreferences.h
cppcodestylepreferencesfactory.cpp
cppcodestylepreferencesfactory.h
cppcodestylesettings.cpp
cppcodestylesettings.h
cppcodestylesettingspage.cpp
cppcodestylesettingspage.h
cppcodestylesettingspage.ui
cppcompletion_test.cpp
cppcompletionassist.cpp
cppcompletionassist.h
cppcompletionassistprovider.cpp
cppcompletionassistprovider.h
cppcurrentdocumentfilter.cpp
cppcurrentdocumentfilter.h
cppdoxygen.cpp
cppdoxygen.h
cppfilesettingspage.cpp
cppfilesettingspage.h
cppfilesettingspage.ui
cppfindreferences.cpp
cppfindreferences.h
cppfunctionsfilter.cpp
cppfunctionsfilter.h
cppheadersource_test.cpp
cpphighlightingsupport.cpp
cpphighlightingsupport.h
cpphighlightingsupportinternal.cpp
cpphighlightingsupportinternal.h
cppindexingsupport.cpp
cppindexingsupport.h
cpplocalsymbols.cpp
cpplocalsymbols.h
cpplocatordata.cpp
cpplocatordata.h
cpplocatorfilter.cpp
cpplocatorfilter.h
cpplocatorfilter_test.cpp
cppmodelmanager.cpp
cppmodelmanager.h
cppmodelmanager_test.cpp
cppmodelmanagerinterface.cpp
cppmodelmanagerinterface.h
cppmodelmanagersupport.cpp
cppmodelmanagersupport.h
cppmodelmanagersupportinternal.cpp
cppmodelmanagersupportinternal.h
cpppointerdeclarationformatter.cpp
cpppointerdeclarationformatter.h
cpppointerdeclarationformatter_test.cpp
cpppreprocessertesthelper.cpp
cpppreprocessertesthelper.h
cpppreprocessor.cpp
cpppreprocessor.h
cpppreprocessor_test.cpp
cppprojectfile.cpp
cppprojectfile.h
cppqtstyleindenter.cpp
cppqtstyleindenter.h
cpprefactoringchanges.cpp
cpprefactoringchanges.h
cppsemanticinfo.cpp
cppsemanticinfo.h
cppsnapshotupdater.cpp
cppsnapshotupdater.h
cpptools.pro
cpptools.qbs
cpptools_dependencies.pri
cpptools_global.h
cpptoolsconstants.h
cpptoolseditorsupport.cpp
cpptoolseditorsupport.h
cpptoolsplugin.cpp
cpptoolsplugin.h
cpptoolsreuse.cpp