Connections liftimes are handled automatically

datasources/qmldesignerusagetimesource.cpp

@@ -50,24 +50,16 @@ static QString currentModeName()
 QmlDesignerUsageTimeSource::QmlDesignerUsageTimeSource()
     : TimeUsageSourceBase(QStringLiteral("qmlDesignerUsageTime"))
 {
-    m_connections <<
-        connect(Core::ModeManager::instance(), &Core::ModeManager::currentModeChanged,
-                [this](auto &&modeId){
-                    updateTrackingState(QString::fromUtf8(modeId.name().toLower())); });
-
-    m_connections <<
-        connect(Core::EditorManager::instance(), &Core::EditorManager::currentEditorChanged,
-                [this](){ updateTrackingState(currentModeName()); });
-}
+    connect(Core::ModeManager::instance(), &Core::ModeManager::currentModeChanged,
+            this, [this](auto &&modeId){
+                      updateTrackingState(QString::fromUtf8(modeId.name().toLower())); });
 
-QmlDesignerUsageTimeSource::~QmlDesignerUsageTimeSource()
-{
-    // Connections shouldn't outlive this object, because 'this' is captured
-    for (auto &&connection : m_connections) {
-        disconnect(connection);
-    }
+    connect(Core::EditorManager::instance(), &Core::EditorManager::currentEditorChanged,
+            this, [this](){ updateTrackingState(currentModeName()); });
 }
 
+QmlDesignerUsageTimeSource::~QmlDesignerUsageTimeSource() = default;
+
 QString QmlDesignerUsageTimeSource::name() const
 {
     return tr("QmlDesigner usage time");

datasources/qmldesignerusagetimesource.h

@@ -44,9 +44,6 @@ public: // AbstractDataSource interface
 
 private: // Methods
     void updateTrackingState(const QString &modeName);
-
-private: // Data
-    QVector<QMetaObject::Connection> m_connections;
 };
 
 } // namespace Internal