Skip to content
Snippets Groups Projects
Commit ba8469ac authored by Vitaly Fanaskov's avatar Vitaly Fanaskov
Browse files

Fix some of clang-tidy and clazy warnings

Mainly improved readability.
parent 520b13a5
No related branches found
No related tags found
No related merge requests found
......@@ -138,16 +138,16 @@ private: // Methods
static QVariantMap abiToVariantMap(const Abi &abi)
{
static const QString archKey = QStringLiteral("arch");
static const QString oSKey = QStringLiteral("os");
static const QString osKey = QStringLiteral("os");
static const QString osFlavorKey = QStringLiteral("osFlavor");
static const QString binaryFormatKey = QStringLiteral("binaryFormat");
static const QString wordWidthKey = QStringLiteral("wordWidth");
return QVariantMap{{archKey, abi.toString(abi.architecture())},
{oSKey, abi.toString(abi.os())},
{osFlavorKey, abi.toString(abi.osFlavor())},
{binaryFormatKey, abi.toString(abi.binaryFormat())},
{wordWidthKey, abi.toString(abi.wordWidth())}};
return QVariantMap{{archKey , Abi::toString(abi.architecture())},
{osKey , Abi::toString(abi.os()) },
{osFlavorKey , Abi::toString(abi.osFlavor()) },
{binaryFormatKey, Abi::toString(abi.binaryFormat())},
{wordWidthKey , Abi::toString(abi.wordWidth()) }};
}
template <class Container>
......@@ -172,7 +172,7 @@ private: // Data
static QVariantList kitsInfo()
{
QVariantList kitsInfoList;
for (auto kit : KitManager::instance()->kits()) {
for (auto &&kit : KitManager::instance()->kits()) {
if (kit && kit->isValid()) {
kitsInfoList << KitInfo::forKit(*kit)
.withCompilerInfo()
......
......@@ -63,7 +63,7 @@ protected:
bool isTimeTrackingActive() const;
signals:
Q_SIGNALS:
void start();
void stop();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment