Skip to content
Snippets Groups Projects
  • Nikolai Kosjar's avatar
    36e7f454
    Clang: Pass on file paths with native separators · 36e7f454
    Nikolai Kosjar authored
    libclang 3.8 seems to be sensitive to file paths separators [1]. On Windows,
    this led to not updated document annotations and/or crashes after reparsing.
    
    When passing file paths to libclang, convert to native separators.
    When getting file paths from libclang, convert back.
    
    This handles:
     * main file path
     * file paths of the unsaved files
     * -I<DIR> arguments, the resource path (for builtins) and the paths to the
       wrapped qt headers
     * included header files from libclang
     * source locations from libclang
    
    Also, minimize the conversion in SourceLocation to a minimum by making
    filePath() lazy.
    
    [1] https://llvm.org/bugs/show_bug.cgi?id=28381
    
    
    
    Change-Id: If5866f34a6fdc6b34b16c022d3988e8e6eae2a0a
    Reviewed-by: default avatarChristian Stenger <christian.stenger@qt.io>
    36e7f454
    History
    Clang: Pass on file paths with native separators
    Nikolai Kosjar authored
    libclang 3.8 seems to be sensitive to file paths separators [1]. On Windows,
    this led to not updated document annotations and/or crashes after reparsing.
    
    When passing file paths to libclang, convert to native separators.
    When getting file paths from libclang, convert back.
    
    This handles:
     * main file path
     * file paths of the unsaved files
     * -I<DIR> arguments, the resource path (for builtins) and the paths to the
       wrapped qt headers
     * included header files from libclang
     * source locations from libclang
    
    Also, minimize the conversion in SourceLocation to a minimum by making
    filePath() lazy.
    
    [1] https://llvm.org/bugs/show_bug.cgi?id=28381
    
    
    
    Change-Id: If5866f34a6fdc6b34b16c022d3988e8e6eae2a0a
    Reviewed-by: default avatarChristian Stenger <christian.stenger@qt.io>
compileroptionsbuilder.h 2.40 KiB
/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/

#pragma once

#include "cpptools_global.h"

#include "projectpart.h"

namespace CppTools {

class CPPTOOLS_EXPORT CompilerOptionsBuilder
{
public:
    CompilerOptionsBuilder(const ProjectPart &projectPart);
    virtual ~CompilerOptionsBuilder() {}

    QStringList options() const;

    // Add custom options
    void add(const QString &option);
    void addDefine(const QByteArray &defineLine);

    // Add options based on project part
    virtual void addTargetTriple();
    virtual void enableExceptions();
    void addHeaderPathOptions(bool addAsNativePath = false);
    void addToolchainAndProjectDefines();
    virtual void addLanguageOption(ProjectFile::Kind fileKind);
    virtual void addOptionsForLanguage(bool checkForBorlandExtensions = true);

    void addMsvcCompatibilityVersion();
    void undefineCppLanguageFeatureMacrosForMsvc2015();

protected:
    virtual bool excludeDefineLine(const QByteArray &defineLine) const;
    virtual bool excludeHeaderPath(const QString &headerPath) const;

    virtual QString defineOption() const;
    virtual QString includeOption() const;

    const ProjectPart m_projectPart;

private:
    QString defineLineToDefineOption(const QByteArray &defineLine);

    QStringList m_options;
};

} // namespace CppTools