Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Q qt-creator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Tobias Hunger
  • qt-creator
  • Repository
Switch branch/tag
  • qt-creator
  • src
  • plugins
  • qbsprojectmanager
  • qbsproject.cpp
Find file BlameHistoryPermalink
  • Tim Jenssen's avatar
    Qbs: Fix crash when renaming files · 56db0df2
    Tim Jenssen authored Jun 26, 2017 and Tobias Hunger's avatar Tobias Hunger committed Jun 26, 2017
    
    
    Fix a crash when using file nodes to change the project. The methods used
    to take const references, with the data living in the nodes of the project
    tree. Since the methods change the project tree and thus cause the tree to
    be rebuilt, the original data may get lost. So copy the data instead.
    
    All the qbs::*Data classes are using shared data, so the overhead is not
    too big.
    
    Task-number: QTCREATORBUG-18440
    Change-Id: I45ca5403a04e17790416dfe15b836f12c732e824
    Reviewed-by: Eike Ziller's avatarEike Ziller <eike.ziller@qt.io>
    Reviewed-by: Tim Jenssen's avatarTim Jenssen <tim.jenssen@qt.io>
    Reviewed-by: Christian Kandeler's avatarChristian Kandeler <christian.kandeler@qt.io>
    56db0df2