Avoid use of QKeySequence::isEmpty in checks in command implementations.
isEmpty is the wrong thing to check when setting the default shortcut. In addition, registering commands should not set their shortcut automatically (that should be defined solely by the default shortcut and reading the settings, which is done later).
Showing
- src/plugins/coreplugin/actionmanager/actionmanager.cpp 0 additions, 5 deletionssrc/plugins/coreplugin/actionmanager/actionmanager.cpp
- src/plugins/coreplugin/actionmanager/command.cpp 12 additions, 15 deletionssrc/plugins/coreplugin/actionmanager/command.cpp
- src/plugins/coreplugin/actionmanager/command_p.h 3 additions, 2 deletionssrc/plugins/coreplugin/actionmanager/command_p.h
- src/plugins/coreplugin/modemanager.cpp 3 additions, 0 deletionssrc/plugins/coreplugin/modemanager.cpp
Loading
Please register or sign in to comment