Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Q
qt-creator
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Tobias Hunger
qt-creator
Commits
119ea807
Commit
119ea807
authored
15 years ago
by
Friedemann Kleint
Browse files
Options
Downloads
Patches
Plain Diff
Debugger: Ignore case of file name in breakpoint handling on Windows.
Task-number: QTCREATORBUG-438
parent
397b634a
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/plugins/debugger/breakhandler.cpp
+14
-2
14 additions, 2 deletions
src/plugins/debugger/breakhandler.cpp
with
14 additions
and
2 deletions
src/plugins/debugger/breakhandler.cpp
+
14
−
2
View file @
119ea807
...
@@ -49,6 +49,18 @@ using namespace Debugger::Internal;
...
@@ -49,6 +49,18 @@ using namespace Debugger::Internal;
//
//
//////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////
// Compare file names case insensitively on Windows.
static
inline
bool
fileNameMatch
(
const
QString
&
f1
,
const
QString
&
f2
)
{
return
f1
.
compare
(
f2
,
#ifdef Q_OS_WIN
Qt
::
CaseInsensitive
#else
Qt
::
CaseSensitive
#endif
)
==
0
;
}
namespace
Debugger
{
namespace
Debugger
{
namespace
Internal
{
namespace
Internal
{
...
@@ -236,7 +248,7 @@ bool BreakpointData::isLocatedAt(const QString &fileName_, int lineNumber_) cons
...
@@ -236,7 +248,7 @@ bool BreakpointData::isLocatedAt(const QString &fileName_, int lineNumber_) cons
return true;
return true;
return false;
return false;
*/
*/
return
lineNumber_
==
markerLineNumber
&&
fileName
_
==
markerFileName
;
return
lineNumber_
==
markerLineNumber
&&
fileName
Match
(
fileName_
,
markerFileName
)
;
}
}
bool
BreakpointData
::
conditionsMatch
()
const
bool
BreakpointData
::
conditionsMatch
()
const
...
@@ -310,7 +322,7 @@ int BreakHandler::findBreakpoint(const BreakpointData &needle)
...
@@ -310,7 +322,7 @@ int BreakHandler::findBreakpoint(const BreakpointData &needle)
return
index
;
return
index
;
// at least at a position we were looking for
// at least at a position we were looking for
// FIXME: breaks multiple breakpoints at the same location
// FIXME: breaks multiple breakpoints at the same location
if
(
data
->
fileName
==
needle
.
bpFileName
if
(
fileNameMatch
(
data
->
fileName
,
needle
.
bpFileName
)
&&
data
->
lineNumber
==
needle
.
bpLineNumber
)
&&
data
->
lineNumber
==
needle
.
bpLineNumber
)
return
index
;
return
index
;
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment