Commit 1b9b1541 authored by Orgad Shaneh's avatar Orgad Shaneh Committed by Orgad Shaneh

Git: Un-slot private slots

Change-Id: If88d7e1b501daf6f0dfc696cb20e5f1eb4aa83fe
Reviewed-by: default avatarTobias Hunger <tobias.hunger@theqtcompany.com>
parent 74849134
......@@ -49,10 +49,9 @@ public:
bool track();
private slots:
private:
void updateButtonStatus();
private:
Ui::BranchAddDialog *m_ui;
};
......
......@@ -53,10 +53,9 @@ public:
bool hasStashForNextBranch();
bool hasLocalChanges();
private slots:
private:
void updatePopStashCheckBox(bool moveChangesChecked);
private:
Ui::BranchCheckoutDialog *m_ui;
bool m_foundStashForNextBranch;
bool m_hasLocalChanges;
......
......@@ -67,7 +67,7 @@ public:
QString workingDirectory() const;
ChangeCommand command() const;
private slots:
private:
void chooseWorkingDirectory();
void selectCommitFromRecentHistory();
void setDetails(int exitCode);
......@@ -79,7 +79,6 @@ private slots:
void acceptRevert();
void acceptShow();
private:
void enableButtons(bool b);
void terminateProcess();
......
......@@ -76,7 +76,7 @@ public slots:
void fetchStarted(const QSharedPointer<Gerrit::Internal::GerritChange> &change);
void fetchFinished();
private slots:
private:
void slotCurrentChanged();
void slotActivated(const QModelIndex &);
void slotRefreshStateChanged(bool);
......@@ -87,7 +87,6 @@ private slots:
void manageProgressIndicator();
private:
void setProgressIndicatorVisible(bool v);
QModelIndex currentIndex() const;
QPushButton *addActionButton(const QString &text, const std::function<void()> &buttonSlot);
......
......@@ -228,14 +228,13 @@ signals:
void queryFinished(const QByteArray &);
void finished();
private slots:
private:
void processError(QProcess::ProcessError);
void processFinished(int exitCode, QProcess::ExitStatus);
void readyReadStandardError();
void readyReadStandardOutput();
void timeout();
private:
void startQuery(const QString &query);
void errorTermination(const QString &msg);
void terminate();
......
......@@ -105,12 +105,6 @@ public:
public slots:
void start();
private slots:
void processError(QProcess::ProcessError);
void processFinished(int exitCode, QProcess::ExitStatus);
void processReadyReadStandardError();
void processReadyReadStandardOutput();
private:
enum State
{
......@@ -119,6 +113,11 @@ private:
ErrorState
};
void processError(QProcess::ProcessError);
void processFinished(int exitCode, QProcess::ExitStatus);
void processReadyReadStandardError();
void processReadyReadStandardOutput();
void handleError(const QString &message);
void show();
void cherryPick();
......
......@@ -55,12 +55,11 @@ public:
QString reviewers() const;
bool isValid() const;
private slots:
private:
void setChangeRange();
void setRemoteBranches(bool includeOld = false);
void updateCommits(int index);
private:
typedef QPair<QString, QDate> BranchDate;
typedef QMultiMap<QString, BranchDate> RemoteBranchesMap;
......
......@@ -117,7 +117,7 @@ public:
~BaseController();
void runCommand(const QList<QStringList> &args, QTextCodec *codec = 0);
private slots:
private:
virtual void processOutput(const QString &output);
protected:
......
......@@ -343,7 +343,7 @@ public:
public slots:
void show(const QString &source, const QString &id, const QString &name = QString());
private slots:
private:
void finishSubmoduleUpdate();
void fetchFinished(const QVariant &cookie);
void slotChunkActionsRequested(QMenu *menu, bool isValid);
......@@ -351,7 +351,6 @@ private slots:
void slotUnstageChunk();
void branchesForCommit(const QString &revision);
private:
void stage(const QString &patch, bool revert);
enum CodecType { CodecSource, CodecLogOutput, CodecNone };
......
......@@ -46,14 +46,13 @@ public:
void setPlainText(const QString &text) override;
private slots:
private:
void checkoutChange();
void cherryPickChange();
void revertChange();
void logChange();
void applyDiffChunk(const VcsBase::DiffChunk& chunk, bool revert);
private:
void init() override;
void resetChange(const QByteArray &resetType);
void addDiffActions(QMenu *menu, const VcsBase::DiffChunk &chunk) override;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment