Commit 224210b0 authored by Ulf Hermann's avatar Ulf Hermann
Browse files

QmlProfiler: remove dead code



The selectedEventChanged signal was never emitted and aliasing the
selectedItem property was unnecessary.

Change-Id: I2a15ad82bbf20a7ae9a42e17935242fbac7b5129
Reviewed-by: default avatarKai Koehne <kai.koehne@digia.com>
parent 480c6528
......@@ -40,8 +40,6 @@ Rectangle {
property alias selectionLocked : view.selectionLocked
signal updateLockButton
property alias selectedItem: view.selectedItem
signal selectedEventChanged(int eventId)
property bool lockItemSelection : false
property real mainviewTimePerPixel : 0
......@@ -196,16 +194,6 @@ Rectangle {
updateLockButton();
}
onSelectedItemChanged: {
if (selectedItem != -1 && !lockItemSelection) {
lockItemSelection = true;
// update in other views
var eventLocation = qmlProfilerModelProxy.getEventLocation(view.selectedModel, view.selectedItem);
gotoSourceLocation(eventLocation.file, eventLocation.line, eventLocation.column);
lockItemSelection = false;
}
}
Flickable {
id: labelsflick
flickableDirection: Flickable.VerticalFlick
......@@ -362,7 +350,16 @@ Rectangle {
Math.max(0, Math.floor(center - windowLength/2)));
zoomControl.setRange(from, from + windowLength);
}
if (!lockItemSelection) {
lockItemSelection = true;
// update in other views
var eventLocation = qmlProfilerModelProxy.getEventLocation(
view.selectedModel, view.selectedItem);
gotoSourceLocation(eventLocation.file, eventLocation.line,
eventLocation.column);
lockItemSelection = false;
}
} else {
root.hideRangeDetails();
......
......@@ -186,7 +186,6 @@ void QmlProfilerTraceView::reset()
connect(rootObject, SIGNAL(updateLockButton()), this, SLOT(updateLockButton()));
connect(this, SIGNAL(jumpToPrev()), rootObject, SLOT(prevEvent()));
connect(this, SIGNAL(jumpToNext()), rootObject, SLOT(nextEvent()));
connect(rootObject, SIGNAL(selectedEventChanged(int)), this, SIGNAL(selectedEventChanged(int)));
connect(rootObject, SIGNAL(changeToolTip(QString)), this, SLOT(updateToolTip(QString)));
connect(this, SIGNAL(enableToolbar(bool)), this, SLOT(setZoomSliderEnabled(bool)));
connect(this, SIGNAL(showZoomSlider(bool)), this, SLOT(setZoomSliderVisible(bool)));
......
......@@ -104,7 +104,6 @@ private slots:
signals:
void gotoSourceLocation(const QString &fileUrl, int lineNumber, int columNumber);
void selectedEventChanged(int eventId);
void jumpToPrev();
void jumpToNext();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment