Less magic in BuildStep::buildConfiguration() and deployConfiguration()
Where the deploy stuff depends on the activeBuildConfiguration it's
likely to be wrong or worse could be used to crash creator. So make
those places stand out.
Also if we ever move towards supporting meta-builds of multiple
buildconfigurations at once, then using the active build configuration
is wrong.
Change-Id: I754a77a4a8b352e79e8a6703c26ed41a189cf74e
Reviewed-by:
Tobias Hunger <tobias.hunger@nokia.com>
Showing
- src/plugins/madde/maemopackagecreationstep.cpp 6 additions, 6 deletionssrc/plugins/madde/maemopackagecreationstep.cpp
- src/plugins/projectexplorer/abstractprocessstep.cpp 1 addition, 1 deletionsrc/plugins/projectexplorer/abstractprocessstep.cpp
- src/plugins/projectexplorer/buildmanager.cpp 11 additions, 12 deletionssrc/plugins/projectexplorer/buildmanager.cpp
- src/plugins/projectexplorer/buildstep.cpp 7 additions, 8 deletionssrc/plugins/projectexplorer/buildstep.cpp
- src/plugins/projectexplorer/buildstep.h 1 addition, 0 deletionssrc/plugins/projectexplorer/buildstep.h
- src/plugins/qt4projectmanager/qmakestep.cpp 2 additions, 3 deletionssrc/plugins/qt4projectmanager/qmakestep.cpp
- src/plugins/qt4projectmanager/qt-s60/s60createpackagestep.cpp 4 additions, 4 deletions...plugins/qt4projectmanager/qt-s60/s60createpackagestep.cpp
- src/plugins/qt4projectmanager/qt-s60/s60deploystep.cpp 1 addition, 1 deletionsrc/plugins/qt4projectmanager/qt-s60/s60deploystep.cpp
- src/plugins/remotelinux/abstractremotelinuxdeploystep.cpp 2 additions, 1 deletionsrc/plugins/remotelinux/abstractremotelinuxdeploystep.cpp
- src/plugins/remotelinux/tarpackagecreationstep.cpp 1 addition, 1 deletionsrc/plugins/remotelinux/tarpackagecreationstep.cpp
Loading
Please register or sign in to comment