Commit 449e2dca authored by hjk's avatar hjk
Browse files

Debugger: Some cleanup in DebuggerPlugin



Remove unused code and unneeded slots.

Change-Id: If3de545137376b1addeb3c7608c479dadf03ed46
Reviewed-by: default avatarChristian Stenger <christian.stenger@theqtcompany.com>
parent f515a252
...@@ -419,24 +419,11 @@ struct TestCallBack ...@@ -419,24 +419,11 @@ struct TestCallBack
Q_DECLARE_METATYPE(Debugger::Internal::BreakpointMenuContextData) Q_DECLARE_METATYPE(Debugger::Internal::BreakpointMenuContextData)
Q_DECLARE_METATYPE(Debugger::Internal::TestCallBack) Q_DECLARE_METATYPE(Debugger::Internal::TestCallBack)
namespace Debugger { namespace Debugger {
namespace Internal { namespace Internal {
// FIXME: Outdated?
// The createCdbEngine function takes a list of options pages it can add to.
// This allows for having a "enabled" toggle on the page independently
// of the engine. That's good for not enabling the related ActiveX control
// unnecessarily.
void addCdbOptionPages(QList<IOptionsPage*> *opts); void addCdbOptionPages(QList<IOptionsPage*> *opts);
void addGdbOptionPages(QList<IOptionsPage*> *opts); void addGdbOptionPages(QList<IOptionsPage*> *opts);
void addScriptOptionPages(QList<IOptionsPage*> *opts);
void addTcfOptionPages(QList<IOptionsPage*> *opts);
#ifdef WITH_LLDB
void addLldbOptionPages(QList<IOptionsPage*> *opts);
#endif
static QToolButton *toolButton(QAction *action) static QToolButton *toolButton(QAction *action)
{ {
...@@ -642,7 +629,6 @@ public: ...@@ -642,7 +629,6 @@ public:
} }
DebuggerRunControl *attachToRunningProcess(Kit *kit, DeviceProcessItem process); DebuggerRunControl *attachToRunningProcess(Kit *kit, DeviceProcessItem process);
public slots:
void writeSettings() void writeSettings()
{ {
m_debuggerSettings->writeSettings(); m_debuggerSettings->writeSettings();
...@@ -779,7 +765,7 @@ public slots: ...@@ -779,7 +765,7 @@ public slots:
void attachToFoundProcess(); void attachToFoundProcess();
void continueOnAttach(Debugger::DebuggerState state); void continueOnAttach(Debugger::DebuggerState state);
void attachToQmlPort(); void attachToQmlPort();
void runScheduled(); Q_SLOT void runScheduled();
void attachCore(); void attachCore();
void enableReverseDebuggingTriggered(const QVariant &value); void enableReverseDebuggingTriggered(const QVariant &value);
...@@ -3060,9 +3046,6 @@ void DebuggerPluginPrivate::extensionsInitialized() ...@@ -3060,9 +3046,6 @@ void DebuggerPluginPrivate::extensionsInitialized()
addLldbOptionPages(&engineOptionPages); addLldbOptionPages(&engineOptionPages);
#endif #endif
// addScriptOptionPages(&engineOptionPages);
// addTcfOptionPages(&engineOptionPages);
foreach (IOptionsPage *op, engineOptionPages) foreach (IOptionsPage *op, engineOptionPages)
m_plugin->addAutoReleasedObject(op); m_plugin->addAutoReleasedObject(op);
m_plugin->addAutoReleasedObject(new LocalsAndExpressionsOptionsPage); m_plugin->addAutoReleasedObject(new LocalsAndExpressionsOptionsPage);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment