Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Tobias Hunger
qt-creator
Commits
5209b396
Commit
5209b396
authored
Nov 18, 2010
by
hjk
Browse files
debugger: make BreakHandler::setState private
parent
81b7e735
Changes
4
Hide whitespace changes
Inline
Side-by-side
src/plugins/debugger/breakhandler.h
View file @
5209b396
...
...
@@ -143,13 +143,6 @@ public:
const
BreakpointParameters
&
data
);
private:
public:
// FIXME: Make private.
void
setState
(
BreakpointId
id
,
BreakpointState
state
);
private:
friend
class
BreakpointMarker
;
// QAbstractItemModel implementation.
int
columnCount
(
const
QModelIndex
&
parent
)
const
;
int
rowCount
(
const
QModelIndex
&
parent
)
const
;
...
...
@@ -157,7 +150,7 @@ private:
QVariant
headerData
(
int
section
,
Qt
::
Orientation
orientation
,
int
role
)
const
;
Qt
::
ItemFlags
flags
(
const
QModelIndex
&
index
)
const
;
void
markerUpd
ate
d
(
Breakpoint
Marker
*
marker
,
int
lineNumber
);
void
setSt
ate
(
Breakpoint
Id
id
,
BreakpointState
state
);
void
loadBreakpoints
();
void
saveBreakpoints
();
void
updateMarker
(
BreakpointId
id
);
...
...
src/plugins/debugger/breakpointmarker.h
View file @
5209b396
...
...
@@ -58,4 +58,5 @@ private:
}
// namespace Internal
}
// namespace Debugger
#endif
src/plugins/debugger/cdb/cdbengine.cpp
View file @
5209b396
...
...
@@ -1294,7 +1294,7 @@ bool CdbEngine::attemptBreakpointSynchronizationI(QString *errorMessage)
errorMessage
->
clear
();
switch
(
handler
->
state
(
id
))
{
case
BreakpointInsertRequested
:
handler
->
setState
(
id
,
BreakpointInsertProceeding
);
handler
->
notify
BreakpointInsertProceeding
(
id
);
if
(
addCdbBreakpoint
(
control
,
symbols
,
data
,
&
response
,
errorMessage
))
{
handler
->
notifyBreakpointInsertOk
(
id
);
handler
->
setResponse
(
id
,
response
);
...
...
@@ -1305,7 +1305,7 @@ bool CdbEngine::attemptBreakpointSynchronizationI(QString *errorMessage)
break
;
case
BreakpointChangeRequested
:
// Skip disabled breakpoints, else add.
handler
->
setState
(
id
,
BreakpointChangeProceeding
);
handler
->
notify
BreakpointChangeProceeding
(
id
);
if
(
data
.
enabled
)
{
if
(
addCdbBreakpoint
(
control
,
symbols
,
data
,
&
response
,
errorMessage
))
{
handler
->
notifyBreakpointChangeOk
(
id
);
...
...
src/plugins/debugger/cdb2/cdbengine2.cpp
View file @
5209b396
...
...
@@ -1606,13 +1606,13 @@ void CdbEngine::attemptBreakpointSynchronization()
case
BreakpointInsertRequested
:
response
.
number
=
m_nextBreakpointNumber
++
;
postCommand
(
cdbAddBreakpointCommand
(
p
,
false
,
response
.
number
),
0
);
handler
->
setState
(
id
,
BreakpointInsertProceeding
);
handler
->
notify
BreakpointInsertProceeding
(
id
);
handler
->
notifyBreakpointInsertOk
(
id
);
handler
->
setResponse
(
id
,
response
);
break
;
case
BreakpointChangeRequested
:
// Skip disabled breakpoints, else add
handler
->
setState
(
id
,
BreakpointChangeProceeding
);
// Skip disabled breakpoints, else add
.
handler
->
notify
BreakpointChangeProceeding
(
id
);
if
(
p
.
enabled
)
{
response
.
number
=
m_nextBreakpointNumber
++
;
postCommand
(
cdbAddBreakpointCommand
(
p
,
false
,
response
.
number
),
0
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment