Commit 715796b4 authored by Tobias Hunger's avatar Tobias Hunger
Browse files

Fix krazy issues: Use explicit constructors

 * Fix all warnings about non-explicit constructors except for those
   in 3rdparty code.
parent 8d188d01
......@@ -9,7 +9,7 @@ class LoggerModeWidget : public QWidget
Q_OBJECT
public:
LoggerModeWidget(const QString projectName, QWidget* parent = 0);
explicit LoggerModeWidget(const QString projectName, QWidget* parent = 0);
~LoggerModeWidget();
public slots:
......
......@@ -9,7 +9,7 @@ class ModelClassWizard : public Core::BaseFileWizard
Q_OBJECT
public:
ModelClassWizard(const Core::BaseFileWizardParameters &parameters, QObject *parent = 0);
explicit ModelClassWizard(const Core::BaseFileWizardParameters &parameters, QObject *parent = 0);
~ModelClassWizard();
QWizard *createWizardDialog(QWidget *parent,
......
......@@ -42,7 +42,7 @@ class MyMain : public QWidget
Q_OBJECT
public:
MyMain(QWidget *parent = 0, Qt::WFlags flags = 0);
explicit MyMain(QWidget *parent = 0, Qt::WFlags flags = 0);
~MyMain();
void add(IComboEntry *obj);
......
......@@ -41,9 +41,9 @@ class CPLUSPLUS_EXPORT BackwardsScanner
enum { MAX_BLOCK_COUNT = 10 };
public:
BackwardsScanner(const QTextCursor &cursor,
int maxBlockCount = MAX_BLOCK_COUNT,
const QString &suffix = QString());
explicit BackwardsScanner(const QTextCursor &cursor,
int maxBlockCount = MAX_BLOCK_COUNT,
const QString &suffix = QString());
int startToken() const;
......
......@@ -48,7 +48,7 @@ class CPLUSPLUS_EXPORT MacroArgumentReference
unsigned _length;
public:
MacroArgumentReference(unsigned position = 0, unsigned length = 0)
explicit MacroArgumentReference(unsigned position = 0, unsigned length = 0)
: _position(position), _length(length)
{ }
......
......@@ -80,7 +80,7 @@ class MacroExpander
const QByteArray *resolve_formal(const QByteArray &name);
public:
MacroExpander(Environment *env, pp_frame *frame = 0, Client *client = 0, unsigned start_offset = 0);
explicit MacroExpander(Environment *env, pp_frame *frame = 0, Client *client = 0, unsigned start_offset = 0);
const char *operator()(const char *first, const char *last,
QByteArray *result);
......
......@@ -58,7 +58,7 @@ class EXTENSIONSYSTEM_EXPORT PluginView : public QWidget
Q_OBJECT
public:
PluginView(PluginManager *manager, QWidget *parent = 0);
explicit PluginView(PluginManager *manager, QWidget *parent = 0);
~PluginView();
PluginSpec *currentPlugin() const;
......
......@@ -272,7 +272,7 @@ class QML_PARSER_EXPORT UiFormal: public Node
public:
QMLJS_DECLARE_AST_NODE(UiFormal)
UiFormal(NameId *name, NameId *alias = 0)
explicit UiFormal(NameId *name, NameId *alias = 0)
: name(name), alias(alias)
{ }
......@@ -1762,7 +1762,7 @@ class QML_PARSER_EXPORT CaseBlock: public Node
public:
QMLJS_DECLARE_AST_NODE(CaseBlock)
CaseBlock(CaseClauses *c, DefaultClause *d = 0, CaseClauses *r = 0):
explicit CaseBlock(CaseClauses *c, DefaultClause *d = 0, CaseClauses *r = 0):
clauses (c), defaultClause (d), moreClauses (r)
{ kind = K; }
......
......@@ -64,7 +64,7 @@ namespace QmlJS { namespace AST {
class SourceLocation
{
public:
SourceLocation(quint32 offset = 0, quint32 length = 0, quint32 line = 0, quint32 column = 0)
explicit SourceLocation(quint32 offset = 0, quint32 length = 0, quint32 line = 0, quint32 column = 0)
: offset(offset), length(length),
startLine(line), startColumn(column)
{ }
......
......@@ -67,7 +67,7 @@ class NameId;
class QML_PARSER_EXPORT Lexer
{
public:
Lexer(Engine *eng, bool tokenizeComments = false);
explicit Lexer(Engine *eng, bool tokenizeComments = false);
~Lexer();
void setCode(const QString &c, int lineno);
......
......@@ -69,7 +69,7 @@ class QDeclarativeEngineDebug : public QObject
{
Q_OBJECT
public:
QDeclarativeEngineDebug(QDeclarativeDebugConnection *, QObject * = 0);
explicit QDeclarativeEngineDebug(QDeclarativeDebugConnection *, QObject * = 0);
~QDeclarativeEngineDebug();
QDeclarativeDebugPropertyWatch *addWatch(const QDeclarativeDebugPropertyReference &,
......
......@@ -48,7 +48,7 @@ public:
SymbolLocation();
//! Constructor
SymbolLocation(QString file, int lineNumber = 0, int columnNumber = 0);
explicit SymbolLocation(QString file, int lineNumber = 0, int columnNumber = 0);
inline const QString &fileName() const { return m_fileName; }
inline int line() const { return m_line; }
......
......@@ -108,7 +108,7 @@ class ShadowBuildPage : public QWizardPage
{
Q_OBJECT
public:
ShadowBuildPage(CMakeOpenProjectWizard *cmakeWizard, bool change = false);
explicit ShadowBuildPage(CMakeOpenProjectWizard *cmakeWizard, bool change = false);
private slots:
void buildDirectoryChanged();
private:
......@@ -121,7 +121,7 @@ class CMakeRunPage : public QWizardPage
Q_OBJECT
public:
enum Mode { Initial, Update, Recreate, Change };
CMakeRunPage(CMakeOpenProjectWizard *cmakeWizard, Mode mode = Initial, const QString &buildDirectory = QString());
explicit CMakeRunPage(CMakeOpenProjectWizard *cmakeWizard, Mode mode = Initial, const QString &buildDirectory = QString());
virtual void initializePage();
virtual void cleanupPage();
......
......@@ -128,7 +128,7 @@ class CMakeRunConfigurationWidget : public QWidget
{
Q_OBJECT
public:
CMakeRunConfigurationWidget(CMakeRunConfiguration *cmakeRunConfiguration, QWidget *parent = 0);
explicit CMakeRunConfigurationWidget(CMakeRunConfiguration *cmakeRunConfiguration, QWidget *parent = 0);
private slots:
void setArguments(const QString &args);
......
......@@ -81,7 +81,7 @@ class CORE_EXPORT EditorManagerPlaceHolder : public QWidget
{
Q_OBJECT
public:
EditorManagerPlaceHolder(Core::IMode *mode, QWidget *parent = 0);
explicit EditorManagerPlaceHolder(Core::IMode *mode, QWidget *parent = 0);
~EditorManagerPlaceHolder();
static EditorManagerPlaceHolder* current();
private slots:
......
......@@ -41,7 +41,7 @@ class CORE_EXPORT FindToolBarPlaceHolder : public QWidget
{
Q_OBJECT
public:
FindToolBarPlaceHolder(QWidget *owner, QWidget *parent = 0);
explicit FindToolBarPlaceHolder(QWidget *owner, QWidget *parent = 0);
~FindToolBarPlaceHolder();
QWidget *owner() const;
void setWidget(QWidget *widget);
......
......@@ -38,7 +38,7 @@ namespace Internal {
class FlowLayout : public QLayout
{
public:
FlowLayout(QWidget *parent, int margin = 0, int spacing = -1);
explicit FlowLayout(QWidget *parent, int margin = 0, int spacing = -1);
FlowLayout(int spacing = -1);
~FlowLayout();
......
......@@ -56,7 +56,7 @@ class CORE_EXPORT NavigationWidgetPlaceHolder : public QWidget
friend class Core::NavigationWidget;
Q_OBJECT
public:
NavigationWidgetPlaceHolder(Core::IMode *mode, QWidget *parent = 0);
explicit NavigationWidgetPlaceHolder(Core::IMode *mode, QWidget *parent = 0);
~NavigationWidgetPlaceHolder();
static NavigationWidgetPlaceHolder* current();
void applyStoredSize(int width);
......
......@@ -60,7 +60,7 @@ class CORE_EXPORT OutputPanePlaceHolder : public QWidget
friend class Core::Internal::OutputPaneManager; // needs to set m_visible and thus access m_current
Q_OBJECT
public:
OutputPanePlaceHolder(Core::IMode *mode, QSplitter *parent = 0);
explicit OutputPanePlaceHolder(Core::IMode *mode, QSplitter *parent = 0);
~OutputPanePlaceHolder();
void setCloseable(bool b);
bool closeable();
......
......@@ -56,7 +56,7 @@ class CORE_EXPORT RightPanePlaceHolder : public QWidget
Q_OBJECT
public:
RightPanePlaceHolder(Core::IMode *mode, QWidget *parent = 0);
explicit RightPanePlaceHolder(Core::IMode *mode, QWidget *parent = 0);
~RightPanePlaceHolder();
static RightPanePlaceHolder *current();
......
......@@ -88,7 +88,7 @@ class CPPEDITOR_EXPORT CppQuickFixOperation: public TextEditor::QuickFixOperatio
Q_DISABLE_COPY(CppQuickFixOperation)
public:
CppQuickFixOperation(const CppQuickFixState &state, int priority = -1);
explicit CppQuickFixOperation(const CppQuickFixState &state, int priority = -1);
virtual ~CppQuickFixOperation();
virtual void perform();
......
......@@ -46,8 +46,8 @@ public:
// A list of state indicators and file names.
typedef QPair<State, QString> StateFilePair;
CVSSubmitEditor(const VCSBase::VCSBaseSubmitEditorParameters *parameters,
QWidget *parentWidget = 0);
explicit CVSSubmitEditor(const VCSBase::VCSBaseSubmitEditorParameters *parameters,
QWidget *parentWidget = 0);
void setStateList(const QList<StateFilePair> &statusOutput);
......
......@@ -58,7 +58,7 @@ public:
DumperLoadedByGdb
};
AbstractGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit AbstractGdbAdapter(GdbEngine *engine, QObject *parent = 0);
virtual ~AbstractGdbAdapter();
virtual void write(const QByteArray &data);
......
......@@ -41,7 +41,7 @@ class AbstractPlainGdbAdapter : public AbstractGdbAdapter
Q_OBJECT
public:
AbstractPlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit AbstractPlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
virtual void setupInferior();
void runEngine();
......
......@@ -48,7 +48,7 @@ class AttachGdbAdapter : public AbstractGdbAdapter
Q_OBJECT
public:
AttachGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit AttachGdbAdapter(GdbEngine *engine, QObject *parent = 0);
private:
DumperHandling dumperHandling() const { return DumperLoadedByGdb; }
......
......@@ -49,7 +49,7 @@ class CoreGdbAdapter : public AbstractGdbAdapter
Q_OBJECT
public:
CoreGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit CoreGdbAdapter(GdbEngine *engine, QObject *parent = 0);
private:
DumperHandling dumperHandling() const { return DumperNotAvailable; }
......
......@@ -50,7 +50,7 @@ class LocalPlainGdbAdapter : public AbstractPlainGdbAdapter
Q_OBJECT
public:
LocalPlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit LocalPlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
private:
void startAdapter();
......
......@@ -42,7 +42,7 @@ class DEBUGGER_EXPORT RemotePlainGdbAdapter : public AbstractPlainGdbAdapter
public:
friend class RemoteGdbProcess;
RemotePlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit RemotePlainGdbAdapter(GdbEngine *engine, QObject *parent = 0);
void handleSetupDone();
void handleSetupFailed(const QString &reason);
......
......@@ -50,7 +50,7 @@ class TermGdbAdapter : public AbstractGdbAdapter
Q_OBJECT
public:
TermGdbAdapter(GdbEngine *engine, QObject *parent = 0);
explicit TermGdbAdapter(GdbEngine *engine, QObject *parent = 0);
~TermGdbAdapter();
private:
......
......@@ -49,7 +49,7 @@ class WatchWindow : public QTreeView
public:
enum Type { ReturnType, LocalsType, TooltipType, WatchersType };
WatchWindow(Type type, QWidget *parent = 0);
explicit WatchWindow(Type type, QWidget *parent = 0);
Type type() const { return m_type; }
public slots:
......
......@@ -44,7 +44,7 @@ class FormEditorW;
class QtCreatorIntegration : public qdesigner_internal::QDesignerIntegration {
Q_OBJECT
public:
QtCreatorIntegration(QDesignerFormEditorInterface *core, FormEditorW *parent = 0);
explicit QtCreatorIntegration(QDesignerFormEditorInterface *core, FormEditorW *parent = 0);
QWidget *containerWindow(QWidget *widget) const;
......
......@@ -78,7 +78,7 @@ class FakeVimHandler : public QObject
Q_OBJECT
public:
FakeVimHandler(QWidget *widget, QObject *parent = 0);
explicit FakeVimHandler(QWidget *widget, QObject *parent = 0);
~FakeVimHandler();
QWidget *widget();
......
......@@ -43,8 +43,8 @@ namespace Internal {
class SearchResultTreeItem
{
public:
SearchResultTreeItem(const SearchResultItem &item = SearchResultItem(),
SearchResultTreeItem *parent = NULL);
explicit SearchResultTreeItem(const SearchResultItem &item = SearchResultItem(),
SearchResultTreeItem *parent = NULL);
virtual ~SearchResultTreeItem();
bool isLeaf() const;
......
......@@ -42,7 +42,7 @@ class HelpMode : public Core::BaseMode
Q_OBJECT
public:
HelpMode(QWidget *widget, QObject *parent = 0);
explicit HelpMode(QWidget *widget, QObject *parent = 0);
};
} // namespace Internal
......
......@@ -60,7 +60,7 @@ class HelpViewer : public QTextBrowser
Q_DISABLE_COPY(HelpViewer)
public:
HelpViewer(qreal zoom, QWidget *parent = 0);
explicit HelpViewer(qreal zoom, QWidget *parent = 0);
~HelpViewer();
QFont viewerFont() const;
......
......@@ -56,7 +56,7 @@ class OpenPagesWidget : public QTreeView
Q_OBJECT
public:
OpenPagesWidget(OpenPagesModel *model, QWidget *parent = 0);
explicit OpenPagesWidget(OpenPagesModel *model, QWidget *parent = 0);
~OpenPagesWidget();
void selectCurrentPage();
......
......@@ -73,7 +73,7 @@ class RemoteFilterOptions : public QDialog
friend class RemoteHelpFilter;
public:
RemoteFilterOptions(RemoteHelpFilter *filter, QWidget *parent = 0);
explicit RemoteFilterOptions(RemoteHelpFilter *filter, QWidget *parent = 0);
private slots:
void addNewItem();
......
......@@ -42,7 +42,7 @@ class PendingChangesDialog : public QDialog
Q_OBJECT
public:
PendingChangesDialog(const QString &data, QWidget *parent = 0);
explicit PendingChangesDialog(const QString &data, QWidget *parent = 0);
int changeNumber() const;
private:
......
......@@ -46,7 +46,7 @@ class BuildConfigurationModel : public QAbstractListModel
{
Q_OBJECT
public:
BuildConfigurationModel(Target *target, QObject *parent = 0);
explicit BuildConfigurationModel(Target *target, QObject *parent = 0);
int rowCount(const QModelIndex &parent = QModelIndex()) const;
int columnCount(const QModelIndex &parent = QModelIndex()) const;
......
......@@ -45,7 +45,7 @@ class DeployConfigurationModel : public QAbstractListModel
{
Q_OBJECT
public:
DeployConfigurationModel(Target *target, QObject *parent = 0);
explicit DeployConfigurationModel(Target *target, QObject *parent = 0);
int rowCount(const QModelIndex &parent = QModelIndex()) const;
int columnCount(const QModelIndex &parent = QModelIndex()) const;
......
......@@ -96,7 +96,7 @@ class PROJECTEXPLORER_EXPORT EnvironmentWidget : public QWidget
{
Q_OBJECT
public:
EnvironmentWidget(QWidget *parent, QWidget *additionalDetailsWidget = 0);
explicit EnvironmentWidget(QWidget *parent, QWidget *additionalDetailsWidget = 0);
~EnvironmentWidget();
void setBaseEnvironmentText(const QString &text);
......
......@@ -57,7 +57,7 @@ private:
ProjectExplorer::Project* m_project;
public:
ProjectListWidget(ProjectExplorer::Project *project, QWidget *parent = 0);
explicit ProjectListWidget(ProjectExplorer::Project *project, QWidget *parent = 0);
QSize sizeHint() const;
......@@ -74,7 +74,7 @@ class MiniTargetWidget : public QWidget
{
Q_OBJECT
public:
MiniTargetWidget(ProjectExplorer::Target *target, QWidget *parent = 0);
explicit MiniTargetWidget(ProjectExplorer::Target *target, QWidget *parent = 0);
ProjectExplorer::Target *target() const;
bool hasBuildConfiguration() const;
......@@ -113,7 +113,7 @@ class MiniProjectTargetSelector : public QWidget
{
Q_OBJECT
public:
MiniProjectTargetSelector(QAction *projectAction, QWidget *parent = 0);
explicit MiniProjectTargetSelector(QAction *projectAction, QWidget *parent = 0);
void setVisible(bool visible);
signals:
......
......@@ -44,7 +44,7 @@ class RunConfigurationModel : public QAbstractListModel
{
Q_OBJECT
public:
RunConfigurationModel(Target *target, QObject *parent = 0);
explicit RunConfigurationModel(Target *target, QObject *parent = 0);
int rowCount(const QModelIndex &parent = QModelIndex()) const;
int columnCount(const QModelIndex &parent = QModelIndex()) const;
......
......@@ -126,7 +126,7 @@ class ItemLibraryModel: public ItemLibrarySortedModel<ItemLibrarySectionModel> {
Q_PROPERTY(QString searchText READ searchText WRITE setSearchText NOTIFY searchTextChanged)
public:
ItemLibraryModel(QScriptEngine *scriptEngine, QObject *parent = 0);
explicit ItemLibraryModel(QScriptEngine *scriptEngine, QObject *parent = 0);
~ItemLibraryModel();
QString searchText() const;
......
......@@ -8,7 +8,7 @@ QT_FORWARD_DECLARE_CLASS(QChildEvent)
class StyledOutputpanePlaceHolder : public Core::OutputPanePlaceHolder
{
public:
StyledOutputpanePlaceHolder(Core::IMode *mode, QSplitter *parent = 0);
explicit StyledOutputpanePlaceHolder(Core::IMode *mode, QSplitter *parent = 0);
protected:
void childEvent(QChildEvent *event);
......
......@@ -41,8 +41,8 @@ class QmlFileWizard: public Core::StandardFileWizard
public:
typedef Core::BaseFileWizardParameters BaseFileWizardParameters;
QmlFileWizard(const BaseFileWizardParameters &parameters,
QObject *parent = 0);
explicit QmlFileWizard(const BaseFileWizardParameters &parameters,
QObject *parent = 0);
protected:
QString fileContents(const QString &baseName) const;
......
......@@ -58,7 +58,7 @@ class CodeCompletion: public TextEditor::ICompletionCollector
Q_OBJECT
public:
CodeCompletion(QmlJS::ModelManagerInterface *modelManager, QObject *parent = 0);
explicit CodeCompletion(QmlJS::ModelManagerInterface *modelManager, QObject *parent = 0);
virtual ~CodeCompletion();
virtual TextEditor::ITextEditable *editor() const;
......
......@@ -97,7 +97,7 @@ public:
\param state The state for which this operation was created.
\param priority The priority for this operation.
*/
QmlJSQuickFixOperation(const QmlJSQuickFixState &state, int priority = -1);
explicit QmlJSQuickFixOperation(const QmlJSQuickFixState &state, int priority = -1);
virtual ~QmlJSQuickFixOperation();
virtual void perform();
......
......@@ -493,8 +493,8 @@ AST::Node *QmlOutlineModel::nodeForIndex(const QModelIndex &index) const
AST::SourceLocation QmlOutlineModel::sourceLocation(const QModelIndex &index) const
{
QTC_ASSERT(index.isValid() && (index.model() == this), return 0);
AST::SourceLocation location;
QTC_ASSERT(index.isValid() && (index.model() == this), return location);
AST::Node *node = nodeForIndex(index);
if (node) {
if (AST::UiObjectMember *member = node->uiObjectMemberCast())
......
......@@ -51,8 +51,8 @@ class QmlJSDesignDebugClient : public QDeclarativeDebugClient
{
Q_OBJECT
public:
QmlJSDesignDebugClient(QDeclarativeDebugConnection *client,
QObject *parent = 0);
explicit QmlJSDesignDebugClient(QDeclarativeDebugConnection *client,
QObject *parent = 0);
void setSelectedItemsByObjectId(const QList<QDeclarativeDebugObjectReference> &objects);
void reloadViewer();
......
......@@ -42,7 +42,7 @@ class ProjectLoadWizard : public QWizard
{
Q_OBJECT
public:
ProjectLoadWizard(Qt4Project *project, QWidget * parent = 0, Qt::WindowFlags flags = 0);
explicit ProjectLoadWizard(Qt4Project *project, QWidget * parent = 0, Qt::WindowFlags flags = 0);
virtual ~ProjectLoadWizard();
virtual void done(int result);
void execDialog();
......
......@@ -124,7 +124,7 @@ class S60DevicesPreferencePane : public Core::IOptionsPage
{
Q_OBJECT
public:
S60DevicesPreferencePane(S60Devices *devices, QObject *parent = 0);
explicit S60DevicesPreferencePane(S60Devices *devices, QObject *parent = 0);
~S60DevicesPreferencePane();
QString id() const;
......
......@@ -94,8 +94,8 @@ class S60EmulatorRunConfigurationWidget : public QWidget
{