Commit c81407f2 authored by hjk's avatar hjk
Browse files

Debugger: Lift restriction one-shot breakpoints deletion



This was/is a workaround to not lose the extra information carefully
crafted one-shot-breakpoints might carry (e.g. conditions). However,
it gets into the way when simple one-shot breakpoints are used
automatically ("Jump to line", or native-mixed debugging),
so actually deleting the bp in the ui if it's gone on the debugger
side seems the lesser evil nowadays.

Change-Id: If00dc4e8f27881236c05b17109b57d7c53d424ab
Reviewed-by: default avatarChristian Stenger <christian.stenger@theqtcompany.com>
parent 0bc18df6
......@@ -802,6 +802,7 @@ bool Breakpoint::isOneShot() const { return parameters().oneShot; }
void Breakpoint::removeAlienBreakpoint()
{
b->m_state = BreakpointRemoveProceeding;
b->deleteThis();
}
......
......@@ -598,8 +598,9 @@ void GdbEngine::handleResponse(const QByteArray &buff)
// This also triggers when a temporary breakpoint is hit.
// We do not really want that, as this loses all information.
// FIXME: Use a special marker for this case?
if (!bp.isOneShot())
bp.removeAlienBreakpoint();
// if (!bp.isOneShot()) ... is not sufficient.
// It keeps temporary "Jump" breakpoints alive.
bp.removeAlienBreakpoint();
}
} else if (asyncClass == "cmd-param-changed") {
// New since 2012-08-09
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment