use DISTFILES instead of OTHER_FILES in creator's own build system

it's the correct variable to use.

Change-Id: I9ec7795099097715a64969516cd3fae9e213a0f4
Reviewed-by: Daniel Teske <daniel.teske@digia.com>

bin/bin.pro

@@ -13,4 +13,4 @@ QMAKE_CLEAN = qtcreator.sh
 target.path  = $$QTC_PREFIX/bin
 INSTALLS    += target
 
-OTHER_FILES = $$PWD/qtcreator.sh
+DISTFILES = $$PWD/qtcreator.sh

doc/doc.pri

@@ -87,7 +87,7 @@ docs_online.depends = html_docs_online dev_html_docs_online
 docs.depends = qch_docs dev_qch_docs
 QMAKE_EXTRA_TARGETS += html_docs dev_html_docs html_docs_online dev_html_docs_online qch_docs dev_qch_docs docs docs_online
 
-OTHER_FILES = $$HELP_DEP_FILES $$DEV_HELP_DEP_FILES
+DISTFILES = $$HELP_DEP_FILES $$DEV_HELP_DEP_FILES
 
 fixnavi.commands = \
     cd $$shell_path($$PWD) && \

qtcreator.pri

@@ -144,7 +144,7 @@ qt {
 }
 
 QBSFILE = $$replace(_PRO_FILE_, \\.pro$, .qbs)
-exists($$QBSFILE):OTHER_FILES += $$QBSFILE
+exists($$QBSFILE):DISTFILES += $$QBSFILE
 
 !isEmpty(QTC_PLUGIN_DEPENDS):LIBS *= -L$$IDE_PLUGIN_PATH
 # recursively resolve plugin deps

qtcreator.pro

@@ -15,7 +15,7 @@ SUBDIRS = src share
 unix:!macx:!isEmpty(copydata):SUBDIRS += bin
 !isEmpty(BUILD_TESTS):SUBDIRS += tests
 
-OTHER_FILES += dist/copyright_template.txt \
+DISTFILES += dist/copyright_template.txt \
     $$files(dist/changes-*) \
     qtcreator.qbs \
     qbs/pluginjson/pluginjson.qbs \

share/qtcreator/qml/qmlpuppet/qml2puppet/qml2puppet.pri

@@ -38,7 +38,7 @@ SOURCES +=  $$PWD/qml2puppetmain.cpp
 RESOURCES +=  $$PWD/../qmlpuppet.qrc
 DEFINES -= QT_NO_CAST_FROM_ASCII
 
-OTHER_FILES += Info.plist
+DISTFILES += Info.plist
 
 unix:!osx:LIBS += -lrt # posix shared memory
 

share/qtcreator/qml/qmlpuppet/qmlpuppet/qmlpuppet.pri

@@ -26,7 +26,7 @@ DEFINES -= QT_NO_CAST_FROM_ASCII
 
 unix:!macx:LIBS += -lrt # posix shared memory
 
-OTHER_FILES += Info.plist
+DISTFILES += Info.plist
 macx {
     CONFIG -= app_bundle
     QMAKE_LFLAGS += -sectcreate __TEXT __info_plist \"$$PWD/Info.plist\"

share/share.pro

 TEMPLATE = subdirs
 SUBDIRS = qtcreator/static.pro \
           qtcreator/translations
-OTHER_FILES += share.qbs \
+DISTFILES += share.qbs \
     ../src/share/share.qbs

src/app/app.pro

@@ -35,7 +35,7 @@ win32 {
     INSTALLS    += target
 }
 
-OTHER_FILES += qtcreator.rc \
+DISTFILES += qtcreator.rc \
     Info.plist.in \
     $$PWD/app_version.h.in
 

src/libs/glsl/glsl-lib.pri

@@ -6,4 +6,4 @@ SOURCES += $$PWD/glslkeywords.cpp $$PWD/glslparser.cpp $$PWD/glslparsertable.cpp
     $$PWD/glslastvisitor.cpp $$PWD/glslengine.cpp $$PWD/glslmemorypool.cpp $$PWD/glslastdump.cpp \
     $$PWD/glslsemantic.cpp $$PWD/glsltype.cpp $$PWD/glsltypes.cpp $$PWD/glslsymbol.cpp $$PWD/glslsymbols.cpp
 
-OTHER_FILES = $$PWD/glsl.g
+DISTFILES = $$PWD/glsl.g

src/libs/qmldebug/qmldebug.pro

@@ -5,6 +5,6 @@ QTC_LIB_DEPENDS += utils
 include(../../qtcreatorlibrary.pri)
 include(qmldebug-lib.pri)
 
-OTHER_FILES += \
+DISTFILES += \
     qmldebug.pri
 

src/libs/qmleditorwidgets/qmleditorwidgets-lib.pri

@@ -44,4 +44,4 @@ FORMS += \
 include(easingpane/easingpane.pri)
 
 
-OTHER_FILES += qmleditorwidgets.pri
+DISTFILES += qmleditorwidgets.pri

src/libs/qmljs/parser/parser.pri

@@ -22,5 +22,5 @@ SOURCES += \
     $$PWD/qmldirparser.cpp \
     $$PWD/qmlerror.cpp \
 
-OTHER_FILES += \
+DISTFILES += \
     $$PWD/qmljs.g

src/libs/qmljs/qmljs-lib.pri

@@ -88,7 +88,7 @@ SOURCES += \
 RESOURCES += \
     $$PWD/qmljs.qrc
 
-OTHER_FILES += \
+DISTFILES += \
     $$PWD/parser/qmljs.g
 
 contains(QT, gui) {

src/plugins/clangcodemodel/clangcodemodel.pro

@@ -99,7 +99,7 @@ equals(TEST, 1) {
         $$PWD/test/completiontesthelper.cpp \
         $$PWD/test/clangcompletion_test.cpp
 
-    OTHER_FILES += \
+    DISTFILES += \
         $$PWD/test/cxx_regression_1.cpp \
         $$PWD/test/cxx_regression_2.cpp \
         $$PWD/test/cxx_regression_3.cpp \

src/plugins/coreplugin/coreplugin.pro

@@ -242,7 +242,7 @@ else:unix {
         INSTALLS += image$${imagesize}
     }
 }
-OTHER_FILES += editormanager/BinFiles.mimetypes.xml
+DISTFILES += editormanager/BinFiles.mimetypes.xml
 
 equals(TEST, 1) {
     SOURCES += testdatadir.cpp

src/plugins/designer/designer.pro

@@ -52,4 +52,4 @@ equals(TEST, 1) {
 
 RESOURCES += designer.qrc
 
-OTHER_FILES += README.txt
+DISTFILES += README.txt

src/plugins/qmldesigner/componentsplugin/componentsplugin.pri

@@ -35,4 +35,4 @@ FORMS += \
     $$PWD/addtabtotabviewdialog.ui
 
 
-OTHER_FILES += $$PWD/components.metainfo
+DISTFILES += $$PWD/components.metainfo

src/plugins/qmldesigner/qtquickplugin/qtquickplugin.pri

@@ -11,4 +11,4 @@ HEADERS += $$PWD/qtquickplugin.h  $$PWD/../designercore/include/iwidgetplugin.h
 
 RESOURCES += $$PWD/qtquickplugin.qrc
 
-OTHER_FILES += $$PWD/quick.metainfo
+DISTFILES += $$PWD/quick.metainfo

src/plugins/qmlprofiler/qmlprofiler.pro

@@ -70,7 +70,7 @@ HEADERS += \
 RESOURCES += \
     qml/qmlprofiler.qrc
 
-OTHER_FILES += \
+DISTFILES += \
     qml/ButtonsBar.qml \
     qml/Detail.qml \
     qml/CategoryLabel.qml \

src/qtcreatorplugin.pri

@@ -81,12 +81,12 @@ defineReplace(stripOutDir) {
 PLUGINJSON = $$_PRO_FILE_PWD_/$${TARGET}.json
 PLUGINJSON_IN = $${PLUGINJSON}.in
 exists($$PLUGINJSON_IN) {
-    OTHER_FILES += $$PLUGINJSON_IN
+    DISTFILES += $$PLUGINJSON_IN
     QMAKE_SUBSTITUTES += $$PLUGINJSON_IN
     PLUGINJSON = $$OUT_PWD/$${TARGET}.json
 } else {
     # need to support that for external plugins
-    OTHER_FILES += $$PLUGINJSON
+    DISTFILES += $$PLUGINJSON
 }
 
 osx: QMAKE_LFLAGS_SONAME = -Wl,-install_name,@rpath/PlugIns/
@@ -104,7 +104,7 @@ linux*:QMAKE_LFLAGS += $$QMAKE_LFLAGS_NOUNDEF
 }
 
 MIMETYPES = $$_PRO_FILE_PWD_/$${TARGET}.mimetypes.xml
-exists($$MIMETYPES):OTHER_FILES += $$MIMETYPES
+exists($$MIMETYPES):DISTFILES += $$MIMETYPES
 
 TARGET = $$qtLibraryName($$TARGET)