Remove some dead stores pointed out by clang.

Change-Id: I919a2e98474fec42861391d11d2ba1225eb2adf9
Reviewed-on: http://codereview.qt.nokia.com/4083

Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>

src/libs/3rdparty/cplusplus/Bind.cpp

@@ -2111,10 +2111,6 @@ bool Bind::visit(ParameterDeclarationAST *ast)
     // unsigned equal_token = ast->equal_token;
     ExpressionTy expression = this->expression(ast->expression);
 
-    unsigned sourceLocation = ast->firstToken();
-    if (declaratorId)
-        sourceLocation = declaratorId->firstToken();
-
     const Name *argName = 0;
     if (declaratorId && declaratorId->name)
         argName = declaratorId->name->name;

src/libs/3rdparty/cplusplus/Lexer.cpp

@@ -590,7 +590,6 @@ void Lexer::scan_helper(Token *tok)
                 break;
             } else if (ch == '@' && _yychar == '"') {
                 // objc @string literals
-                ch = _yychar;
                 yyinp();
                 tok->f.kind = T_AT_STRING_LITERAL;
 

src/plugins/qmljseditor/qmljshoverhandler.cpp

@@ -201,9 +201,11 @@ bool HoverHandler::matchColorItem(const ScopeChain &scopeChain,
             value = scopeChain.lookup(publicMember->name->asString());
             if (const Reference *ref = value->asReference())
                 value = scopeChain.context()->lookupReference(ref);
+            if (value && value->asColorValue()) {
                 color = textAt(qmlDocument,
                                publicMember->statement->firstSourceLocation(),
                                publicMember->statement->lastSourceLocation());
+            }
         }
     }
 

src/plugins/qmljstools/qmljsmodelmanager.cpp

@@ -558,20 +558,6 @@ void ModelManager::parse(QFutureInterface<void> &future,
 
         const QString fileName = files.at(i);
 
-        bool isQmlFile = true;
-        if (db) {
-            if (suffixMatches(fileName, jsSourceTy)) {
-                isQmlFile = false;
-            } else if (! suffixMatches(fileName, qmlSourceTy)) {
-                continue; // skip it. it's not a QML or a JS file.
-            }
-        } else {
-            if (fileName.contains(QLatin1String(".js"), Qt::CaseInsensitive))
-                isQmlFile = false;
-            else if (!fileName.contains(QLatin1String(".qml"), Qt::CaseInsensitive))
-                continue;
-        }
-
         QString contents;
         int documentRevision = 0;