Skip to content
Snippets Groups Projects
Commit f6847243 authored by Christian Kandeler's avatar Christian Kandeler
Browse files

RemoteLinux: Allow deploying to and running on non-Linux unices.

Change-Id: Ib8b8648cc93c37415e0cdb9785f47afbf04e781e
Reviewed-on: http://codereview.qt-project.org/4070


Reviewed-by: default avatarChristian Kandeler <christian.kandeler@nokia.com>
parent d191b22d
No related branches found
No related tags found
No related merge requests found
...@@ -55,7 +55,7 @@ RemoteLinuxDeployConfigurationFactory::RemoteLinuxDeployConfigurationFactory(QOb ...@@ -55,7 +55,7 @@ RemoteLinuxDeployConfigurationFactory::RemoteLinuxDeployConfigurationFactory(QOb
QStringList RemoteLinuxDeployConfigurationFactory::availableCreationIds(Target *parent) const QStringList RemoteLinuxDeployConfigurationFactory::availableCreationIds(Target *parent) const
{ {
QStringList ids; QStringList ids;
if (RemoteLinuxUtils::hasLinuxQt(parent)) if (RemoteLinuxUtils::hasUnixQt(parent))
ids << genericDeployConfigurationId(); ids << genericDeployConfigurationId();
return ids; return ids;
} }
......
...@@ -92,7 +92,7 @@ bool RemoteLinuxRunConfigurationFactory::canClone(Target *parent, RunConfigurati ...@@ -92,7 +92,7 @@ bool RemoteLinuxRunConfigurationFactory::canClone(Target *parent, RunConfigurati
QStringList RemoteLinuxRunConfigurationFactory::availableCreationIds(Target *parent) const QStringList RemoteLinuxRunConfigurationFactory::availableCreationIds(Target *parent) const
{ {
if (Qt4BaseTarget *t = qobject_cast<Qt4BaseTarget *>(parent)) { if (Qt4BaseTarget *t = qobject_cast<Qt4BaseTarget *>(parent)) {
if (t && RemoteLinuxUtils::hasLinuxQt(t)) { if (t && RemoteLinuxUtils::hasUnixQt(t)) {
return t->qt4Project()->applicationProFilePathes(RemoteLinuxRunConfiguration::Id); return t->qt4Project()->applicationProFilePathes(RemoteLinuxRunConfiguration::Id);
} }
} }
......
...@@ -52,14 +52,16 @@ namespace RemoteLinux { ...@@ -52,14 +52,16 @@ namespace RemoteLinux {
namespace Internal { namespace Internal {
namespace { namespace {
bool isLinuxQt(const BaseQtVersion *qtVersion) bool isUnixQt(const BaseQtVersion *qtVersion)
{ {
if (!qtVersion) if (!qtVersion)
return false; return false;
const QList<Abi> &abis = qtVersion->qtAbis(); const QList<Abi> &abis = qtVersion->qtAbis();
foreach (const Abi &abi, abis) { foreach (const Abi &abi, abis) {
if (abi.os() == Abi::LinuxOS) switch (abi.os()) {
return true; case Abi::UnixOS: case Abi::BsdOS: case Abi::LinuxOS: case Abi::MacOS: return true;
default: continue;
}
} }
return false; return false;
} }
...@@ -67,13 +69,13 @@ bool isLinuxQt(const BaseQtVersion *qtVersion) ...@@ -67,13 +69,13 @@ bool isLinuxQt(const BaseQtVersion *qtVersion)
} // anonymous namespace } // anonymous namespace
} // namespace Internal } // namespace Internal
bool RemoteLinuxUtils::hasLinuxQt(const Target *target) bool RemoteLinuxUtils::hasUnixQt(const Target *target)
{ {
const Qt4BaseTarget * const qtTarget = qobject_cast<const Qt4BaseTarget *>(target); const Qt4BaseTarget * const qtTarget = qobject_cast<const Qt4BaseTarget *>(target);
if (!qtTarget) if (!qtTarget)
return false; return false;
const Qt4BuildConfiguration * const bc = qtTarget->activeQt4BuildConfiguration(); const Qt4BuildConfiguration * const bc = qtTarget->activeQt4BuildConfiguration();
return bc && Internal::isLinuxQt(bc->qtVersion()); return bc && Internal::isUnixQt(bc->qtVersion());
} }
QString RemoteLinuxUtils::osTypeToString(const QString &osType) QString RemoteLinuxUtils::osTypeToString(const QString &osType)
......
...@@ -46,7 +46,7 @@ class LinuxDeviceConfiguration; ...@@ -46,7 +46,7 @@ class LinuxDeviceConfiguration;
class REMOTELINUX_EXPORT RemoteLinuxUtils class REMOTELINUX_EXPORT RemoteLinuxUtils
{ {
public: public:
static bool hasLinuxQt(const ProjectExplorer::Target *target); static bool hasUnixQt(const ProjectExplorer::Target *target);
static QString osTypeToString(const QString &osType); static QString osTypeToString(const QString &osType);
static QString deviceConfigurationName(const QSharedPointer<const LinuxDeviceConfiguration> &devConf); static QString deviceConfigurationName(const QSharedPointer<const LinuxDeviceConfiguration> &devConf);
}; };
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment