Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Target

Show changes

Only incoming changes from source

Include changes to target since source was created

Commits on Source 2

fix build with qt 4.7 · 245f8652
Oswald Buddenhagen authored Mar 11, 2010
```
it is source-incompatible to this broken code :)
```
245f8652

fix security hole: don't add an empty element to LD_LIBRARY_PATH · 3c00715c

Oswald Buddenhagen authored Sep 22, 2010

if LD_LIBRARY_PATH was empty, the wrapper script would add the empty
element to the path.

> The trailing colon is treated by ld.so as another item on the list,
> and empty items are treated as '.' (CWD). Therefore, if a user
> executes qtcreator from a directory where there's a library that would
> have normally been loaded from the standard library paths the local
> library would be loaded instead.
> This has the potential effect of arbitrary code execution.

Reviewed-by: thiago
Task-number: CVE-2010-3374

3c00715c

bin/qtcreator

+1
−1

Original line number
Diff line number
Diff line

@@ -31,6 +31,6 @@ fi

bindir=`dirname "$me"`

libdir=`cd "${bindir}/../lib" ; pwd`

LD_LIBRARY_PATH="${libdir}/qtcreator:${LD_LIBRARY_PATH}"

LD_LIBRARY_PATH="${libdir}/qtcreator${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"

export LD_LIBRARY_PATH

exec "${bindir}/qtcreator.bin" ${1+"$@"}

src/libs/cplusplus/TypePrettyPrinter.cpp

+1
−2

Original line number
Diff line number
Diff line

@@ -69,8 +69,7 @@ static QString fullyQualifiedName(Symbol *symbol, const Overview *overview)

}

TypePrettyPrinter::TypePrettyPrinter(const Overview *overview)

    : _overview(overview),

      _name(0)

    : _overview(overview)

{ }

TypePrettyPrinter::~TypePrettyPrinter()

Source

Target

Files